Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027408Retail ModulesWeb POSpublic2014-08-21 14:422014-09-01 08:43
ReporterOrekaria 
Assigned ToOrekaria 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR14Q4Fixed in VersionRR14Q4 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027408: Stabilization: The localDB database version should be set in a better place
DescriptionStabilization: The localDB database version should be set in a better place
Steps To ReproduceOpen the login-model.js file
Verify that this code is present:

        localDB: {
          size: 4 * 1024 * 1024,
          name: 'WEBPOS',
          displayName: 'Openbravo Web POS',
          version: '0.7'
        },

Verify that ob-terminal-model.js has similar code
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on feature request 0027400RR14Q4 closed Orekaria Stabilization: Overhaul Version management 
depends on feature request 0027417 closed Orekaria Stabilization: add a main.js file to any module in which centralize versions, deprecations, etc 
depends on defect 0027352RR14Q4 closed Orekaria Stabilization: The main.js file is containing code that should be in the login-model.js file 
blocks feature request 0027329 new Retail Stabilization: Overhaul the loading process (since the url is entered until the webpos has loaded) 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-08-21 14:42OrekariaNew Issue
2014-08-21 14:42OrekariaAssigned To => Orekaria
2014-08-21 14:42OrekariaTriggers an Emergency Pack => No
2014-08-21 14:42OrekariaRelationship addeddepends on 0027400
2014-08-22 00:02OrekariaStatusnew => scheduled
2014-08-22 00:02Orekariafix_in_branch => pi
2014-08-22 00:04OrekariaRelationship addedblocks 0027329
2014-08-22 00:54Orekariafix_in_branchpi =>
2014-08-22 00:54OrekariaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=6408#r6408
2014-08-22 01:31hgbotCheckin
2014-08-22 01:31hgbotNote Added: 0069590
2014-08-22 01:32hgbotCheckin
2014-08-22 01:32hgbotNote Added: 0069591
2014-08-22 01:38OrekariaNote Added: 0069592
2014-08-22 11:06OrekariaRelationship addeddepends on 0027417
2014-08-23 00:35hgbotCheckin
2014-08-23 00:35hgbotNote Added: 0069627
2014-08-23 00:35hgbotStatusscheduled => resolved
2014-08-23 00:35hgbotResolutionopen => fixed
2014-08-23 00:35hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ae6aba25d3329d3f03cc2f1f36310e53277c46e3 [^]
2014-08-23 00:37OrekariaStatusresolved => new
2014-08-23 00:37OrekariaResolutionfixed => open
2014-08-23 00:37OrekariaRelationship addeddepends on 0027352
2014-08-23 00:38OrekariaStatusnew => scheduled
2014-08-23 00:38Orekariafix_in_branch => pi
2014-08-23 00:38OrekariaStatusscheduled => resolved
2014-08-23 00:38OrekariaResolutionopen => fixed
2014-08-23 00:38OrekariaStatusresolved => new
2014-08-23 00:38OrekariaResolutionfixed => open
2014-08-23 00:38OrekariaStatusnew => scheduled
2014-08-23 00:38OrekariaStatusscheduled => resolved
2014-08-23 00:38OrekariaFixed in Version => RR14Q4
2014-08-23 00:38OrekariaResolutionopen => fixed
2014-09-01 08:43mtaalNote Added: 0069876
2014-09-01 08:43mtaalStatusresolved => closed

Notes
(0069590)
hgbot   
2014-08-22 01:31   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: e033441b4693c52a273869afd3e3d692744d9209
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Fri Aug 22 01:31:41 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/e033441b4693c52a273869afd3e3d692744d9209 [^]

Related to issue 27408: make use of the VersionManagement version info to refactor ob-terminal-model.js

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0069591)
hgbot   
2014-08-22 01:32   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 718d075d128b65593ca16f88c65f3dc70185b0cd
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Fri Aug 22 01:32:34 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/718d075d128b65593ca16f88c65f3dc70185b0cd [^]

Related to issue 27408: make use of the VersionManagement to refactor the database version management

---
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
---
(0069592)
Orekaria   
2014-08-22 01:38   
the approach for the mobile.core could be ok, but we should think on setting globals somewhere apart in each module needing them; this is more obvious with retail.posterminal because the version initialization in the login-model.js is not, by far, any good
(0069627)
hgbot   
2014-08-23 00:35   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: ae6aba25d3329d3f03cc2f1f36310e53277c46e3
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sat Aug 23 00:34:58 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ae6aba25d3329d3f03cc2f1f36310e53277c46e3 [^]

Fixes issue 27408: the VersionManagement info has been moved to main.js and...
... the main.js file has been moved to be processed before the rest of the posterminal's files

---
M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
M web/org.openbravo.retail.posterminal/js/main.js
---
(0069876)
mtaal   
2014-09-01 08:43   
In general the code refactor is not finished, but I guess this is a step in the good direction, therefore closing the issue.