Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0027404 | Retail Modules | Web POS | public | 2014-08-21 11:50 | 2014-09-29 18:18 |
|
| Reporter | Orekaria | |
| Assigned To | Orekaria | |
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | RR14Q4 | |
| Merge Request Status | |
| Review Assigned To | marvintm |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0027404: Stabilization: Revisit global namespace references |
| Description | Stabilization: Revisit global namespace references |
| Steps To Reproduce | Verify that some javascript files contains e.g:
OB = OB || {}
or
window.OB = OB
while others do not have them |
| Proposed Solution | Set a 'good practice' to set this global namespaces
Possible solutions:
- add them in all the files referencing them
- add them only in the first use
- group them in one file
- whatever |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | depends on | defect | 0027332 | RR14Q4 | closed | Orekaria | [API Deprecation] OB.UTILS is no longer a valid namespace and OB.UTIL is missing 2 files | | related to | defect | 0028650 | RR15Q2 | closed | Orekaria | Stabilization: RR15Q2 jsLint related fixes | | blocks | feature request | 0027329 | | new | Retail | Stabilization: Overhaul the loading process (since the url is entered until the webpos has loaded) |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2014-08-21 11:50 | Orekaria | New Issue | |
| 2014-08-21 11:50 | Orekaria | Assigned To | => marvintm |
| 2014-08-21 11:50 | Orekaria | Triggers an Emergency Pack | => No |
| 2014-08-21 11:51 | Orekaria | Relationship added | blocks 0027329 |
| 2014-08-21 11:54 | Orekaria | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=6398#r6398 |
| 2014-08-21 11:55 | Orekaria | Proposed Solution updated | |
| 2014-08-22 02:43 | Orekaria | Relationship added | depends on 0027332 |
| 2014-08-25 15:38 | Orekaria | Summary | Stabilization: Global namespace references have to be revisited => Stabilization: Revisit global namespace references |
| 2014-08-25 15:38 | Orekaria | Description Updated | bug_revision_view_page.php?rev_id=6452#r6452 |
| 2014-08-25 17:27 | Orekaria | Status | new => acknowledged |
| 2014-08-25 19:05 | Orekaria | Proposed Solution updated | |
| 2014-08-26 02:53 | hgbot | Checkin | |
| 2014-08-26 02:53 | hgbot | Note Added: 0069731 | |
| 2014-08-26 11:58 | hgbot | Checkin | |
| 2014-08-26 11:58 | hgbot | Note Added: 0069749 | |
| 2014-08-28 00:44 | hgbot | Checkin | |
| 2014-08-28 00:44 | hgbot | Note Added: 0069819 | |
| 2014-08-31 22:42 | hgbot | Checkin | |
| 2014-08-31 22:42 | hgbot | Note Added: 0069864 | |
| 2014-08-31 22:55 | hgbot | Checkin | |
| 2014-08-31 22:55 | hgbot | Note Added: 0069865 | |
| 2014-09-01 02:56 | hgbot | Checkin | |
| 2014-09-01 02:56 | hgbot | Note Added: 0069867 | |
| 2014-09-02 11:58 | hgbot | Checkin | |
| 2014-09-02 11:58 | hgbot | Note Added: 0069904 | |
| 2014-09-02 21:56 | Orekaria | Status | acknowledged => scheduled |
| 2014-09-02 21:56 | Orekaria | Assigned To | marvintm => Orekaria |
| 2014-09-02 21:56 | Orekaria | fix_in_branch | => pi |
| 2014-09-02 21:56 | Orekaria | Status | scheduled => resolved |
| 2014-09-02 21:56 | Orekaria | Fixed in Version | => RR14Q4 |
| 2014-09-02 21:56 | Orekaria | Resolution | open => fixed |
| 2014-09-05 09:14 | hgbot | Checkin | |
| 2014-09-05 09:14 | hgbot | Note Added: 0069975 | |
| 2014-09-07 17:33 | hgbot | Checkin | |
| 2014-09-07 17:33 | hgbot | Note Added: 0069992 | |
| 2014-09-08 23:53 | hgbot | Checkin | |
| 2014-09-08 23:53 | hgbot | Note Added: 0070031 | |
| 2014-09-09 00:14 | hgbot | Checkin | |
| 2014-09-09 00:14 | hgbot | Note Added: 0070032 | |
| 2014-09-10 00:12 | hgbot | Checkin | |
| 2014-09-10 00:12 | hgbot | Note Added: 0070064 | |
| 2014-09-15 22:28 | hgbot | Checkin | |
| 2014-09-15 22:28 | hgbot | Note Added: 0070129 | |
| 2014-09-15 23:37 | hgbot | Checkin | |
| 2014-09-15 23:37 | hgbot | Note Added: 0070130 | |
| 2014-09-15 23:37 | hgbot | Checkin | |
| 2014-09-15 23:37 | hgbot | Note Added: 0070132 | |
| 2014-09-16 17:59 | hgbot | Checkin | |
| 2014-09-16 17:59 | hgbot | Note Added: 0070153 | |
| 2014-09-24 19:56 | hgbot | Checkin | |
| 2014-09-24 19:56 | hgbot | Note Added: 0070326 | |
| 2014-09-24 20:56 | hgbot | Checkin | |
| 2014-09-24 20:56 | hgbot | Note Added: 0070330 | |
| 2014-09-25 03:28 | hgbot | Checkin | |
| 2014-09-25 03:28 | hgbot | Note Added: 0070342 | |
| 2014-09-25 03:41 | hgbot | Checkin | |
| 2014-09-25 03:41 | hgbot | Note Added: 0070343 | |
| 2014-09-25 11:11 | hgbot | Checkin | |
| 2014-09-25 11:11 | hgbot | Note Added: 0070346 | |
| 2014-09-25 11:12 | hgbot | Checkin | |
| 2014-09-25 11:12 | hgbot | Note Added: 0070347 | |
| 2014-09-25 11:12 | hgbot | Checkin | |
| 2014-09-25 11:12 | hgbot | Note Added: 0070348 | |
| 2014-09-25 11:42 | hgbot | Checkin | |
| 2014-09-25 11:42 | hgbot | Note Added: 0070364 | |
| 2014-09-25 12:27 | hgbot | Checkin | |
| 2014-09-25 12:27 | hgbot | Note Added: 0070371 | |
| 2014-09-25 16:34 | hgbot | Checkin | |
| 2014-09-25 16:34 | hgbot | Note Added: 0070390 | |
| 2014-09-25 19:48 | hgbot | Checkin | |
| 2014-09-25 19:48 | hgbot | Note Added: 0070402 | |
| 2014-09-26 00:43 | hgbot | Checkin | |
| 2014-09-26 00:43 | hgbot | Note Added: 0070414 | |
| 2014-09-28 05:53 | hgbot | Checkin | |
| 2014-09-28 05:53 | hgbot | Note Added: 0070474 | |
| 2014-09-29 18:18 | marvintm | Review Assigned To | => marvintm |
| 2014-09-29 18:18 | marvintm | Status | resolved => closed |
| 2015-01-16 17:10 | Orekaria | Relationship added | related to 0028650 |
|
Notes |
|
|
(0069731)
|
|
hgbot
|
|
2014-08-26 02:53
|
|
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 59b94903498ff5c36f08cff4a45e879dc3eb9677
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Tue Aug 26 02:47:26 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/59b94903498ff5c36f08cff4a45e879dc3eb9677 [^]
Related to issue 27404: The OB global namespace is not necessary. JsLint
---
M web/org.openbravo.mobile.core/source/component/dialog/ob-profile.js
M web/org.openbravo.mobile.core/source/component/ob-login.js
M web/org.openbravo.mobile.core/source/component/ob-terminal-component.js
M web/org.openbravo.mobile.core/source/data/ob-dal.js
M web/org.openbravo.mobile.core/source/data/ob-datasource.js
M web/org.openbravo.mobile.core/source/data/ob-model.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
M web/org.openbravo.mobile.core/source/utils/ob-debug.js
M web/org.openbravo.mobile.core/source/utils/ob-synchronization.js
M web/org.openbravo.mobile.core/source/utils/ob-utilities.js
M web/org.openbravo.mobile.core/source/utils/ob-versionmanagement.js
---
|
|
|
|
(0069749)
|
|
hgbot
|
|
2014-08-26 11:58
|
|
|
|
|
(0069819)
|
|
hgbot
|
|
2014-08-28 00:44
|
|
|
|
|
(0069864)
|
|
hgbot
|
|
2014-08-31 22:42
|
|
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 836bd4035b05a2e7583aa69cba01bf2922e6db3c
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sun Aug 31 22:39:52 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/836bd4035b05a2e7583aa69cba01bf2922e6db3c [^]
Related to issue 27404: JsLint
---
M web/org.openbravo.retail.posterminal/js/components/total.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
|
|
|
|
(0069865)
|
|
hgbot
|
|
2014-08-31 22:55
|
|
|
|
|
(0069867)
|
|
hgbot
|
|
2014-09-01 02:56
|
|
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 2689e45ab3ed62c36de6f8b82cbdaddeed75ed27
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Mon Sep 01 00:33:57 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2689e45ab3ed62c36de6f8b82cbdaddeed75ed27 [^]
Related to issue 27404: JsLint
---
M web/org.openbravo.retail.posterminal/js/components/order.js
M web/org.openbravo.retail.posterminal/js/components/renderorderline.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-right.js
---
|
|
|
|
(0069904)
|
|
hgbot
|
|
2014-09-02 11:58
|
|
|
|
|
(0069975)
|
|
hgbot
|
|
2014-09-05 09:14
|
|
|
|
|
(0069992)
|
|
hgbot
|
|
2014-09-07 17:33
|
|
|
|
|
(0070031)
|
|
hgbot
|
|
2014-09-08 23:53
|
|
|
|
|
(0070032)
|
|
hgbot
|
|
2014-09-09 00:14
|
|
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 21d2afa470b992896cf8f4a7dbbccc047cd85237
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Tue Sep 09 00:13:50 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/21d2afa470b992896cf8f4a7dbbccc047cd85237 [^]
Issue 27404. JsLint
---
M web/org.openbravo.mobile.core/source/component/ob-menu.js
M web/org.openbravo.mobile.core/source/data/ob-datasource.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
M web/org.openbravo.mobile.core/source/utils/ob-utilitiesui.js
---
|
|
|
|
(0070064)
|
|
hgbot
|
|
2014-09-10 00:12
|
|
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: c8a6c2645be6cb01aad349b12ea4ceb5f2b7ee52
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Tue Sep 09 16:37:20 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/c8a6c2645be6cb01aad349b12ea4ceb5f2b7ee52 [^]
Issue 27404. JsLint
---
M web/org.openbravo.mobile.core/source/component/dialog/ob-logout.js
M web/org.openbravo.mobile.core/source/component/ob-commonbuttons.js
M web/org.openbravo.mobile.core/source/data/ob-windowmodel.js
---
|
|
|
|
(0070129)
|
|
hgbot
|
|
2014-09-15 22:28
|
|
|
|
|
(0070130)
|
|
hgbot
|
|
2014-09-15 23:37
|
|
|
|
|
(0070132)
|
|
hgbot
|
|
2014-09-15 23:37
|
|
|
|
|
(0070153)
|
|
hgbot
|
|
2014-09-16 17:59
|
|
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 073134f1f181230c17197d32de63646581148431
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Tue Sep 16 17:55:56 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/073134f1f181230c17197d32de63646581148431 [^]
Issue 27404: JsLint
---
M web/org.openbravo.retail.posterminal/js/closecash/components/cashup-modals.js
M web/org.openbravo.retail.posterminal/js/closecash/view/tabpostprintclose.js
M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js
---
|
|
|
|
(0070326)
|
|
hgbot
|
|
2014-09-24 19:56
|
|
|
|
|
(0070330)
|
|
hgbot
|
|
2014-09-24 20:56
|
|
|
|
|
(0070342)
|
|
hgbot
|
|
2014-09-25 03:28
|
|
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 6f0205c5ad879e1c43383cfc010715619b8e34e2
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Thu Sep 25 03:28:26 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/6f0205c5ad879e1c43383cfc010715619b8e34e2 [^]
Issue 27404: JsLint
---
M web/org.openbravo.mobile.core/source/component/ob-keyboard.js
M web/org.openbravo.mobile.core/source/component/ob-menu.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
M web/org.openbravo.mobile.core/source/retail/component/ob-retail-searchproductcharacteristic.js
M web/org.openbravo.mobile.core/source/retail/component/ob-retail-searchproducts.js
M web/org.openbravo.mobile.core/source/utils/ob-utilities.js
---
|
|
|
|
(0070343)
|
|
hgbot
|
|
2014-09-25 03:41
|
|
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c5426e5ea999b8c4683b4eea75df1708f471eacd
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Thu Sep 25 03:40:49 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c5426e5ea999b8c4683b4eea75df1708f471eacd [^]
Issue 27404: JsLint
---
M web/org.openbravo.retail.posterminal/js/cashmgmt/view/listdepositsdrops.js
M web/org.openbravo.retail.posterminal/js/closecash/view/tabpostprintclose.js
M web/org.openbravo.retail.posterminal/js/components/keypadcoins.js
M web/org.openbravo.retail.posterminal/js/components/menu.js
M web/org.openbravo.retail.posterminal/js/components/modalcontextchanged.js
M web/org.openbravo.retail.posterminal/js/components/modalmultiorders.js
M web/org.openbravo.retail.posterminal/js/components/modalpaidreceipts.js
M web/org.openbravo.retail.posterminal/js/components/modalreceiptproperties.js
M web/org.openbravo.retail.posterminal/js/components/obpos-approval.js
M web/org.openbravo.retail.posterminal/js/components/order.js
M web/org.openbravo.retail.posterminal/js/components/rendermultiorderline.js
M web/org.openbravo.retail.posterminal/js/components/renderorderline.js
M web/org.openbravo.retail.posterminal/js/components/salesrepresentative.js
M web/org.openbravo.retail.posterminal/js/data/windowmodel.js
M web/org.openbravo.retail.posterminal/js/model/bplocation.js
M web/org.openbravo.retail.posterminal/js/model/businesspartner.js
M web/org.openbravo.retail.posterminal/js/model/discounts.js
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-print.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/editline.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/modals/modalcreditsales.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customeraddress/components/sharedcomponents.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customeraddress/editcreatecustomeraddress.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/customerdetailview.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/editcreatecustomerform.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/ticketdiscount.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-right.js
M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js
M web/org.openbravo.retail.posterminal/js/utils/ob-utilitiesuipos.js
---
|
|
|
|
(0070346)
|
|
hgbot
|
|
2014-09-25 11:11
|
|
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 6635476e85a17b469233236ef64bf6fc3c15d873
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Thu Sep 25 11:10:26 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6635476e85a17b469233236ef64bf6fc3c15d873 [^]
Issue 27404: JsLint
---
M web/org.openbravo.retail.posterminal/js/cashmgmt/components/cashmgmt-modals.js
M web/org.openbravo.retail.posterminal/js/cashmgmt/view/cashmgmtkeyboard.js
M web/org.openbravo.retail.posterminal/js/components/modalreceiptproperties.js
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
M web/org.openbravo.retail.posterminal/js/model/discounts.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/ps-productdetailsview.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customeraddress/components/sharedcomponents.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customeraddress/editcreatecustomeraddress.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/customerdetailview.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/editcreatecustomerform.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-right.js
M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js
---
|
|
|
|
(0070347)
|
|
hgbot
|
|
2014-09-25 11:12
|
|
|
|
|
(0070348)
|
|
hgbot
|
|
2014-09-25 11:12
|
|
|
|
|
(0070364)
|
|
hgbot
|
|
2014-09-25 11:42
|
|
|
|
|
(0070371)
|
|
hgbot
|
|
2014-09-25 12:27
|
|
|
|
|
(0070390)
|
|
hgbot
|
|
2014-09-25 16:34
|
|
|
|
|
(0070402)
|
|
hgbot
|
|
2014-09-25 19:48
|
|
|
|
|
(0070414)
|
|
hgbot
|
|
2014-09-26 00:43
|
|
|
|
|
(0070474)
|
|
hgbot
|
|
2014-09-28 05:53
|
|
|