Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027386Retail ModulesWeb POSpublic2014-08-20 12:582014-09-15 13:10
ReporterOrekaria 
Assigned ToOrekaria 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionno change required 
PlatformOS5OS Version
Product Version 
Target VersionRR14Q4Fixed in Version 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027386: Stabilization: Some models are making aync requests to the server before they are of any use
DescriptionStabilization: Some models are making aync requests to the server before they are of any use
Steps To ReproduceLoad the WebPOS

Verify that in the javascript console this XHR trace is shown (you may need to change the log level to debug):

XHR finished loading: GET "http://localhost:8080/openbravo/org.openbravo.client.kernel/OBMOBC_Main/Cli [^]…org.openbravo.retail.posterminal.master.DiscountFilterBusinessPartnerGroup". xhr.js:43
XHR finished loading: GET "http://localhost:8080/openbravo/org.openbravo.client.kernel/OBMOBC_Main/Cli [^]…modelName=Discount&source=org.openbravo.retail.posterminal.master.Discount". xhr.js:43
XHR finished loading: GET "http://localhost:8080/openbravo/org.openbravo.client.kernel/OBMOBC_Main/Cli [^]…urce=org.openbravo.retail.posterminal.master.DiscountFilterBusinessPartner". xhr.js:43
XHR finished loading: GET "http://localhost:8080/openbravo/org.openbravo.client.kernel/OBMOBC_Main/Cli [^]…urce=org.openbravo.retail.posterminal.master.DiscountFilterProductCategory". xhr.js:43
XHR finished loading: GET "http://localhost:8080/openbravo/org.openbravo.client.kernel/OBMOBC_Main/Cli [^]…oduct&source=org.openbravo.retail.posterminal.master.DiscountFilterProduct". xhr.js:43
XHR finished loading: GET "http://localhost:8080/openbravo/org.openbravo.client.kernel/OBMOBC_Main/Cli [^]…e&modelName=TaxRate&source=org.openbravo.retail.posterminal.master.TaxRate". xhr.js:43
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on design defect 0027428RR14Q4 closed Orekaria Stabilization: OB.Data.Registry should not be an enyo object 
blocks feature request 0027329 new Retail Stabilization: Overhaul the loading process (since the url is entered until the webpos has loaded) 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-08-20 12:58OrekariaNew Issue
2014-08-20 12:58OrekariaAssigned To => Orekaria
2014-08-20 12:58OrekariaOBNetwork customer => No
2014-08-20 12:58OrekariaTriggers an Emergency Pack => No
2014-08-20 12:58OrekariaRelationship addedblocks 0027329
2014-08-20 13:02OrekariaSummaryStabilization: some models are making request to the server before they are usuful => Stabilization: Some models are making aync requests to the server before they are of any use
2014-08-20 13:02OrekariaDescription Updatedbug_revision_view_page.php?rev_id=6386#r6386
2014-08-20 13:03OrekariaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=6388#r6388
2014-08-22 23:21OrekariaRelationship addeddepends on 0027428
2014-08-23 00:50hgbotCheckin
2014-08-23 00:50hgbotNote Added: 0069628
2014-08-23 00:50hgbotStatusnew => resolved
2014-08-23 00:50hgbotResolutionopen => fixed
2014-08-23 00:50hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/45c18dedead1c4e6802ca14cdffb59d0c6f632c4 [^]
2014-08-23 00:57OrekariaStatusresolved => new
2014-08-23 00:57OrekariaResolutionfixed => open
2014-08-23 01:17OrekariaNote Added: 0069630
2014-08-23 01:17OrekariaNote Edited: 0069630bug_revision_view_page.php?bugnote_id=0069630#r6431
2014-08-24 01:16hgbotCheckin
2014-08-24 01:16hgbotNote Added: 0069661
2014-08-24 01:16hgbotStatusnew => resolved
2014-08-24 01:16hgbotResolutionopen => fixed
2014-08-24 01:16hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/45c18dedead1c4e6802ca14cdffb59d0c6f632c4 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/27de9d57bc796851d5a34ddf1123f33ab8081d8d [^]
2014-08-24 01:58OrekariaStatusresolved => new
2014-08-24 01:58OrekariaResolutionfixed => open
2014-08-24 01:58OrekariaStatusnew => scheduled
2014-08-24 01:58Orekariafix_in_branch => pi
2014-08-24 16:49hgbotCheckin
2014-08-24 16:49hgbotNote Added: 0069671
2014-08-25 13:12OrekariaStatusscheduled => acknowledged
2014-08-25 13:13OrekariaStatusacknowledged => scheduled
2014-08-25 13:13Orekariafix_in_branchpi =>
2014-08-25 13:14OrekariaStatusscheduled => acknowledged
2014-08-25 18:17hgbotCheckin
2014-08-25 18:17hgbotNote Added: 0069719
2014-09-02 21:55OrekariaStatusacknowledged => scheduled
2014-09-02 21:55Orekariafix_in_branch => pi
2014-09-02 21:55OrekariaStatusscheduled => resolved
2014-09-02 21:55OrekariaFixed in Version => RR14Q4
2014-09-02 21:55OrekariaResolutionopen => fixed
2014-09-09 13:08OrekariaNote Added: 0070051
2014-09-09 13:08OrekariaStatusresolved => new
2014-09-09 13:08OrekariaResolutionfixed => open
2014-09-09 13:08OrekariaFixed in VersionRR14Q4 =>
2014-09-09 13:47hgbotCheckin
2014-09-09 13:47hgbotNote Added: 0070052
2014-09-09 13:48hgbotStatusnew => resolved
2014-09-09 13:48hgbotResolutionopen => fixed
2014-09-09 13:48hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/27de9d57bc796851d5a34ddf1123f33ab8081d8d [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/014cdb13ee8e8480ca9fd993f05efd9673da85ca [^]
2014-09-09 20:41OrekariaStatusresolved => new
2014-09-09 20:41OrekariaResolutionfixed => open
2014-09-14 17:19hgbotCheckin
2014-09-14 17:19hgbotNote Added: 0070117
2014-09-14 17:19hgbotStatusnew => resolved
2014-09-14 17:19hgbotResolutionopen => fixed
2014-09-14 17:19hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/014cdb13ee8e8480ca9fd993f05efd9673da85ca [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/8832275f1f147bbc4279db7bfa22ebd3e7182754 [^]
2014-09-15 13:09marvintmStatusresolved => new
2014-09-15 13:09marvintmResolutionfixed => open
2014-09-15 13:10marvintmReview Assigned To => marvintm
2014-09-15 13:10marvintmNote Added: 0070124
2014-09-15 13:10marvintmStatusnew => closed
2014-09-15 13:10marvintmResolutionopen => no change required

Notes
(0069628)
hgbot   
2014-08-23 00:50   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 45c18dedead1c4e6802ca14cdffb59d0c6f632c4
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sat Aug 23 00:50:06 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/45c18dedead1c4e6802ca14cdffb59d0c6f632c4 [^]

Fixes issue 27386: The models that were not needed until logged in have been delayed until logged in

---
M web/org.openbravo.mobile.core/source/data/ob-model.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0069630)
Orekaria   
2014-08-23 01:17   
If logged in, when a refresh is done (F5), the delayed models are not being loaded
(0069661)
hgbot   
2014-08-24 01:16   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 27de9d57bc796851d5a34ddf1123f33ab8081d8d
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sun Aug 24 01:16:42 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/27de9d57bc796851d5a34ddf1123f33ab8081d8d [^]

Fixes issue 27386: the client.kernel modules will be loaded after a successful login

---
M web/org.openbravo.mobile.core/source/data/ob-model.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0069671)
hgbot   
2014-08-24 16:49   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 99feff26ce4ee54928687030247dd6f7081dd8b1
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sun Aug 24 08:07:22 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/99feff26ce4ee54928687030247dd6f7081dd8b1 [^]

Related to issue 27386: Removed forgotten console.error in ob-terminal-model

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0069719)
hgbot   
2014-08-25 18:17   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 5ad74a32b0ff0ba4bfe52f3806e32fa5e2ac197f
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Mon Aug 25 18:04:04 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/5ad74a32b0ff0ba4bfe52f3806e32fa5e2ac197f [^]

Related to issue 27386: If the delayed generated models fail to load, stop the loading flow, and try again...
- comments

---
M web/org.openbravo.mobile.core/source/data/ob-model.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0070051)
Orekaria   
2014-09-09 13:08   
Is correct for the models to load before logged in, as the data is loaded after login.
(0070052)
hgbot   
2014-09-09 13:47   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 014cdb13ee8e8480ca9fd993f05efd9673da85ca
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Tue Sep 09 13:47:42 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/014cdb13ee8e8480ca9fd993f05efd9673da85ca [^]

Fixes issue 27386: the delayed functionality has been disabled by default...
- If this models are not necessary before the user logs in, they can be delayed, for improved performance

---
M web/org.openbravo.mobile.core/source/data/ob-model.js
---
(0070117)
hgbot   
2014-09-14 17:19   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 8832275f1f147bbc4279db7bfa22ebd3e7182754
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sun Sep 14 17:17:44 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/8832275f1f147bbc4279db7bfa22ebd3e7182754 [^]

Fixes issue 27386: backed out changesets related to 27386. The models should indeed load when the application is lauched.
- data, loaded with loadmodels is what has to be loaded after a successful login; as of now

---
M web/org.openbravo.mobile.core/source/data/ob-model.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0070124)
marvintm   
2014-09-15 13:10   
Models should indeed be loaded initially, it is wrong to defer their loading to after the login is done, because there is no guarantee that any of these models won't be needed before the login is done.