Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027379Openbravo ERPA. Platformpublic2014-08-19 20:372014-09-24 08:47
Reporterjecharri 
Assigned Toshankarb 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version3.0PR14Q4 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerOBPS
Web browserGoogle Chrome
ModulesCore
Support ticket29962
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027379: Module management window should show more information in openbravo.log file at minimum
DescriptionModule management window should show more information in openbravo.log file at minimum
Steps To Reproduce-try to install a module when you have database cahnges

You will receive the "changes have been found" popup but you don't know if there are structural changes or changes in tables with AD_ prefix like AD_table, AD_window, AD_field.

It should display more information about what has changed
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00273783.0PR15Q1 closed AugustoMauch Openbravo detects that there are database changes when it should not due to session configuration in ORACLE 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-08-19 20:37jecharriNew Issue
2014-08-19 20:37jecharriAssigned To => AugustoMauch
2014-08-19 20:37jecharriOBNetwork customer => Yes
2014-08-19 20:37jecharriWeb browser => Google Chrome
2014-08-19 20:37jecharriModules => Core
2014-08-19 20:37jecharriSupport ticket => 29962
2014-08-19 20:37jecharriResolution time => 1414796400
2014-08-19 20:37jecharriTriggers an Emergency Pack => No
2014-08-19 20:37jecharriIssue generated from0027378
2014-08-19 20:37jecharriRelationship addedrelated to 0027378
2014-08-19 20:42shuehnerNote Added: 0069529
2014-08-19 20:42shuehnerIssue Monitored: shuehner
2014-08-22 11:09AugustoMauchWeb browserGoogle Chrome => Google Chrome
2014-08-22 11:09AugustoMauchSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=6417#r6417
2014-09-15 08:17shankarbStatusnew => scheduled
2014-09-15 08:17shankarbfix_in_branch => pi
2014-09-15 08:19shankarbAssigned ToAugustoMauch => shankarb
2014-09-16 15:31shankarbReview Assigned To => alostale
2014-09-16 15:31shankarbWeb browserGoogle Chrome => Google Chrome
2014-09-16 15:31shankarbfix_in_branchpi =>
2014-09-16 15:32shankarbIssue Monitored: alostale
2014-09-16 15:34hgbotCheckin
2014-09-16 15:34hgbotNote Added: 0070148
2014-09-16 15:34hgbotStatusscheduled => resolved
2014-09-16 15:34hgbotResolutionopen => fixed
2014-09-16 15:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b575a744497a433447ce5384c7ee9312c1fc71ca [^]
2014-09-17 01:50hudsonbotCheckin
2014-09-17 01:50hudsonbotNote Added: 0070162
2014-09-22 10:17hgbotCheckin
2014-09-22 10:17hgbotNote Added: 0070224
2014-09-22 10:17hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/b575a744497a433447ce5384c7ee9312c1fc71ca [^] => http://code.openbravo.com/erp/devel/dbsm-main/rev/672f90d0eb6a9007ee57059bcdaa489478bf85b8 [^]
2014-09-24 08:47alostaleNote Added: 0070298
2014-09-24 08:47alostaleStatusresolved => closed
2014-09-24 08:47alostaleFixed in Version => 3.0PR14Q4

Notes
(0069529)
shuehner   
2014-08-19 20:42   
Note at least log into openbravo.log i.e. warn level if ad_db_modified or the check against AD dataset data produces the local changes info.

When changing that please also verify that the log.warn statement inside obdata.java (from dbsm-main dbsourcemanager sourcecode) does go into openbravo.log (it should as we pass logger instance in ModuleManagement.java to the hasChanged call but please verify)
(0070148)
hgbot   
2014-09-16 15:34   
Repository: erp/devel/pi
Changeset: b575a744497a433447ce5384c7ee9312c1fc71ca
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Tue Sep 16 19:03:27 2014 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/b575a744497a433447ce5384c7ee9312c1fc71ca [^]

Fixes issue 27379: Modified tables are displayed in build popup.

When installing new modules in module management, if there are local changes,
the modified tables are displayed.

---
M src-db/database/lib/dbsourcemanager.jar
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/erpCommon/ad_forms/ModuleManagement.java
---
(0070162)
hudsonbot   
2014-09-17 01:50   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8faa150d42bc [^]
Maturity status: Test
(0070224)
hgbot   
2014-09-22 10:17   
Repository: erp/devel/dbsm-main
Changeset: 672f90d0eb6a9007ee57059bcdaa489478bf85b8
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Tue Sep 16 18:09:08 2014 +0530
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/672f90d0eb6a9007ee57059bcdaa489478bf85b8 [^]

Fixes Issue 27379: Updated tables that are modified in the hasChanged method of OBDataset.

---
M src/org/openbravo/ddlutils/util/OBDataset.java
---
(0070298)
alostale   
2014-09-24 08:47   
code reviewed + tested