Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027372Openbravo ERPA. Platformpublic2014-08-19 13:142014-09-09 10:46
Reportermtaal 
Assigned ToAugustoMauch 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR14Q4Fixed in Version3.0PR14Q4 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027372: KernelServlet is not threadsafe
DescriptionThe kernel servlet does not seem to be threadsafe if there are multiple component requests which have bypass authentication on true.
Steps To ReproduceOpen a webpos retail page and check the log for invalidation messages.

A code review by itself already shows the threadunsafeness. See the proposed diff for a solution.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0027248 closed marvintm Retail Modules Sometimes the session expires before it should, use a different servlet/url for retrieving content before login 
blocks defect 0027337 acknowledged Retail Retail Modules Stabilization: No tomcat errors while running the WebPOS 
Attached Filesdiff kernelservlet.diff (6,588) 2014-08-19 13:14
https://issues.openbravo.com/file_download.php?file_id=7140&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-08-19 13:14mtaalNew Issue
2014-08-19 13:14mtaalAssigned To => alostale
2014-08-19 13:14mtaalFile Added: kernelservlet.diff
2014-08-19 13:14mtaalModules => Core
2014-08-19 13:14mtaalTriggers an Emergency Pack => No
2014-08-19 13:14mtaalRelationship addedblocks 0027248
2014-08-19 14:57OrekariaRelationship addedblocks 0027337
2014-08-22 09:17AugustoMauchAssigned Toalostale => AugustoMauch
2014-08-22 09:28AugustoMauchIssue Monitored: alostale
2014-08-22 09:32AugustoMauchReview Assigned To => alostale
2014-08-22 09:36hgbotCheckin
2014-08-22 09:36hgbotNote Added: 0069598
2014-08-22 09:36hgbotStatusnew => resolved
2014-08-22 09:36hgbotResolutionopen => fixed
2014-08-22 09:36hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/3b2473c7f544bd9f8453956d730a3028530f77ee [^]
2014-08-22 10:38OrekariaIssue Monitored: Orekaria
2014-08-22 17:10hudsonbotCheckin
2014-08-22 17:10hudsonbotNote Added: 0069617
2014-08-27 10:04OrekariaStatusresolved => new
2014-08-27 10:04OrekariaResolutionfixed => open
2014-08-27 10:04OrekariaStatusnew => scheduled
2014-08-27 10:04Orekariafix_in_branch => pi
2014-09-02 22:18OrekariaStatusscheduled => resolved
2014-09-02 22:18OrekariaFixed in Version => 3.0PR14Q4
2014-09-02 22:18OrekariaResolutionopen => fixed
2014-09-09 10:46alostaleNote Added: 0070043
2014-09-09 10:46alostaleStatusresolved => closed

Notes
(0069598)
hgbot   
2014-08-22 09:36   
Repository: erp/devel/pi
Changeset: 3b2473c7f544bd9f8453956d730a3028530f77ee
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Aug 22 09:28:39 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/3b2473c7f544bd9f8453956d730a3028530f77ee [^]

Fixes issue 27372: Some parts of the KernelServlet should be thread safe

The code that handles the forced sessions request counter should be thread safe, so it has been moved to a synchronized block.

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/KernelServlet.java
---
(0069617)
hudsonbot   
2014-08-22 17:10   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/3431be2d547a [^]
Maturity status: Test
(0070043)
alostale   
2014-09-09 10:46   
code reviewed and tested