Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027370Openbravo ERPA. Platformpublic2014-08-19 11:472014-09-26 08:52
ReporterOrekaria 
Assigned ToOrekaria 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR14Q4 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027370: Stabilization: When the session is invalidated the backend should not try to retrieve session attributes
DescriptionStability: When the session is invalidated the backend should not try to retrieve session attributes

As of now, when the session is invalidated, all the attributes are trying to be retrieved, adding lines to the console.error that do not report of the real issue, that is, that the session is invalidated
Steps To ReproduceIn the VariablesBase.java file
Find the setSessionValue method
Replace the following code to invalidate the session:

  public void setSessionValue(String attribute, String value) {
    try {
      session.setAttribute(attribute.toUpperCase(), value);
      session.invalidate();
      if (!attribute.equalsIgnoreCase("menuVertical"))
        ...
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0026955 closed Orekaria Retail Modules Sometimes the ad_user_id is sent null to the backend provoking an error 
blocks defect 0027337 acknowledged Retail Retail Modules Stabilization: No tomcat errors while running the WebPOS 
Attached Filesdiff openbravo_24274_24275.diff (3,393) 2014-08-19 17:41
https://issues.openbravo.com/file_download.php?file_id=7143&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-08-19 11:47OrekariaNew Issue
2014-08-19 11:47OrekariaAssigned To => Orekaria
2014-08-19 11:47OrekariaTriggers an Emergency Pack => No
2014-08-19 11:50OrekariaSummaryStability: When the session is invalidated the backend should not try to retrieve session attributes => Stabilization: When the session is invalidated the backend should not try to retrieve session attributes
2014-08-19 11:51OrekariaRelationship addedblocks 0026955
2014-08-19 11:51OrekariaRelationship addedblocks 0027337
2014-08-19 11:52OrekariaIssue Monitored: AugustoMauch
2014-08-19 12:00hgbotCheckin
2014-08-19 12:00hgbotNote Added: 0069500
2014-08-19 12:00hgbotStatusnew => resolved
2014-08-19 12:00hgbotResolutionopen => fixed
2014-08-19 12:00hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/292e42c687269c52234dcfdbf0e73c9c6a2fff84 [^]
2014-08-19 12:39hgbotCheckin
2014-08-19 12:39hgbotNote Added: 0069503
2014-08-19 12:39hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/292e42c687269c52234dcfdbf0e73c9c6a2fff84 [^] => http://code.openbravo.com/erp/devel/pi/rev/cf2476a790bf9d816043c7262d0e3380db2fe3ad [^]
2014-08-19 13:00AugustoMauchProjectRetail Modules => Openbravo ERP
2014-08-19 13:02AugustoMauchNote Added: 0069505
2014-08-19 13:02AugustoMauchStatusresolved => new
2014-08-19 13:02AugustoMauchResolutionfixed => open
2014-08-19 13:02AugustoMauchModules => Core
2014-08-19 13:02AugustoMauchCategoryWeb POS => A. Platform
2014-08-19 13:02AugustoMauchTarget VersionRR14Q4 =>
2014-08-19 13:02AugustoMauchStatusnew => scheduled
2014-08-19 13:02AugustoMauchfix_in_branch => pi
2014-08-19 13:02AugustoMauchStatusscheduled => resolved
2014-08-19 13:02AugustoMauchResolutionopen => fixed
2014-08-19 17:32OrekariaStatusresolved => new
2014-08-19 17:32OrekariaResolutionfixed => open
2014-08-19 17:35hgbotCheckin
2014-08-19 17:35hgbotNote Added: 0069519
2014-08-19 17:35hgbotCheckin
2014-08-19 17:35hgbotNote Added: 0069520
2014-08-19 17:41OrekariaFile Added: openbravo_24274_24275.diff
2014-08-19 19:44hudsonbotCheckin
2014-08-19 19:44hudsonbotNote Added: 0069524
2014-08-19 20:43OrekariaNote Added: 0069530
2014-08-19 20:44OrekariaNote Edited: 0069530bug_revision_view_page.php?bugnote_id=0069530#r6369
2014-08-19 20:45OrekariaNote Edited: 0069530bug_revision_view_page.php?bugnote_id=0069530#r6370
2014-08-19 20:45OrekariaNote Edited: 0069530bug_revision_view_page.php?bugnote_id=0069530#r6371
2014-08-20 15:14hudsonbotCheckin
2014-08-20 15:14hudsonbotNote Added: 0069547
2014-08-20 15:14hudsonbotCheckin
2014-08-20 15:14hudsonbotNote Added: 0069550
2014-08-20 15:14hudsonbotCheckin
2014-08-20 15:14hudsonbotNote Added: 0069551
2014-08-22 02:31Orekariafix_in_branchpi =>
2014-08-22 02:31OrekariaDescription Updatedbug_revision_view_page.php?rev_id=6410#r6410
2014-08-22 15:27hgbotCheckin
2014-08-22 15:27hgbotNote Added: 0069616
2014-08-22 15:27hgbotStatusnew => resolved
2014-08-22 15:27hgbotResolutionopen => fixed
2014-08-22 15:27hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/cf2476a790bf9d816043c7262d0e3380db2fe3ad [^] => http://code.openbravo.com/erp/devel/pi/rev/67bb1feb836ae466eb2a2d2417bf8eb3425fa41d [^]
2014-08-22 21:11OrekariaStatusresolved => new
2014-08-22 21:11OrekariaResolutionfixed => open
2014-08-22 21:11OrekariaStatusnew => scheduled
2014-08-22 21:11Orekariafix_in_branch => pi
2014-08-23 16:30hudsonbotCheckin
2014-08-23 16:30hudsonbotNote Added: 0069647
2014-08-24 06:14hgbotCheckin
2014-08-24 06:14hgbotNote Added: 0069663
2014-08-24 15:47hudsonbotCheckin
2014-08-24 15:47hudsonbotNote Added: 0069669
2014-09-02 22:18OrekariaStatusscheduled => resolved
2014-09-02 22:18OrekariaFixed in Version => 3.0PR14Q4
2014-09-02 22:18OrekariaResolutionopen => fixed
2014-09-23 12:56mtaalReview Assigned To => alostale
2014-09-26 08:52alostaleNote Added: 0070422
2014-09-26 08:52alostaleStatusresolved => closed

Notes
(0069500)
hgbot   
2014-08-19 12:00   
Repository: erp/devel/pi
Changeset: 292e42c687269c52234dcfdbf0e73c9c6a2fff84
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Tue Aug 19 12:00:02 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/292e42c687269c52234dcfdbf0e73c9c6a2fff84 [^]

Fixes issue 27370: If the session is invalidated while retriving session attributes,
- the session will end
- the console log will report that the session was invalidated while retriving attributes

---
M src-core/src/org/openbravo/base/VariablesBase.java
M src/org/openbravo/base/secureApp/HttpSecureAppServlet.java
---
(0069503)
hgbot   
2014-08-19 12:39   
Repository: erp/devel/pi
Changeset: cf2476a790bf9d816043c7262d0e3380db2fe3ad
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Tue Aug 19 12:39:04 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/cf2476a790bf9d816043c7262d0e3380db2fe3ad [^]

Fixes issue 27370: If the session is invalidated while retriving or removing session attributes,
- the session will end
- the console log will properly report that the session was invalidated

Methods involved (setSessionValue was fixed wth the above changeset):
- getSessionValue
- removeSessionValue

---
M src-core/src/org/openbravo/base/VariablesBase.java
---
(0069505)
AugustoMauch   
2014-08-19 13:02   
Reopened to update issue fields
(0069519)
hgbot   
2014-08-19 17:35   
Repository: erp/devel/pi
Changeset: 53ea1d3637f9fe772f9c4e9182064d7654106e2e
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Tue Aug 19 17:32:35 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/53ea1d3637f9fe772f9c4e9182064d7654106e2e [^]

Related to issue 27370: Backed out rev 24275, changeset: cf2476a790bf
If the session is invalidated while retrieving session attributes...
(getSessionValue, removeSessionValue)

---
M src-core/src/org/openbravo/base/VariablesBase.java
---
(0069520)
hgbot   
2014-08-19 17:35   
Repository: erp/devel/pi
Changeset: b6c3c0ad739e7360f711c5c5f84d227e0434e17a
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Tue Aug 19 17:34:25 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b6c3c0ad739e7360f711c5c5f84d227e0434e17a [^]

Related to issue 27370: Backed out rev 24274, changeset: 292e42c68726
If the session is invalidated while retrieving session attributes...
(setSessionValue)

---
M src-core/src/org/openbravo/base/VariablesBase.java
M src/org/openbravo/base/secureApp/HttpSecureAppServlet.java
---
(0069524)
hudsonbot   
2014-08-19 19:44   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dfa98e390e6a [^]
Maturity status: Test
(0069530)
Orekaria   
2014-08-19 20:43   
(edited on: 2014-08-19 20:45)
All int (for the setSessionValue, the get and remove changeset didn't get on time to reach the end of the flow before I back rolled the changesets) and retail tests have passed

.diff added for the inspection of the Platform team
(0069547)
hudsonbot   
2014-08-20 15:14   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2b6fe7d2babe [^]
Maturity status: Test
(0069550)
hudsonbot   
2014-08-20 15:14   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2b6fe7d2babe [^]
Maturity status: Test
(0069551)
hudsonbot   
2014-08-20 15:14   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2b6fe7d2babe [^]
Maturity status: Test
(0069616)
hgbot   
2014-08-22 15:27   
Repository: erp/devel/pi
Changeset: 67bb1feb836ae466eb2a2d2417bf8eb3425fa41d
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Tue Aug 19 12:39:04 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/67bb1feb836ae466eb2a2d2417bf8eb3425fa41d [^]

Fixes issue 27370: If the session is invalidated while retriving, changing or removing session attributes,
- the session will end
- the console log will properly report that the session was invalidated

Methods involved (setSessionValue was fixed wth the above changeset):
- getSessionValue
- setSessionValue
- removeSessionValue

---
M src-core/src/org/openbravo/base/VariablesBase.java
M src/org/openbravo/base/secureApp/HttpSecureAppServlet.java
---
(0069647)
hudsonbot   
2014-08-23 16:30   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/81b875753850 [^]
Maturity status: Test
(0069663)
hgbot   
2014-08-24 06:14   
Repository: erp/devel/pi
Changeset: b434c7af3cfd3c4d6d79c54b769c66fe552318cd
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sun Aug 24 06:12:23 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b434c7af3cfd3c4d6d79c54b769c66fe552318cd [^]

Related to issue 27370: If the session is invalidated while setting session attributes,
- the session will end
- the console log will properly report that the session was invalidated
Method affected:
- setSessionValue
Methods not affected any longer:
- getSessionValue
- removeSessionValue

---
M src-core/src/org/openbravo/base/VariablesBase.java
---
(0069669)
hudsonbot   
2014-08-24 15:47   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0e088398c072 [^]
Maturity status: Test
(0070422)
alostale   
2014-09-26 08:52   
code reviewed

test: I couldn't reproduce a real use case for this issue, tested by invalidating sessions arbitrarily, in this cases proper messages appear in the log