Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027364Openbravo ERP09. Financial managementpublic2014-08-18 20:252014-08-27 19:19
Reporterjecharri 
Assigned ToAugustoMauch 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Versionpi 
Merge Request Status
Review Assigned Toumartirena
OBNetwork customer
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression level
Regression date2014-06-19
Regression introduced in release3.0PR14Q3
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi-aprm-windows/rev/f94f08e02e3a [^]
Triggers an Emergency PackNo
Summary0027364: It is not possible to use the Check All button in the new add details parameter window when a lot of registers are selected
DescriptionIt is not possible fiter in the new add details button when a lot of registers are selected
Steps To ReproduceYou have to have more than 100 invoices pending to pay

-Go to window "payment in"
-Create a header and insert a big amount
-Press in add Details

You will see that a lot of records are selected and you can not filter properly by business partner (for example) because first you need to unselect all the Business Partners. However selected records always are displayed and the result of the filter is at the end of the grid
Proposed Solution-be able to uncheck all the record pressing the grid top-left checkbox.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-08-18 20:25jecharriNew Issue
2014-08-18 20:25jecharriAssigned To => dmiguelez
2014-08-18 20:25jecharriWeb browser => Google Chrome
2014-08-18 20:25jecharriModules => Core
2014-08-18 20:25jecharriResolution time => 1408744800
2014-08-18 20:25jecharriTriggers an Emergency Pack => No
2014-08-18 20:31heccamIssue Monitored: heccam
2014-08-21 12:41AugustoMauchWeb browserGoogle Chrome => Google Chrome
2014-08-21 12:41AugustoMauchSummaryIt is not possible fiter in the new add details button when a lot of registers are selected => It is not possible to use the Check All button in the new add details parameter window when a lot of registers are selected
2014-08-21 12:41AugustoMauchAssigned Todmiguelez => AugustoMauch
2014-08-21 12:54AugustoMauchNote Added: 0069572
2014-08-21 16:51AugustoMauchIssue Monitored: Sandrahuguet
2014-08-21 16:51AugustoMauchReview Assigned To => Sandrahuguet
2014-08-21 16:51AugustoMauchWeb browserGoogle Chrome => Google Chrome
2014-08-21 16:55hgbotCheckin
2014-08-21 16:55hgbotNote Added: 0069580
2014-08-21 16:55hgbotStatusnew => resolved
2014-08-21 16:55hgbotResolutionopen => fixed
2014-08-21 16:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/955bdd54d89ab46d3deaba07f083d613a2e28ced [^]
2014-08-22 04:18hudsonbotCheckin
2014-08-22 04:18hudsonbotNote Added: 0069597
2014-08-27 09:14umartirenaNote Added: 0069789
2014-08-27 09:14umartirenaStatusresolved => new
2014-08-27 09:14umartirenaResolutionfixed => open
2014-08-27 09:25hgbotCheckin
2014-08-27 09:25hgbotNote Added: 0069790
2014-08-27 09:25hgbotStatusnew => resolved
2014-08-27 09:25hgbotResolutionopen => fixed
2014-08-27 09:25hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/955bdd54d89ab46d3deaba07f083d613a2e28ced [^] => http://code.openbravo.com/erp/devel/pi/rev/03e6d16acce6c91b9301ca2c13d388801ed4d013 [^]
2014-08-27 11:09AugustoMauchNote Added: 0069793
2014-08-27 11:09AugustoMauchStatusresolved => new
2014-08-27 11:09AugustoMauchResolutionfixed => open
2014-08-27 11:09AugustoMauchWeb browserGoogle Chrome => Google Chrome
2014-08-27 11:09AugustoMauchRegression date => 2014-06-19
2014-08-27 11:09AugustoMauchRegression introduced in release => 3.0PR14Q3
2014-08-27 11:09AugustoMauchRegression introduced by commit => https://code.openbravo.com/erp/devel/pi-aprm-windows/rev/f94f08e02e3a [^]
2014-08-27 11:10AugustoMauchStatusnew => scheduled
2014-08-27 11:10AugustoMauchfix_in_branch => pi
2014-08-27 11:10AugustoMauchStatusscheduled => resolved
2014-08-27 11:10AugustoMauchResolutionopen => fixed
2014-08-27 11:16hgbotCheckin
2014-08-27 11:16hgbotNote Added: 0069794
2014-08-27 11:58umartirenaReview Assigned ToSandrahuguet => umartirena
2014-08-27 11:58umartirenaNote Added: 0069797
2014-08-27 11:58umartirenaStatusresolved => closed
2014-08-27 11:58umartirenaFixed in Version => pi
2014-08-27 19:19hudsonbotCheckin
2014-08-27 19:19hudsonbotNote Added: 0069815
2014-08-27 19:19hudsonbotCheckin
2014-08-27 19:19hudsonbotNote Added: 0069816

Notes
(0069572)
AugustoMauch   
2014-08-21 12:54   
The Check All button does not work because not all the records have been loaded to the grid, only the first few pages. This button only works then all the data is cached in the grid, and must work like these, because otherwise some records that are not cached locally should be selected, which is not possible.

The following approach is going to be followed: if not all the records are cached when the grid in this grid, the amount is not going to be distributed at all, so there will be no need to use the Uncheck All button to empty the grid selection. In most cases it did not make sense in the first place to distribute the amount between a number of records such large.
(0069580)
hgbot   
2014-08-21 16:55   
Repository: erp/devel/pi
Changeset: 955bdd54d89ab46d3deaba07f083d613a2e28ced
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Aug 21 16:54:26 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/955bdd54d89ab46d3deaba07f083d613a2e28ced [^]

Fixes issue 27364: Check All button does not work in Order/Invoice P&E grid

Now if the records does not fit in the first page, the distribute amount function will not be executed. Instead, a message will be shown to the user in the message bar.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MESSAGE.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_REF_LIST.xml
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
---
(0069597)
hudsonbot   
2014-08-22 04:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/077608c0d57c [^]
Maturity status: Test
(0069789)
umartirena   
2014-08-27 09:14   
Reopened
(0069790)
hgbot   
2014-08-27 09:25   
Repository: erp/devel/pi
Changeset: 03e6d16acce6c91b9301ca2c13d388801ed4d013
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Aug 27 09:24:52 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/03e6d16acce6c91b9301ca2c13d388801ed4d013 [^]

Fixes issue 27364: Check All button does not work in Order/Invoice P&E grid

In certain conditions grid.data.localData.length did not return the number of cached records. It is better to use grid.data.cachedRows.

---
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
---
(0069793)
AugustoMauch   
2014-08-27 11:09   
Reopened to enter regression fields
(0069794)
hgbot   
2014-08-27 11:16   
Repository: erp/devel/pi
Changeset: 0c00434877f3f23d90aa62a800b75e2f7c1c7150
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Aug 27 11:15:51 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/0c00434877f3f23d90aa62a800b75e2f7c1c7150 [^]

Related to issue 27364: Hide the message bar if the distribute process is done

---
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
---
(0069797)
umartirena   
2014-08-27 11:58   
Issue tested and verified
(0069815)
hudsonbot   
2014-08-27 19:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/eb6e5df16d4d [^]
Maturity status: Test
(0069816)
hudsonbot   
2014-08-27 19:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/eb6e5df16d4d [^]
Maturity status: Test