Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027363Openbravo ERP09. Financial managementpublic2014-08-18 20:102014-08-21 11:19
Reporterjecharri 
Assigned ToAtulOpenbravo 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR14Q3Fixed in Version3.0PR14Q4 
Merge Request Status
Review Assigned Tojecharri
OBNetwork customerOBPS
Web browserGoogle Chrome
ModulesCore
Support ticket30531
Regression levelProduction - QA Approved
Regression date2014-07-01
Regression introduced in release3.0PR14Q3
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/b1843f200a9092eea99d431776d029a09868615a [^]
Triggers an Emergency PackNo
Summary0027363: It exists a case where the currency is not set to business partners and can create big problems
DescriptionIt exists a case where the currency is not set to business partners and can create big problems because it is impossible to create payment in or payment out because the JAVA is trying to get the currency.

file
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java
line
String toCurrency = businessPartner.getCurrency().getId();

Steps To ReproduceThe problem is the module script of the above changeset. It can happens that update return null.
It happens when the BP is checked as "bp.iscustomer='Y' " and price list is null but " bp.isvendor='Y' " and has a price list.


UPDATE C_Bpartner bp
         SET BP_Currency_ID = (
                              SELECT C_Currency_ID
                              FROM M_Pricelist
                              WHERE M_Pricelist_ID=(case when bp.iscustomer='Y' then bp.M_Pricelist_ID
                                                         when bp.isvendor='Y' then bp.PO_Pricelist_ID
                                                         end)
                              )
         WHERE bp.BP_Currency_ID IS NULL
         AND ((bp.IsCustomer = 'Y' and bp.m_pricelist_id is not null) OR
              (bp.IsVendor = 'Y' and bp.po_pricelist_id is not null));
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-08-18 20:10jecharriNew Issue
2014-08-18 20:10jecharriAssigned To => dmiguelez
2014-08-18 20:10jecharriOBNetwork customer => Yes
2014-08-18 20:10jecharriWeb browser => Google Chrome
2014-08-18 20:10jecharriModules => Core
2014-08-18 20:10jecharriSupport ticket => 30531
2014-08-18 20:10jecharriResolution time => 1408744800
2014-08-18 20:10jecharriRegression level => Production - QA Approved
2014-08-18 20:10jecharriRegression date => 2014-07-01
2014-08-18 20:10jecharriRegression introduced in release => 3.0PR14Q3
2014-08-18 20:10jecharriRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/b1843f200a9092eea99d431776d029a09868615a [^]
2014-08-18 20:10jecharriTriggers an Emergency Pack => No
2014-08-18 20:34heccamIssue Monitored: heccam
2014-08-18 20:41jecharriWeb browserGoogle Chrome => Google Chrome
2014-08-18 20:41jecharriSummarySometimes the currency is not set to business partners and can create big problems => It exists a case where the currency is not set to business partners and can create big problems
2014-08-18 20:41jecharriDescription Updatedbug_revision_view_page.php?rev_id=6336#r6336
2014-08-19 08:46AtulOpenbravoAssigned Todmiguelez => AtulOpenbravo
2014-08-19 08:50AtulOpenbravoStatusnew => scheduled
2014-08-19 08:50AtulOpenbravofix_in_branch => pi
2014-08-20 07:55AtulOpenbravoReview Assigned To => jecharri
2014-08-20 07:55AtulOpenbravoWeb browserGoogle Chrome => Google Chrome
2014-08-20 07:55AtulOpenbravofix_in_branchpi =>
2014-08-20 07:57hgbotCheckin
2014-08-20 07:57hgbotNote Added: 0069534
2014-08-20 07:57hgbotStatusscheduled => resolved
2014-08-20 07:57hgbotResolutionopen => fixed
2014-08-20 07:57hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/723fbb6fcb2a9b08ea15e243979141008c6a0686 [^]
2014-08-20 15:14hudsonbotCheckin
2014-08-20 15:14hudsonbotNote Added: 0069552
2014-08-21 11:19daniOpenbravoNote Added: 0069562
2014-08-21 11:19daniOpenbravoStatusresolved => closed
2014-08-21 11:19daniOpenbravoFixed in Version => 3.0PR14Q4

Notes
(0069534)
hgbot   
2014-08-20 07:57   
Repository: erp/devel/pi
Changeset: 723fbb6fcb2a9b08ea15e243979141008c6a0686
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue Aug 19 15:28:48 2014 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/723fbb6fcb2a9b08ea15e243979141008c6a0686 [^]

Fixes Issue 27363:Exists a case where currency is not set to business partner
and could create big problems.

---
M src-util/modulescript/build/classes/org/openbravo/modulescript/InitializeBPCurrency.class
M src-util/modulescript/build/classes/org/openbravo/modulescript/InitializeBPCurrencyData.class
M src-util/modulescript/src/org/openbravo/modulescript/InitializeBPCurrency.java
M src-util/modulescript/src/org/openbravo/modulescript/InitializeBPCurrency_data.xsql
A src-util/modulescript/build/javasqlc/src/org/openbravo/modulescript/InitializeBPCurrencyData.java
---
(0069552)
hudsonbot   
2014-08-20 15:14   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2b6fe7d2babe [^]
Maturity status: Test
(0069562)
daniOpenbravo   
2014-08-21 11:19   
Verified.