Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027351Retail ModulesWeb POSpublic2014-08-17 00:152014-08-24 15:47
ReporterOrekaria 
Assigned ToOrekaria 
PrioritynormalSeveritycriticalReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR14Q4Fixed in VersionRR14Q4 
Merge Request Status
Review Assigned Tomtaal
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027351: Stabilization: The globalResources in the Component Providers are being created hundreds of times and the code is thread unsafe
DescriptionStabilization: The globalResources in the Component Providers are being created hundreds of times and the code is thread unsafe
Steps To ReproduceIn the MobileCoreComponentProvider.java add this code at the end of the file:

      System.out.println("checking globalResources.size: " + globalResources.size());

      return globalResources;
    }
  }

Open the WebPOS
Verify the System.out.output in the tomcat console log
Verify that the count should be = 40, but sometimes is more or less (thread unsafe)
Verify that the very same array is created over and over

Add this same System.out.println line to other <module>ComponentProvider.java
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0027348RR14Q4 closed Orekaria Stabilization: Refactor the MobileCoreComponentProvider for better readability and more atomic commits 
blocks feature request 0027329 new Retail Stabilization: Overhaul the loading process (since the url is entered until the webpos has loaded) 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-08-17 00:15OrekariaNew Issue
2014-08-17 00:15OrekariaAssigned To => Orekaria
2014-08-17 00:15OrekariaTriggers an Emergency Pack => No
2014-08-17 00:16OrekariaRelationship addedblocks 0027329
2014-08-17 00:25hgbotCheckin
2014-08-17 00:25hgbotNote Added: 0069410
2014-08-17 00:25hgbotStatusnew => resolved
2014-08-17 00:25hgbotResolutionopen => fixed
2014-08-17 00:25hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/64b43ec6b05c4ac2f611446513d888f110c9b2d7 [^]
2014-08-17 00:32hgbotCheckin
2014-08-17 00:32hgbotNote Added: 0069411
2014-08-17 00:32hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/64b43ec6b05c4ac2f611446513d888f110c9b2d7 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9e1d2f32261052a83f3ed68e7f5259aa7bd1cb20 [^]
2014-08-17 12:30hgbotCheckin
2014-08-17 12:30hgbotNote Added: 0069415
2014-08-17 12:31OrekariaStatusresolved => new
2014-08-17 12:31OrekariaResolutionfixed => open
2014-08-17 15:09hgbotCheckin
2014-08-17 15:09hgbotNote Added: 0069422
2014-08-17 15:09hgbotStatusnew => resolved
2014-08-17 15:09hgbotResolutionopen => fixed
2014-08-17 15:09hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9e1d2f32261052a83f3ed68e7f5259aa7bd1cb20 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/6a6753151bd4f219ed85b64c7b590c84e1955f1f [^]
2014-08-17 15:09OrekariaStatusresolved => new
2014-08-17 15:09OrekariaResolutionfixed => open
2014-08-17 15:10OrekariaNote Deleted: 0069411
2014-08-17 15:10OrekariaNote Deleted: 0069415
2014-08-17 15:13OrekariaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=6319#r6319
2014-08-17 15:14hgbotCheckin
2014-08-17 15:14hgbotNote Added: 0069423
2014-08-17 15:14hgbotStatusnew => resolved
2014-08-17 15:14hgbotResolutionopen => fixed
2014-08-17 15:14hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/6a6753151bd4f219ed85b64c7b590c84e1955f1f [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ac81e375391e199954d7316baecd60a6948fc927 [^]
2014-08-17 17:01OrekariaStatusresolved => new
2014-08-17 17:01OrekariaResolutionfixed => open
2014-08-17 17:03OrekariaSeverityminor => critical
2014-08-17 17:03OrekariaSummaryPerformance: The list of resources of the Component Providers are being created hundreds of times => Performance: The globalResources in the Component Providers are being created hundreds of times and the code is thread unsafe
2014-08-17 17:03OrekariaDescription Updatedbug_revision_view_page.php?rev_id=6324#r6324
2014-08-17 17:04OrekariaSummaryPerformance: The globalResources in the Component Providers are being created hundreds of times and the code is thread unsafe => Stabilization: The globalResources in the Component Providers are being created hundreds of times and the code is thread unsafe
2014-08-17 17:04OrekariaDescription Updatedbug_revision_view_page.php?rev_id=6325#r6325
2014-08-17 17:09hgbotCheckin
2014-08-17 17:09hgbotNote Added: 0069429
2014-08-17 17:09hgbotStatusnew => resolved
2014-08-17 17:09hgbotResolutionopen => fixed
2014-08-17 17:09hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ac81e375391e199954d7316baecd60a6948fc927 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/fcc0100ea23be8e37f663bd23cfdf1c10968e69f [^]
2014-08-17 17:10hgbotCheckin
2014-08-17 17:10hgbotNote Added: 0069430
2014-08-17 17:10hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/fcc0100ea23be8e37f663bd23cfdf1c10968e69f [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/3dcc63c26236df1ff330fdcef3fe670058e796ba [^]
2014-08-17 17:35hgbotCheckin
2014-08-17 17:35hgbotNote Added: 0069433
2014-08-17 17:35hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/3dcc63c26236df1ff330fdcef3fe670058e796ba [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2dfd7f540c214d52f5750e89c29a40d5c150b1cf [^]
2014-08-17 17:37hgbotCheckin
2014-08-17 17:37hgbotNote Added: 0069434
2014-08-17 17:37hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2dfd7f540c214d52f5750e89c29a40d5c150b1cf [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/496bd0747a9781cbe66d59a908f6c667abf4a7a4 [^]
2014-08-17 17:37hgbotCheckin
2014-08-17 17:37hgbotNote Added: 0069435
2014-08-17 17:37hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/496bd0747a9781cbe66d59a908f6c667abf4a7a4 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/5d43f620e20693562edf45bc3f8238f246d88949 [^]
2014-08-17 18:01hgbotCheckin
2014-08-17 18:01hgbotNote Added: 0069437
2014-08-17 18:01hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/5d43f620e20693562edf45bc3f8238f246d88949 [^] => http://code.openbravo.com/erp/devel/pi/rev/87b13b8ceac8a153efaaecae2cc6eb08a4203593 [^]
2014-08-17 18:12OrekariaIssue Monitored: alostale
2014-08-18 01:58hudsonbotCheckin
2014-08-18 01:58hudsonbotNote Added: 0069453
2014-08-18 10:13OrekariaStatusresolved => new
2014-08-18 10:13OrekariaResolutionfixed => open
2014-08-18 10:57OrekariaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=6326#r6326
2014-08-18 10:57OrekariaStatusnew => scheduled
2014-08-18 10:57Orekariafix_in_branch => pi
2014-08-18 10:58OrekariaStatusscheduled => resolved
2014-08-18 10:58OrekariaFixed in Version => RR14Q4
2014-08-18 10:58OrekariaResolutionopen => fixed
2014-08-18 10:58OrekariaIssue Monitored: shuehner
2014-08-18 10:58OrekariaIssue Monitored: mtaal
2014-08-18 11:00OrekariaStatusresolved => new
2014-08-18 11:00OrekariaResolutionfixed => open
2014-08-18 11:00OrekariaFixed in VersionRR14Q4 =>
2014-08-18 11:02Orekariafix_in_branchpi =>
2014-08-18 11:02OrekariaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=6327#r6327
2014-08-18 11:02OrekariaStatusnew => scheduled
2014-08-18 11:02Orekariafix_in_branch => pi
2014-08-18 11:03OrekariaStatusscheduled => resolved
2014-08-18 11:03OrekariaFixed in Version => RR14Q4
2014-08-18 11:03OrekariaResolutionopen => fixed
2014-08-18 14:59OrekariaRelationship addeddepends on 0027348
2014-08-22 02:17OrekariaStatusresolved => new
2014-08-22 02:17OrekariaResolutionfixed => open
2014-08-22 02:17OrekariaFixed in VersionRR14Q4 =>
2014-08-22 02:19OrekariaFile Added: openbravo_24274_24275.diff
2014-08-22 02:21OrekariaStatusnew => scheduled
2014-08-22 02:22OrekariaFile Deleted: openbravo_24274_24275.diff
2014-08-22 02:22OrekariaStatusscheduled => resolved
2014-08-22 02:22OrekariaFixed in Version => RR14Q4
2014-08-22 02:22OrekariaResolutionopen => fixed
2014-08-22 10:28mtaalNote Added: 0069602
2014-08-22 10:28mtaalStatusresolved => new
2014-08-22 10:28mtaalResolutionfixed => open
2014-08-22 10:28mtaalFixed in VersionRR14Q4 =>
2014-08-23 01:34hgbotCheckin
2014-08-23 01:34hgbotNote Added: 0069631
2014-08-23 01:34hgbotStatusnew => resolved
2014-08-23 01:34hgbotResolutionopen => fixed
2014-08-23 01:34hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/87b13b8ceac8a153efaaecae2cc6eb08a4203593 [^] => http://code.openbravo.com/erp/devel/pi/rev/daa69c127184d785356a2268620511c2ae0a0e56 [^]
2014-08-23 01:34hgbotCheckin
2014-08-23 01:34hgbotNote Added: 0069632
2014-08-23 01:34hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/daa69c127184d785356a2268620511c2ae0a0e56 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/b964170c9118836cc6c0589888b460653aedfcb0 [^]
2014-08-23 01:34hgbotCheckin
2014-08-23 01:34hgbotNote Added: 0069633
2014-08-23 01:34hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/b964170c9118836cc6c0589888b460653aedfcb0 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2745e49351f0f65ed1f8d983eabe3fdcc4ef15c2 [^]
2014-08-23 01:34hgbotCheckin
2014-08-23 01:34hgbotNote Added: 0069634
2014-08-23 01:34hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2745e49351f0f65ed1f8d983eabe3fdcc4ef15c2 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/061bc6480e561ca812c44e6ff8f3a88663570c39 [^]
2014-08-23 01:35hgbotCheckin
2014-08-23 01:35hgbotNote Added: 0069635
2014-08-23 01:35hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/061bc6480e561ca812c44e6ff8f3a88663570c39 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/4a6f75a6c3a9c7ea585ad5b9934bf3619f6f51b0 [^]
2014-08-23 09:08hgbotCheckin
2014-08-23 09:08hgbotNote Added: 0069636
2014-08-23 10:50mtaalReview Assigned To => mtaal
2014-08-23 10:50mtaalNote Added: 0069638
2014-08-23 10:50mtaalStatusresolved => closed
2014-08-23 10:50mtaalFixed in Version => RR14Q4
2014-08-23 10:52hgbotCheckin
2014-08-23 10:52hgbotNote Added: 0069639
2014-08-23 10:52hgbotStatusclosed => resolved
2014-08-23 10:52hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/4a6f75a6c3a9c7ea585ad5b9934bf3619f6f51b0 [^] => http://code.openbravo.com/erp/devel/pi/rev/a2f9c55b5ca95422e3580ec97b08b1d10ff744ac [^]
2014-08-23 16:30hudsonbotCheckin
2014-08-23 16:30hudsonbotNote Added: 0069648
2014-08-23 16:30hudsonbotCheckin
2014-08-23 16:30hudsonbotNote Added: 0069649
2014-08-23 23:47mtaalNote Added: 0069655
2014-08-23 23:47mtaalStatusresolved => closed
2014-08-24 15:47hudsonbotCheckin
2014-08-24 15:47hudsonbotNote Added: 0069668

Notes
(0069410)
hgbot   
2014-08-17 00:25   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 64b43ec6b05c4ac2f611446513d888f110c9b2d7
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sun Aug 17 00:25:34 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/64b43ec6b05c4ac2f611446513d888f110c9b2d7 [^]

Fixes issue 27351: When calling the 'getGlobalComponentResources' method of the 'MobileCoreComponentProvider' class, the array 'globalResources' will not be recreated if it is not necessary

---
M src/org/openbravo/mobile/core/MobileCoreComponentProvider.java
---
(0069422)
hgbot   
2014-08-17 15:09   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 6a6753151bd4f219ed85b64c7b590c84e1955f1f
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sun Aug 17 15:09:18 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/6a6753151bd4f219ed85b64c7b590c84e1955f1f [^]

Fixes issue 27351: 'getGlobalComponentResources' have to be set as synchronized because multiple calls were corrupting the globalResources array
Mark variables as final is not necessary but a nice plus

---
M src/org/openbravo/mobile/core/MobileCoreComponentProvider.java
---
(0069423)
hgbot   
2014-08-17 15:14   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: ac81e375391e199954d7316baecd60a6948fc927
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sun Aug 17 15:14:47 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ac81e375391e199954d7316baecd60a6948fc927 [^]

Fixes issue 27351: When calling the 'getGlobalComponentResources' method of the 'OBPOSComponentProvider' class, the array 'globalResources' will not be recreated if it is not necessary
- finals is a bonus

---
M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java
---
(0069429)
hgbot   
2014-08-17 17:09   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: fcc0100ea23be8e37f663bd23cfdf1c10968e69f
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sun Aug 17 17:09:48 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/fcc0100ea23be8e37f663bd23cfdf1c10968e69f [^]

Fixes issue 27351: 'getGlobalComponentResources' have to be set as synchronized because multiple calls were corrupting the globalResources array
Marking variables as final was not necessary but a nice plus

---
M src/org/openbravo/retail/returns/ReturnsComponentProvider.java
---
(0069430)
hgbot   
2014-08-17 17:10   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: 3dcc63c26236df1ff330fdcef3fe670058e796ba
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sun Aug 17 17:10:25 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/3dcc63c26236df1ff330fdcef3fe670058e796ba [^]

Fixes issue 27351: 'getGlobalComponentResources' have to be set as synchronized because multiple calls were corrupting the globalResources array
Marking variables as final was not necessary but a nice plus

---
M src/org/openbravo/retail/discounts/DiscountsComponentProvider.java
---
(0069433)
hgbot   
2014-08-17 17:35   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 2dfd7f540c214d52f5750e89c29a40d5c150b1cf
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sun Aug 17 17:34:33 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2dfd7f540c214d52f5750e89c29a40d5c150b1cf [^]

Fixes issue 27351: The null check is no longer needed

---
M src/org/openbravo/mobile/core/MobileCoreComponentProvider.java
---
(0069434)
hgbot   
2014-08-17 17:37   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: 496bd0747a9781cbe66d59a908f6c667abf4a7a4
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sun Aug 17 17:37:09 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/496bd0747a9781cbe66d59a908f6c667abf4a7a4 [^]

Fixes issue 27351: The null check is no longer needed (returns)

---
M src/org/openbravo/retail/returns/ReturnsComponentProvider.java
---
(0069435)
hgbot   
2014-08-17 17:37   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: 5d43f620e20693562edf45bc3f8238f246d88949
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sun Aug 17 17:37:39 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/5d43f620e20693562edf45bc3f8238f246d88949 [^]

Fixes issue 27351: The null check is no longer needed (Discounts)

---
M src/org/openbravo/retail/discounts/DiscountsComponentProvider.java
---
(0069437)
hgbot   
2014-08-17 18:01   
Repository: erp/devel/pi
Changeset: 87b13b8ceac8a153efaaecae2cc6eb08a4203593
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sun Aug 17 18:01:11 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/87b13b8ceac8a153efaaecae2cc6eb08a4203593 [^]

Fixes issue 27351: 'getGlobalComponentResources' have to be set as synchronized because multiple calls were corrupting the globalResources array
Marking variables as final was not necessary but a nice plus
(client.kernel)
(service.datasource)

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/KernelComponentProvider.java
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceComponentProvider.java
---
(0069453)
hudsonbot   
2014-08-18 01:58   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ed428d44c18c [^]
Maturity status: Test
(0069602)
mtaal   
2014-08-22 10:28   
I think the java code should be different:
- make the globalresources member private and place the declaration in the top of the class after the static members/methods
- initialize the globalresources with null, don't make it final

then make the getGlobalComponentResources synchronized and structure it like this:
public List<ComponentResource> getGlobalComponentResources() {
 if (globalResources != null) {
 return globalResources;
}
globalResources = new ArrayList<ComponentResource>();

gr. Martin
(0069631)
hgbot   
2014-08-23 01:34   
Repository: erp/devel/pi
Changeset: daa69c127184d785356a2268620511c2ae0a0e56
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sat Aug 23 01:31:40 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/daa69c127184d785356a2268620511c2ae0a0e56 [^]

Fixes issue 27351: refactor (kernel, datasource)

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/KernelComponentProvider.java
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceComponentProvider.java
---
(0069632)
hgbot   
2014-08-23 01:34   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: b964170c9118836cc6c0589888b460653aedfcb0
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sat Aug 23 01:32:14 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/b964170c9118836cc6c0589888b460653aedfcb0 [^]

Fixes issue 27351: refactor (MobileCore)

---
M src/org/openbravo/mobile/core/MobileCoreComponentProvider.java
---
(0069633)
hgbot   
2014-08-23 01:34   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 2745e49351f0f65ed1f8d983eabe3fdcc4ef15c2
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sat Aug 23 01:32:39 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2745e49351f0f65ed1f8d983eabe3fdcc4ef15c2 [^]

Fixes issue 27351: refactor (posterminal)

---
M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java
---
(0069634)
hgbot   
2014-08-23 01:34   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: 061bc6480e561ca812c44e6ff8f3a88663570c39
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sat Aug 23 01:33:06 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/061bc6480e561ca812c44e6ff8f3a88663570c39 [^]

Fixes issue 27351: refactor (Returns)

---
M src/org/openbravo/retail/returns/ReturnsComponentProvider.java
---
(0069635)
hgbot   
2014-08-23 01:35   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: 4a6f75a6c3a9c7ea585ad5b9934bf3619f6f51b0
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sat Aug 23 01:33:21 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/4a6f75a6c3a9c7ea585ad5b9934bf3619f6f51b0 [^]

Fixes issue 27351: refactor (Discounts)

---
M src/org/openbravo/retail/discounts/DiscountsComponentProvider.java
---
(0069636)
hgbot   
2014-08-23 09:08   
Repository: erp/devel/pi
Changeset: 077fca7b3c709f3447fe0fab9d0ad1a9d37b7c6b
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sat Aug 23 09:05:26 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/077fca7b3c709f3447fe0fab9d0ad1a9d37b7c6b [^]

Issue 27351. Backed out rev. 24307, changeset: daa69c127184
refactor (kernel, datasource)
may the changeset not pass the tests

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/KernelComponentProvider.java
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceComponentProvider.java
---
(0069638)
mtaal   
2014-08-23 10:50   
Reviewed
(0069639)
hgbot   
2014-08-23 10:52   
Repository: erp/devel/pi
Changeset: a2f9c55b5ca95422e3580ec97b08b1d10ff744ac
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sat Aug 23 01:31:40 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a2f9c55b5ca95422e3580ec97b08b1d10ff744ac [^]

Fixes issue 27351: refactor (kernel, datasource) (II)

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/KernelComponentProvider.java
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceComponentProvider.java
---
(0069648)
hudsonbot   
2014-08-23 16:30   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/81b875753850 [^]
Maturity status: Test
(0069649)
hudsonbot   
2014-08-23 16:30   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/81b875753850 [^]
Maturity status: Test
(0069655)
mtaal   
2014-08-23 23:47   
Reviewed
(0069668)
hudsonbot   
2014-08-24 15:47   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0e088398c072 [^]
Maturity status: Test