Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027349Retail ModulesWeb POSpublic2014-08-16 13:542015-01-28 12:54
ReporterOrekaria 
Assigned ToOrekaria 
PrioritynormalSeveritycriticalReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR14Q4Fixed in VersionRR14Q4 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027349: [API Deprecation] The HookManager does not have to depend on the OB.MobileApp.model object
DescriptionThere is no reason for the HookManager to depend on when the OB.MobileApp.model is created, thus, the objects must have their own namespace

Reason for this API change: If the HookManager depends on OB.MobileApp.model, the creation of the model have to be done before the HookManager attaches to it.
This behavior is unwanted and leads to:
  - unnecessary restrictions in further code developments
  - errors if the HookManager is not available when requested
  - errors if the HookManager was instanciated before the model was, because if OB.MobleApp.model is initialized after the HookManager, the HookManager is removed

Changelog:
  - OB.UTIL.HookManager now instanciates itself
  - removed the initialization 'this.hookManager = new OB.UTIL.HookManager();' in ob-terminal-model.js
  - renamed all occurrences of OB.MobileApp.model to OB.UTIL.HookManager

Howto update custom code for this change:
  - rename all occurrences of OB.MobileApp.model to OB.UTIL.HookManager

Regressions will happen if the OB.MobileApp.model is not renamed to OB.UTIL.HookManager after applying this patch
Steps To ReproduceVerify that the HookManager is inserted in the Backbone model OB.MobileApp.model
Verify that in ob-terminal-model.js the HookManager is instanciated
Verify that if 'this.hookManager = new OB.UTIL.HookManager();' in ob-terminal-model.js is removed/commented, the browser fails to load the javascript file
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0027350RR14Q4 closed Orekaria Stabilization: Checking if the HookManager is available is not necessary 
depends on feature request 0027400RR14Q4 closed Orekaria Stabilization: Overhaul Version management 
depends on feature request 0027417 closed Orekaria Stabilization: add a main.js file to any module in which centralize versions, deprecations, etc 
blocks feature request 0027329 new Retail Stabilization: Overhaul the loading process (since the url is entered until the webpos has loaded) 
blocks defect 0027399 closed mario_castello Stabilization: Raname the HookManager references in the LevelPricing and ScalableLevelPricing retail modules 
blocks feature request 0027470pi closed aaroncalero It would be nice to add a hook after OBPOS_PrePaymentHook but before OBPOS_CheckPaymentApproval 
blocks defect 0028829RR15Q2 closed mtaal Solve deprecation warnings in console caused by usage of deprecated api 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-08-16 13:54OrekariaNew Issue
2014-08-16 13:54OrekariaAssigned To => Orekaria
2014-08-16 13:54OrekariaTriggers an Emergency Pack => No
2014-08-16 14:09OrekariaRelationship addeddepends on 0027350
2014-08-16 14:09OrekariaRelationship addedblocks 0027329
2014-08-16 14:24OrekariaSummary[API Change] The HookManager depends on the OB.MobileApp.model object => [API Change] The HookManager does not have to depend on the OB.MobileApp.model object
2014-08-16 14:45hgbotCheckin
2014-08-16 14:45hgbotNote Added: 0069398
2014-08-16 14:45hgbotStatusnew => resolved
2014-08-16 14:45hgbotResolutionopen => fixed
2014-08-16 14:45hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/5d93e0cec2bdfc6e977df214fdffcef45f54ca39 [^]
2014-08-16 14:45hgbotCheckin
2014-08-16 14:45hgbotNote Added: 0069399
2014-08-16 14:45hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/5d93e0cec2bdfc6e977df214fdffcef45f54ca39 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4a0f9b4c99d38e6586bfa684db63e562cb6cb17a [^]
2014-08-16 14:45hgbotCheckin
2014-08-16 14:45hgbotNote Added: 0069400
2014-08-16 14:46hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4a0f9b4c99d38e6586bfa684db63e562cb6cb17a [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/690720566444ae31cdf4de59b7033cdd1de0aa07 [^]
2014-08-16 14:46hgbotCheckin
2014-08-16 14:46hgbotNote Added: 0069401
2014-08-16 14:46hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/690720566444ae31cdf4de59b7033cdd1de0aa07 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/a8e62091382ae4dfae1f06f26e21112de2a9649d [^]
2014-08-16 14:46hgbotCheckin
2014-08-16 14:46hgbotNote Added: 0069402
2014-08-16 14:46hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/a8e62091382ae4dfae1f06f26e21112de2a9649d [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/9f17e8d046c32d3891c2c2692418cb747243e60c [^]
2014-08-16 14:49OrekariaIssue Monitored: guillermogil
2014-08-16 14:49OrekariaIssue Monitored: marvintm
2014-08-16 14:50OrekariaIssue Monitored: priyam
2014-08-16 14:50OrekariaIssue Monitored: shuehner
2014-08-16 14:50OrekariaIssue Monitored: mtaal
2014-08-16 14:51OrekariaIssue Monitored: naiaramartinez
2014-08-16 14:52OrekariaStatusresolved => new
2014-08-16 14:52OrekariaResolutionfixed => open
2014-08-16 14:58OrekariaDescription Updatedbug_revision_view_page.php?rev_id=6300#r6300
2014-08-16 14:58OrekariaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=6302#r6302
2014-08-16 14:59OrekariaDescription Updatedbug_revision_view_page.php?rev_id=6303#r6303
2014-08-16 15:09OrekariaDescription Updatedbug_revision_view_page.php?rev_id=6304#r6304
2014-08-16 15:09OrekariaStatusnew => scheduled
2014-08-16 15:09Orekariafix_in_branch => pi
2014-08-16 15:09OrekariaStatusscheduled => resolved
2014-08-16 15:09OrekariaFixed in Version => RR14Q4
2014-08-16 15:09OrekariaResolutionopen => fixed
2014-08-16 15:15OrekariaStatusresolved => new
2014-08-16 15:15OrekariaResolutionfixed => open
2014-08-16 15:15OrekariaFixed in VersionRR14Q4 =>
2014-08-16 15:17Orekariafix_in_branchpi =>
2014-08-16 15:17OrekariaDescription Updatedbug_revision_view_page.php?rev_id=6305#r6305
2014-08-16 15:17OrekariaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=6306#r6306
2014-08-16 15:17OrekariaStatusnew => scheduled
2014-08-16 15:17Orekariafix_in_branch => pi
2014-08-16 15:17OrekariaStatusscheduled => resolved
2014-08-16 15:17OrekariaFixed in Version => RR14Q4
2014-08-16 15:17OrekariaResolutionopen => fixed
2014-08-16 17:20hgbotCheckin
2014-08-16 17:20hgbotNote Added: 0069403
2014-08-16 17:20hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/9f17e8d046c32d3891c2c2692418cb747243e60c [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/11866a5c49944032668e6c0ad0fbec96acfb4aa8 [^]
2014-08-16 17:51hgbotCheckin
2014-08-16 17:51hgbotNote Added: 0069404
2014-08-16 17:51hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/11866a5c49944032668e6c0ad0fbec96acfb4aa8 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.trainingmode/rev/835d57eeb3a89115471427d9b4b0fb158b5c2dca [^]
2014-08-16 17:52hgbotCheckin
2014-08-16 17:52hgbotNote Added: 0069405
2014-08-16 17:52hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.trainingmode/rev/835d57eeb3a89115471427d9b4b0fb158b5c2dca [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bestdeal/rev/4168380b8a152a1b8e948ff9f59892d4551dec0e [^]
2014-08-16 17:52hgbotCheckin
2014-08-16 17:52hgbotNote Added: 0069406
2014-08-16 17:52hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bestdeal/rev/4168380b8a152a1b8e948ff9f59892d4551dec0e [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.printlast/rev/ec6d584b3dbf1ccb8dc5b12857f07994bc8d6386 [^]
2014-08-16 17:52hgbotCheckin
2014-08-16 17:52hgbotNote Added: 0069408
2014-08-16 17:52hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.printlast/rev/ec6d584b3dbf1ccb8dc5b12857f07994bc8d6386 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.bestsellers/rev/61bdbcd990baaf148e4034c135b00acb41742308 [^]
2014-08-19 16:47OrekariaIssue Monitored: dmitry_mezentsev
2014-08-20 01:29OrekariaIssue Monitored: szapata
2014-08-20 01:29OrekariaIssue Monitored: adrianromero
2014-08-20 10:56hgbotCheckin
2014-08-20 10:56hgbotNote Added: 0069541
2014-08-20 10:56hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.bestsellers/rev/61bdbcd990baaf148e4034c135b00acb41742308 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/544d2d9f5a424e4a16b014844c87e5df0b849b66 [^]
2014-08-20 10:56hgbotCheckin
2014-08-20 10:56hgbotNote Added: 0069542
2014-08-21 09:58OrekariaRelationship addedblocks 0027399
2014-08-21 10:31OrekariaNote Added: 0069557
2014-08-21 10:31OrekariaStatusresolved => new
2014-08-21 10:31OrekariaResolutionfixed => open
2014-08-21 10:31OrekariaFixed in VersionRR14Q4 =>
2014-08-21 10:53dmitry_mezentsevNote Added: 0069558
2014-08-21 14:09OrekariaRelationship addeddepends on 0027400
2014-08-21 15:04hgbotCheckin
2014-08-21 15:04hgbotNote Added: 0069577
2014-08-21 15:04hgbotStatusnew => resolved
2014-08-21 15:04hgbotResolutionopen => fixed
2014-08-21 15:04hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/544d2d9f5a424e4a16b014844c87e5df0b849b66 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/46dd638f2ebe657fc2ab5fe51884a452c0c8cae8 [^]
2014-08-21 16:23OrekariaStatusresolved => new
2014-08-21 16:23OrekariaResolutionfixed => open
2014-08-21 16:23OrekariaStatusnew => scheduled
2014-08-21 21:33hgbotCheckin
2014-08-21 21:33hgbotNote Added: 0069583
2014-08-21 21:47Orekariafix_in_branchpi =>
2014-08-21 21:47OrekariaSummary[API Change] The HookManager does not have to depend on the OB.MobileApp.model object => [API Deprecation] The HookManager does not have to depend on the OB.MobileApp.model object
2014-08-22 11:05OrekariaRelationship addeddepends on 0027417
2014-08-22 21:03hgbotCheckin
2014-08-22 21:03hgbotNote Added: 0069620
2014-08-27 13:25OrekariaRelationship addedblocks 0027470
2014-09-02 21:51OrekariaStatusscheduled => resolved
2014-09-02 21:51OrekariaFixed in Version => RR14Q4
2014-09-02 21:51OrekariaResolutionopen => fixed
2014-09-22 10:14migueldejuanaReview Assigned To => migueldejuana
2014-09-22 10:14migueldejuanaNote Added: 0070223
2014-09-22 10:14migueldejuanaStatusresolved => closed
2014-09-25 13:55hgbotCheckin
2014-09-25 13:55hgbotNote Added: 0070376
2014-09-25 13:55hgbotStatusclosed => resolved
2014-09-25 13:55hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/46dd638f2ebe657fc2ab5fe51884a452c0c8cae8 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/1974b93c11433c00c517a863b6566c5197da46a1 [^]
2014-09-25 13:55hgbotCheckin
2014-09-25 13:55hgbotNote Added: 0070377
2014-09-25 13:55hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/1974b93c11433c00c517a863b6566c5197da46a1 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/65b36f99095fe0a89399d5be75292fc3ef22739f [^]
2014-09-25 13:55hgbotCheckin
2014-09-25 13:55hgbotNote Added: 0070378
2014-09-25 13:55hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/65b36f99095fe0a89399d5be75292fc3ef22739f [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.trainingmode/rev/47b0ee36186d1d8f1f7f9094ddcdb51a42434526 [^]
2014-09-25 13:55hgbotCheckin
2014-09-25 13:55hgbotNote Added: 0070379
2014-09-25 13:55hgbotCheckin
2014-09-25 13:55hgbotNote Added: 0070380
2014-09-25 13:55hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.trainingmode/rev/47b0ee36186d1d8f1f7f9094ddcdb51a42434526 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bestdeal/rev/d269a298039d010f4cda2fdd2fbde4fd96c0c9d9 [^]
2014-09-25 13:55hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.trainingmode/rev/47b0ee36186d1d8f1f7f9094ddcdb51a42434526 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.printlast/rev/d2cbe8e8c2d8a69da0a9620dd9e24e3dc81ebd6f [^]
2014-09-25 13:55hgbotCheckin
2014-09-25 13:55hgbotNote Added: 0070381
2014-09-25 13:55hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.printlast/rev/d2cbe8e8c2d8a69da0a9620dd9e24e3dc81ebd6f [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.bestsellers/rev/d36f0369692a2a0762f4a56494bbbac36d95a239 [^]
2014-09-25 18:31hgbotCheckin
2014-09-25 18:31hgbotNote Added: 0070394
2014-09-25 18:31hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.bestsellers/rev/d36f0369692a2a0762f4a56494bbbac36d95a239 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/606fdede8e81c7d0757d198d4df6fc1b392b7515 [^]
2014-09-29 17:48migueldejuanaNote Added: 0070507
2014-09-29 17:48migueldejuanaStatusresolved => closed
2015-01-28 12:54hgbotCheckin
2015-01-28 12:54hgbotNote Added: 0073854
2015-03-10 12:56OrekariaRelationship addedblocks 0028829

Notes
(0069398)
hgbot   
2014-08-16 14:45   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 5d93e0cec2bdfc6e977df214fdffcef45f54ca39
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sat Aug 16 14:35:14 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/5d93e0cec2bdfc6e977df214fdffcef45f54ca39 [^]

[API Change] Fixes issue 27349: The OB.UTIL.HookManager is no longer created in the OB.MobileApp.model...
(As it was, being dependant, forced the OB.MobileApp.model to be created before the HookManager, which is unwanted and blocks further code improvements)
- the instanciation is made when the javascript file is procesed
- now it has its own namespace to be called: OB.UTIL.HookManager
- the terminal model no longer instanciates the HookManager
- renamed all occurrences

---
M web/org.openbravo.mobile.core/source/component/ob-menu.js
M web/org.openbravo.mobile.core/source/component/ob-windowview.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
M web/org.openbravo.mobile.core/source/utils/ob-hooks.js
---
(0069399)
hgbot   
2014-08-16 14:45   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 4a0f9b4c99d38e6586bfa684db63e562cb6cb17a
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sat Aug 16 14:44:33 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4a0f9b4c99d38e6586bfa684db63e562cb6cb17a [^]

[API Change] Fixes issue 27349: Renaming OB.MobileApp.model to OB.UTIL.HookManager

---
M web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js
M web/org.openbravo.retail.posterminal/js/components/menuhook.js
M web/org.openbravo.retail.posterminal/js/components/modalpaidreceipts.js
M web/org.openbravo.retail.posterminal/js/components/orderdetails.js
M web/org.openbravo.retail.posterminal/js/components/popupdraweropened.js
M web/org.openbravo.retail.posterminal/js/components/renderorderline.js
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
M web/org.openbravo.retail.posterminal/js/main.js
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-print.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/components/sharedcomponents.js
---
(0069400)
hgbot   
2014-08-16 14:45   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: 690720566444ae31cdf4de59b7033cdd1de0aa07
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sat Aug 16 14:43:30 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/690720566444ae31cdf4de59b7033cdd1de0aa07 [^]

[API Change] Fixes issue 27349: Renaming OB.MobileApp.model to OB.UTIL.HookManager

---
M web/org.openbravo.retail.discounts/js/promotion-manual.js
---
(0069401)
hgbot   
2014-08-16 14:46   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: a8e62091382ae4dfae1f06f26e21112de2a9649d
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sat Aug 16 14:42:25 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/a8e62091382ae4dfae1f06f26e21112de2a9649d [^]

[API Change] Fixes issue 27349: Renaming OB.MobileApp.model to OB.UTIL.HookManager

---
M web/org.openbravo.retail.giftcards/js/components/GiftCardCancel.js
M web/org.openbravo.retail.giftcards/js/components/lineproperties.js
---
(0069402)
hgbot   
2014-08-16 14:46   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: 9f17e8d046c32d3891c2c2692418cb747243e60c
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sat Aug 16 14:43:06 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/9f17e8d046c32d3891c2c2692418cb747243e60c [^]

[API Change] Fixes issue 27349: Renaming OB.MobileApp.model to OB.UTIL.HookManager

---
M web/org.openbravo.retail.returns/js/hookGroupedProductPreCreateLine.js
M web/org.openbravo.retail.returns/js/hookRenderOrderLine.js
M web/org.openbravo.retail.returns/js/hookReturnChangeQty.js
M web/org.openbravo.retail.returns/js/hookReturnPaidOrder.js
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---
(0069403)
hgbot   
2014-08-16 17:20   
Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: 11866a5c49944032668e6c0ad0fbec96acfb4aa8
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sat Aug 16 17:20:45 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/11866a5c49944032668e6c0ad0fbec96acfb4aa8 [^]

[API Change] Fixes issue 27349: Renaming OB.MobileApp.model to OB.UTIL.HookManager

---
M web/org.openbravo.retail.sessions/js/components/editcashupreporthook.js
M web/org.openbravo.retail.sessions/js/components/loginhook.js
M web/org.openbravo.retail.sessions/js/components/orderdetailshook.js
M web/org.openbravo.retail.sessions/js/components/ordersavehook.js
M web/org.openbravo.retail.sessions/js/countcash/tabcountcash.js
---
(0069404)
hgbot   
2014-08-16 17:51   
Repository: erp/pmods/org.openbravo.retail.trainingmode
Changeset: 835d57eeb3a89115471427d9b4b0fb158b5c2dca
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sat Aug 16 17:51:02 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.trainingmode/rev/835d57eeb3a89115471427d9b4b0fb158b5c2dca [^]

[API Change] Fixes issue 27349: Renaming OB.MobileApp.model to OB.UTIL.HookManager

---
M web/org.openbravo.retail.trainingmode/js/ordersavehook.js
M web/org.openbravo.retail.trainingmode/js/preprinthook.js
---
(0069405)
hgbot   
2014-08-16 17:52   
Repository: erp/pmods/org.openbravo.retail.discounts.bestdeal
Changeset: 4168380b8a152a1b8e948ff9f59892d4551dec0e
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sat Aug 16 17:38:01 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bestdeal/rev/4168380b8a152a1b8e948ff9f59892d4551dec0e [^]

[API Change] Fixes issue 27349: Renaming OB.MobileApp.model to OB.UTIL.HookManager

---
M web/org.openbravo.retail.discounts.bestdeal/source/discounts-best-deal-case.js
---
(0069406)
hgbot   
2014-08-16 17:52   
Repository: erp/pmods/org.openbravo.retail.printlast
Changeset: ec6d584b3dbf1ccb8dc5b12857f07994bc8d6386
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sat Aug 16 17:50:14 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.printlast/rev/ec6d584b3dbf1ccb8dc5b12857f07994bc8d6386 [^]

[API Change] Fixes issue 27349: Renaming OB.MobileApp.model to OB.UTIL.HookManager

---
M web/org.openbravo.retail.printlast/js/hookAlwaysPrint.js
---
(0069408)
hgbot   
2014-08-16 17:52   
Repository: erp/pmods/org.openbravo.retail.bestsellers
Changeset: 61bdbcd990baaf148e4034c135b00acb41742308
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sat Aug 16 17:36:34 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.bestsellers/rev/61bdbcd990baaf148e4034c135b00acb41742308 [^]

[API Change] Fixes issue 27349: Renaming OB.MobileApp.model to OB.UTIL.HookManager

---
M web/org.openbravo.retail.bestsellers/js/components/ModelHooks.js
---
(0069541)
hgbot   
2014-08-20 10:56   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 544d2d9f5a424e4a16b014844c87e5df0b849b66
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Wed Aug 20 10:54:13 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/544d2d9f5a424e4a16b014844c87e5df0b849b66 [^]

Fixes issue 27349: removed dead variable in ob-terminal-model

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0069542)
hgbot   
2014-08-20 10:56   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: bf692438ef98eabb0846bb7552b0b5f3f8fadf01
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Wed Aug 20 10:56:19 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/bf692438ef98eabb0846bb7552b0b5f3f8fadf01 [^]

Related to issue 27349: added retrocompatibility (the HookManager being child of OB.MobileApp.model)

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0069557)
Orekaria   
2014-08-21 10:31   
Reopened because more improvements can be included (warning to suggest the developer to rename references, removal of unnecessary checks and any other gathered from feedback)
(0069558)
dmitry_mezentsev   
2014-08-21 10:53   
API change is approved considering backward compatibility implementation discussed.
(0069577)
hgbot   
2014-08-21 15:04   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 46dd638f2ebe657fc2ab5fe51884a452c0c8cae8
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Thu Aug 21 15:04:40 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/46dd638f2ebe657fc2ab5fe51884a452c0c8cae8 [^]

Fixes issue 27349: The backward compatilibily is now handled by the new OB.UTILS.VersionManagement class
- the code its tagged as deprecated and all the code is inside a call
- in the future, this compact approach will allow this code to be removed when the backend generates the javascript file
- the deprecation message is shown only while in development

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0069583)
hgbot   
2014-08-21 21:33   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: a671af5c37c3c8d4441b1b0a328822c78ce8cccd
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Thu Aug 21 21:33:18 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/a671af5c37c3c8d4441b1b0a328822c78ce8cccd [^]

Related to issue 27349: Changes comming from Release Management feedback

Release Management request: be able to retrieve all the deprecations even if they have not been executed
The OB.UTIL.VersionManagement has been changed and now is able to retrieve all the deprecations present in the javascript generated file with the 'OB.UTIL.VersionManagement.getDeprecations' method even if they have not been executed

The HookManager has been changed to adapt to the new changes in the OB.UTIL.VersionManagement, those are:
- the deprecations will first be registered with the 'registerDeprecation' method in the javascript load process
- the deprecations will introduce the backward compatibility with the 'deprecated' method

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0069620)
hgbot   
2014-08-22 21:03   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: d0501ee26f72181d2c78db0c8f3da497b90802c1
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Fri Aug 22 21:01:31 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d0501ee26f72181d2c78db0c8f3da497b90802c1 [^]

Related to issue 27400 and issue 27349: The registering of the deprecations has been moved...
... to the ob-versionmanagement.js file
Registering deprecations in that file, will allow easy maintenable global deprecations and cleaner code

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
M web/org.openbravo.mobile.core/source/utils/ob-versionmanagement.js
---
(0070223)
migueldejuana   
2014-09-22 10:14   
Tested and reviewed in 79500303f4b7
(0070376)
hgbot   
2014-09-25 13:55   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 1974b93c11433c00c517a863b6566c5197da46a1
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Thu Sep 25 13:24:55 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/1974b93c11433c00c517a863b6566c5197da46a1 [^]

Fixes issue 27349. Backed out related changesets. The change will be done when this module will change to require Q4 or up

---
M web/org.openbravo.retail.giftcards/js/components/GiftCardCancel.js
M web/org.openbravo.retail.giftcards/js/components/lineproperties.js
---
(0070377)
hgbot   
2014-09-25 13:55   
Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: 65b36f99095fe0a89399d5be75292fc3ef22739f
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Thu Sep 25 13:38:48 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/65b36f99095fe0a89399d5be75292fc3ef22739f [^]

Fixes issue 27349. Backed out related changeset. The change will be done when this module will change to require Q4 or up

---
M web/org.openbravo.retail.sessions/js/components/editcashupreporthook.js
M web/org.openbravo.retail.sessions/js/components/loginhook.js
M web/org.openbravo.retail.sessions/js/components/orderdetailshook.js
M web/org.openbravo.retail.sessions/js/components/ordersavehook.js
M web/org.openbravo.retail.sessions/js/countcash/tabcountcash.js
---
(0070378)
hgbot   
2014-09-25 13:55   
Repository: erp/pmods/org.openbravo.retail.trainingmode
Changeset: 47b0ee36186d1d8f1f7f9094ddcdb51a42434526
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Thu Sep 25 13:40:50 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.trainingmode/rev/47b0ee36186d1d8f1f7f9094ddcdb51a42434526 [^]

Fixes issue 27349. Backed out related changeset. The change will be done when this module will change to require Q4 or up

---
M web/org.openbravo.retail.trainingmode/js/ordersavehook.js
M web/org.openbravo.retail.trainingmode/js/preprinthook.js
---
(0070379)
hgbot   
2014-09-25 13:55   
Repository: erp/pmods/org.openbravo.retail.discounts.bestdeal
Changeset: d269a298039d010f4cda2fdd2fbde4fd96c0c9d9
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Thu Sep 25 13:39:45 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bestdeal/rev/d269a298039d010f4cda2fdd2fbde4fd96c0c9d9 [^]

Fixes issue 27349. Backed out related changeset. The change will be done when this module will change to require Q4 or up

---
M web/org.openbravo.retail.discounts.bestdeal/source/discounts-best-deal-case.js
---
(0070380)
hgbot   
2014-09-25 13:55   
Repository: erp/pmods/org.openbravo.retail.printlast
Changeset: d2cbe8e8c2d8a69da0a9620dd9e24e3dc81ebd6f
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Thu Sep 25 13:41:36 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.printlast/rev/d2cbe8e8c2d8a69da0a9620dd9e24e3dc81ebd6f [^]

Fixes issue 27349. Backed out related changeset. The change will be done when this module will change to require Q4 or up

---
M web/org.openbravo.retail.printlast/js/hookAlwaysPrint.js
---
(0070381)
hgbot   
2014-09-25 13:55   
Repository: erp/pmods/org.openbravo.retail.bestsellers
Changeset: d36f0369692a2a0762f4a56494bbbac36d95a239
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Thu Sep 25 13:42:18 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.bestsellers/rev/d36f0369692a2a0762f4a56494bbbac36d95a239 [^]

Fixes issue 27349. Backed out related changeset. The change will be done when this module will change to require Q4 or up

---
M web/org.openbravo.retail.bestsellers/js/components/ModelHooks.js
---
(0070394)
hgbot   
2014-09-25 18:31   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 606fdede8e81c7d0757d198d4df6fc1b392b7515
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Thu Sep 25 18:30:50 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/606fdede8e81c7d0757d198d4df6fc1b392b7515 [^]

Fixes issue 27349: Added missing method 'callbackExecutor' to the deprecation redirect for the OB.UTIL.HookManager

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0070507)
migueldejuana   
2014-09-29 17:48   
Tested and reviewed in 130ef2db3366
(0073854)
hgbot   
2015-01-28 12:54   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 73f0f5706dd377bf358a481be5602ff13e6b8815
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Wed Jan 28 12:51:46 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/73f0f5706dd377bf358a481be5602ff13e6b8815 [^]

Related to issue 27349 and issue 27190: Changed hookManager calls to prevent deprecation messages

---
M web/org.openbravo.retail.posterminal/js/components/order.js
---