Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027342Retail ModulesWeb POSpublic2014-08-15 01:462014-08-23 10:48
ReporterOrekaria 
Assigned ToOrekaria 
PrioritynormalSeveritytrivialReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR14Q4Fixed in VersionRR14Q4 
Merge Request Status
Review Assigned Tomtaal
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027342: Stabilization: Unuseful code in ob-terminal-model.js - setUserModelOnline
DescriptionStabilization: Unuseful code in ob-terminal-model.js - setUserModelOnline
Steps To ReproduceVerify that ob-terminal-model.js - setUserModelOnline has the following code

        user = users.models[0];
        me.usermodel = user;
        if (me.password) {
          //The password will only be recomputed in case it was properly entered
          //(that is, if the call comes from the login page directly)
          savedPass = me.generate_sha1(me.password + user.get('created'));
          user.set('password', savedPass);
          me.usermodel = user;
        } else {
          user = users.models[0];
          me.usermodel = user;
          if (me.password) {
            //The password will only be recomputed in case it was properly entered
            //(that is, if the call comes from the login page directly)
            savedPass = me.generate_sha1(me.password + user.get('created'));
            user.set('password', savedPass);
          }
        }
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0027465RR14Q4 closed Orekaria Stabilization: When 'setUserModelOnline' fails to save the current user info, the loading process fails 
blocks feature request 0027329 new Retail Stabilization: Overhaul the loading process (since the url is entered until the webpos has loaded) 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-08-15 01:46OrekariaNew Issue
2014-08-15 01:46OrekariaAssigned To => Orekaria
2014-08-15 01:46OrekariaTriggers an Emergency Pack => No
2014-08-15 01:46OrekariaRelationship addedblocks 0027329
2014-08-15 01:47OrekariaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=6286#r6286
2014-08-15 01:53hgbotCheckin
2014-08-15 01:53hgbotNote Added: 0069381
2014-08-15 01:53hgbotStatusnew => resolved
2014-08-15 01:53hgbotResolutionopen => fixed
2014-08-15 01:53hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/713772221ffef7c2b57c991043e7af041a1f600a [^]
2014-08-23 10:48mtaalReview Assigned To => mtaal
2014-08-23 10:48mtaalNote Added: 0069637
2014-08-23 10:48mtaalStatusresolved => closed
2014-08-23 10:48mtaalFixed in Version => RR14Q4
2014-08-26 02:11OrekariaRelationship addedrelated to 0027465

Notes
(0069381)
hgbot   
2014-08-15 01:53   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 713772221ffef7c2b57c991043e7af041a1f600a
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Fri Aug 15 01:53:35 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/713772221ffef7c2b57c991043e7af041a1f600a [^]

Fixes issue 27342: removed unuseful code

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0069637)
mtaal   
2014-08-23 10:48   
Reviewed