Openbravo Issue Tracking System - Retail Modules
View Issue Details
0027341Retail ModulesWeb POSpublic2014-08-14 23:002014-10-03 13:02
Orekaria 
Orekaria 
normalmajoralways
closedfixed 
5
 
RR14Q4RR14Q4 
szapata
No
0027341: Stabilization: org.openbravo.retail.discounts should depend on org.openbravo.mobile.core
org.openbravo.retail.discounts should depend on org.openbravo.mobile.core
load the WebPOS
open the generated javascript file.
verify that the discounts javascript is loaded before the core javascript
find the proper scope for the discounts module
set its dependencies according to that
No tags attached.
blocks feature request 0027329 new Retail Stabilization: Overhaul the loading process (since the url is entered until the webpos has loaded) 
blocks defect 0027403 acknowledged Retail Stabilization: Discounts should not execute actions until the javascript generated file has been processed 
Issue History
2014-08-14 23:01OrekariaNew Issue
2014-08-14 23:01OrekariaAssigned To => Orekaria
2014-08-14 23:01OrekariaTriggers an Emergency Pack => No
2014-08-14 23:03OrekariaRelationship addedblocks 0027329
2014-08-14 23:34hgbotCheckin
2014-08-14 23:34hgbotNote Added: 0069380
2014-08-14 23:34hgbotStatusnew => resolved
2014-08-14 23:34hgbotResolutionopen => fixed
2014-08-14 23:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/7a87fa6369873985fc7b8bb50ad283d0753731c4 [^]
2014-08-21 11:40OrekariaNote Added: 0069565
2014-08-21 11:40OrekariaStatusresolved => new
2014-08-21 11:40OrekariaResolutionfixed => open
2014-08-21 11:44OrekariaRelationship addedblocks 0027403
2014-08-21 11:53OrekariaProposed Solution updated
2014-08-21 11:54OrekariaProposed Solution updated
2014-09-16 00:16OrekariaStatusnew => scheduled
2014-09-16 00:16Orekariafix_in_branch => pi
2014-09-16 00:16OrekariaReview Assigned To => marvintm
2014-09-16 00:16Orekariafix_in_branchpi =>
2014-09-16 00:16OrekariaStatusscheduled => resolved
2014-09-16 00:16OrekariaFixed in Version => RR14Q4
2014-09-16 00:16OrekariaResolutionopen => fixed
2014-09-16 17:36szapataReview Assigned Tomarvintm => szapata
2014-09-16 17:36szapataStatusresolved => closed
2014-10-03 13:02hgbotCheckin
2014-10-03 13:02hgbotNote Added: 0070689

Notes
(0069380)
hgbot   
2014-08-14 23:34   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: 7a87fa6369873985fc7b8bb50ad283d0753731c4
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Thu Aug 14 23:34:15 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/7a87fa6369873985fc7b8bb50ad283d0753731c4 [^]

Fixes issue 27341: added the dependency 'org.openbravo.mobile.core' to 'org.openbravo.retail.discounts'

---
M src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
---
(0069565)
Orekaria   
2014-08-21 11:40   
Verify if the discounts module can, indeed, work only with mobile.core

Verify in the DiscountsComponentProvider.java that a reference to WebPOS is done:

    for (final String resource : resourceDependency) {
      globalResources.add(createComponentResource(ComponentResourceType.Static, prefix + resource
          + ".js", "WebPOS"));
    }
(0070689)
hgbot   
2014-10-03 13:02   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: a4d4091b3673dba49dd1258ce0ad103cba463f5b
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Fri Oct 03 13:01:42 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/a4d4091b3673dba49dd1258ce0ad103cba463f5b [^]

Backed out issue 27341 changeset: 7a87fa636987. Fixes issue 27751

Adding dependency on mobile.core forces direct ERP users of this module to also install mobile.core

---
M src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
---