0027338: Review deleting logic of tax lines in C_ORDERLINE_TRG2

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0027338

Openbravo ERP

07. Sales management

public

2014-08-14 15:55

2014-08-14 15:56

Reporter

rafaroda

Assigned To

dmiguelez

Priority

normal

Severity

minor

Reproducibility

always

Status

new

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0027338: Review deleting logic of tax lines in C_ORDERLINE_TRG2

Description

When posting a Sales Order, logic for recreating the tax lines should be reviewed in order to modify existing ones instead of deleting and recreating them.

This is the second part of the issue 0027023.

Steps To Reproduce

Taken from issue 0027023

Using PG:
-Enable function statistics:
  -In postgresql.conf set track_functions = all
  -/etc/init.d/postgresql reload
-Create a sales order with one line
-Reset pg statistics: select pg_stat_reset();
-Book it
  * Check function calls: select funcname, calls, total_time, self_time from pg_stat_user_functions order by self_time desc

Proposed Solution

Review delete logic of C_ORDERLINE_TRG2 trigger https://code.openbravo.com/erp/devel/pi/file/085ea1fce739/src-db/database/model/triggers/C_ORDERLINE_TRG2.xml#l93 [^]

See issue 0027023 for more information.

Additional Information

Tags

No tags attached.

Relationships

related to	defect	0027023		closed	vmromanos	Order line taxes are regenerated on all order line changes
related to	defect	0029073	3.0PR15Q2	closed	umartirena	Review deleting logic of tax lines in C_INVOICELINE_TRG2