Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027309Retail ModulesWeb POSpublic2014-08-11 19:082014-09-11 01:38
Reporterjecharri 
Assigned ToOrekaria 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR14Q4 
Merge Request Status
Review Assigned Toszapata
OBNetwork customerOBPS
Support ticket30335
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027309: New documentno after navigating to cash up or cash management window
DescriptionNew documentno after navigating to cash up or cash management window
Steps To Reproduce-login to web pos and verify documentno
-go to cash management window and press "cancel"

Verify that you have the same documentno + 1

It happens exactly the same if you go to cash up and press cancel
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0027476 closed Orekaria Duplicate documentno in orders using Web POS 
depends on feature request 0027548RR14Q4 closed Orekaria Should be helpful if the OrderList object could point to OB.MobileApp.model.orderList 
blocks backport 0027813RR14Q2.3 closed Orekaria Backport the document number fixes introduced in Q4 to Q2.4/Q3 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-08-11 19:08jecharriNew Issue
2014-08-11 19:08jecharriAssigned To => marvintm
2014-08-11 19:08jecharriOBNetwork customer => Yes
2014-08-11 19:08jecharriSupport ticket => 30335
2014-08-11 19:08jecharriResolution time => 1409781600
2014-08-11 19:08jecharriTriggers an Emergency Pack => No
2014-09-07 17:35OrekariaRelationship addeddepends on 0027548
2014-09-07 17:36OrekariaRelationship addedrelated to 0027476
2014-09-07 18:02hgbotCheckin
2014-09-07 18:02hgbotNote Added: 0069995
2014-09-07 18:02hgbotStatusnew => resolved
2014-09-07 18:02hgbotResolutionopen => fixed
2014-09-07 18:02hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/41489fdd4240106ae231ac30fc24f5c4816797c0 [^]
2014-09-07 18:21hgbotCheckin
2014-09-07 18:21hgbotNote Added: 0069996
2014-09-07 18:23OrekariaAssigned Tomarvintm => Orekaria
2014-09-07 18:23OrekariaStatusresolved => new
2014-09-07 18:23OrekariaResolutionfixed => open
2014-09-07 18:23OrekariaStatusnew => scheduled
2014-09-07 18:23Orekariafix_in_branch => pi
2014-09-07 18:23OrekariaStatusscheduled => resolved
2014-09-07 18:23OrekariaFixed in Version => RR14Q4
2014-09-07 18:23OrekariaResolutionopen => fixed
2014-09-08 12:40hgbotCheckin
2014-09-08 12:40hgbotNote Added: 0070012
2014-09-11 01:38szapataReview Assigned To => szapata
2014-09-11 01:38szapataStatusresolved => closed
2014-10-09 13:34OrekariaRelationship addedblocks 0027813

Notes
(0069995)
hgbot   
2014-09-07 18:02   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 41489fdd4240106ae231ac30fc24f5c4816797c0
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sat Sep 06 19:18:34 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/41489fdd4240106ae231ac30fc24f5c4816797c0 [^]

Fixes issue 27309 and issue 27476: A new document sequence algorithm has been introduced to preserve consecutive document numbers
This logic:
- can handle the regular activity with the WebPOS: navigating, adding, deleting, changing orders, etc.
- it does not fill gaps that the user do not want to. e.g: if order 001 is paid, then 3 empty orders are created and then the 004 is paid; 005 will be the next valid document number
- synchronizes the document number with the server each time the terminal info is updated, which is, as of now, after login, every page refresh and every x minutes
- cannot handle 2 or more terminals with the same id, running at the same time

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0069996)
hgbot   
2014-09-07 18:21   
Repository: tools/automation/pi-mobile
Changeset: 8fd3b52cc884a6accd7b64432cd621a2bf0a2784
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sun Sep 07 18:20:55 2014 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/8fd3b52cc884a6accd7b64432cd621a2bf0a2784 [^]

Related to issue 27309 and to issue 27476: Several tests have been added to verify that the document sequence algorithm is working as expected

---
M src-test/org/openbravo/retail/integrationtest/tests/RetailTestSuite.java
M src-test/org/openbravo/retail/integrationtest/tests/issues/RetailIssuesTestSuite.java
A src-test/org/openbravo/retail/integrationtest/tests/general/receipt/DocumentnoAndLocalDatabaseDocnoEquals.java
A src-test/org/openbravo/retail/integrationtest/tests/general/receipt/DocumentnoComputingLogicIntegrity.java
A src-test/org/openbravo/retail/integrationtest/tests/general/receipt/DocumentnoComputingLogicIntegrityWithSynchronization.java
A src-test/org/openbravo/retail/integrationtest/tests/general/receipt/DocumentnoSynchronizationContentInReceipt.java
A src-test/org/openbravo/retail/integrationtest/tests/general/receipt/DocumentnoSynchronizationEmptyReceipt.java
A src-test/org/openbravo/retail/integrationtest/tests/general/receipt/DocumentnoWhenCreatingQuotations.java
A src-test/org/openbravo/retail/integrationtest/tests/general/receipt/DocumentnoWithPendingReceiptsNewDeleteAndNew.java
A src-test/org/openbravo/retail/integrationtest/tests/general/receipt/NewDocumentnoAfterButtonNew.java
A src-test/org/openbravo/retail/integrationtest/tests/general/receipt/NewDocumentnoAfterSale.java
A src-test/org/openbravo/retail/integrationtest/tests/general/receipt/NewDocumentnoWhenLayaway.java
A src-test/org/openbravo/retail/integrationtest/tests/general/receipt/RetailGeneralReceiptTestSuite.java
A src-test/org/openbravo/retail/integrationtest/tests/general/receipt/SameDocumentnoAfterDeletingReceipt.java
A src-test/org/openbravo/retail/integrationtest/tests/general/receipt/SameDocumentnoAfterRefresh.java
A src-test/org/openbravo/retail/integrationtest/tests/general/receipt/SameDocumentnoAfterRefreshWithCreatedOrder.java
A src-test/org/openbravo/retail/integrationtest/tests/issues/I27309_SameDocumentnoAfterNavigatingCashManagementCashUp.java
A src-test/org/openbravo/retail/integrationtest/tests/issues/I27476_SameDocumentNoAfterPayAndReload.java
---
(0070012)
hgbot   
2014-09-08 12:40   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c2a160c9542a66de3c4e7a014c3db1b2b450009d
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Mon Sep 08 12:37:30 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c2a160c9542a66de3c4e7a014c3db1b2b450009d [^]

Related to issue 27309 and issue 27476: back out rogue code

---
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
---