Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027266Openbravo ERP02. Master data managementpublic2014-08-01 21:442014-12-30 23:28
Reporterjecharri 
Assigned TodaniOpenbravo 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q1Fixed in Version 
Merge Request Status
Review Assigned Topramakrishnan
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket30191
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027266: When you create a bank account for a Business partner United States country is selected
DescriptionWhen you create a bank account for a Business partner United States country is selected
Steps To Reproduce-Go to window "Business partner"
-Select one and create a record in tab "Bank Account"

Verify that United States is selected but it does not exist any logic to this happen.

The only reason is that if you execute
select name from c_country ;
You will see that first result is United States, however if you delete this one you expect the following one to be selected but it is not the case.

Proposed SolutionIt should not select any one or however it should select the user organization country
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-08-01 21:44jecharriNew Issue
2014-08-01 21:44jecharriAssigned To => dmiguelez
2014-08-01 21:44jecharriOBNetwork customer => Yes
2014-08-01 21:44jecharriModules => Core
2014-08-01 21:44jecharriSupport ticket => 30191
2014-08-01 21:44jecharriResolution time => 1413064800
2014-08-01 21:44jecharriTriggers an Emergency Pack => No
2014-09-22 13:36vmromanosNote Added: 0070237
2014-09-22 13:36vmromanosAssigned Todmiguelez => AugustoMauch
2014-09-22 16:36jonalegriaesarteTarget Version3.0PR14Q4 => 3.0PR15Q1
2014-09-23 08:23alostaleNote Added: 0070259
2014-09-23 08:24alostaleAssigned ToAugustoMauch => vmromanos
2014-09-23 08:24alostaleNote Added: 0070260
2014-10-17 13:35vmromanosNote Added: 0071030
2014-10-20 15:16daniOpenbravoAssigned Tovmromanos => daniOpenbravo
2014-10-20 15:16daniOpenbravoStatusnew => scheduled
2014-10-21 17:55daniOpenbravoNote Added: 0071099
2014-12-30 07:46AtulOpenbravoReview Assigned To => pramakrishnan
2014-12-30 07:50hgbotCheckin
2014-12-30 07:50hgbotNote Added: 0072863
2014-12-30 07:50hgbotStatusscheduled => resolved
2014-12-30 07:50hgbotResolutionopen => fixed
2014-12-30 07:50hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/9ebdb868d92fd5bca4bcb18bdf41025e7a318e98 [^]
2014-12-30 07:50hgbotCheckin
2014-12-30 07:50hgbotNote Added: 0072864
2014-12-30 07:50hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/9ebdb868d92fd5bca4bcb18bdf41025e7a318e98 [^] => http://code.openbravo.com/erp/devel/pi/rev/0a1b54e001f0d37fc0804e0be9b5ae02101943ab [^]
2014-12-30 08:32pramakrishnanNote Added: 0072865
2014-12-30 08:32pramakrishnanStatusresolved => closed
2014-12-30 23:28hudsonbotCheckin
2014-12-30 23:28hudsonbotNote Added: 0073274
2014-12-30 23:28hudsonbotCheckin
2014-12-30 23:28hudsonbotNote Added: 0073275

Notes
(0070237)
vmromanos   
2014-09-22 13:36   
Assigned to Plataform.

After a quick review, there isn't neither a default value assigned to this column nor a callout in this table that might change the value, so the issue seems to be related to the Platform side.

Please review it: in case it is sth generic, assign it back to us.

Regards,
Víctor.
(0070259)
alostale   
2014-09-23 08:23   
From the Platform point of view, it is working as expected:

"United States" is marked as Default in Country window. This makes all C_Country_ID columns without any default value to be set to that default.


From functional point of view, current behavior can be changed in different ways:
-If any other country is desired to be the default one, unflag USA and select that one as default.
-If no default country is desired, don't select any default country.
-If current behavior is desired for all windows but for this one, change default in C_BP_BankAccount.C_Country_ID table. You can force it to be null by default by setting '' as value.
(0070260)
alostale   
2014-09-23 08:24   
Reassigned to Functional team, to decide whether a change is required and if so, which one of the proposed ones makes more sense.
(0071030)
vmromanos   
2014-10-17 13:35   
In this concrete case I think it makes sense to set by default the business partner's country defined at the Location/Address tab.

If there are no locations defined yet, take the default country as it's doing right now.

If there are several locations, take any of the countries. If any of these countries is the default one, select it.
(0071099)
daniOpenbravo   
2014-10-21 17:55   
Test Plan:
1) Create a new Business Partner.
2) If we do not assign any Location/Address to it and try to create a new record in Bank Account tab, Country field will show United States (as this one is set as isDefault).
3) Create a new register in Location tab (assign country=Spain for example).
4) If we go to Bank Account tab and create a new record, Spain country will be shown as default.
5) Add a new Location in Location tab, taking United States country.
6) Go to Bank account and create a new record: as there are two locations, the system will take the one that is set as default: United States.
(0072863)
hgbot   
2014-12-30 07:50   
Repository: erp/devel/pi
Changeset: 9ebdb868d92fd5bca4bcb18bdf41025e7a318e98
Author: Daniel Ruiz <daniel.ruiz <at> openbravo.com>
Date: Tue Oct 21 17:47:46 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/9ebdb868d92fd5bca4bcb18bdf41025e7a318e98 [^]

Fixes Issue 27266:United States is always selected in Country field
(Business Partner window, Bank account tab).

Default value shown on country field in Bank account tab (Business Partner
window) is always United States and it should not be in that way.
Now, default value will be the country defined in Location/address tab.
If there are no Locations defined, it will take the country which has isDefault
column set as 'Y'. Finally, if there are several Locations defined for that
Business Partner, the system will take any of them and if there is one record
whose country is set as Default, this one will be shown.

---
M src-db/database/sourcedata/AD_AUXILIARINPUT.xml
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0072864)
hgbot   
2014-12-30 07:50   
Repository: erp/devel/pi
Changeset: 0a1b54e001f0d37fc0804e0be9b5ae02101943ab
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue Dec 23 10:31:52 2014 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/0a1b54e001f0d37fc0804e0be9b5ae02101943ab [^]

Fixes Issue 27266: Added isactive='Y' clause while BP Location selection

---
M src-db/database/sourcedata/AD_AUXILIARINPUT.xml
---
(0072865)
pramakrishnan   
2014-12-30 08:32   
Verified
(0073274)
hudsonbot   
2014-12-30 23:28   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test
(0073275)
hudsonbot   
2014-12-30 23:28   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test