Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027262Openbravo ERP07. Sales managementpublic2014-08-01 18:302015-06-03 18:55
Reporterjonalegriaesarte 
Assigned ToAtulOpenbravo 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q3Fixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027262: After using copy from order the old order can not be removed
DescriptionAfter using copy from order the old order can not be removed
Steps To Reproduce- Create a sales order with one line
- Create a new header. Using copy from order, select the previous order
- Try to delete the first order, the system can not, due to linked items in the lines of the original order
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff c27262.diff (8,724) 2014-08-13 12:12
https://issues.openbravo.com/file_download.php?file_id=7132&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-08-01 18:30jonalegriaesarteNew Issue
2014-08-01 18:30jonalegriaesarteAssigned To => AtulOpenbravo
2014-08-01 18:30jonalegriaesarteModules => Core
2014-08-01 18:30jonalegriaesarteResolution time => 1396821600
2014-08-01 18:30jonalegriaesarteTriggers an Emergency Pack => No
2014-08-05 12:31caristuAssigned ToAtulOpenbravo => caristu
2014-08-05 12:32caristuFile Added: 27262.diff
2014-08-13 12:11caristuFile Deleted: 27262.diff
2014-08-13 12:12caristuFile Added: c27262.diff
2014-09-29 16:12jonalegriaesarteTarget Version3.0PR14Q4 => 3.0PR15Q1
2014-12-22 12:50jonalegriaesarteTarget Version3.0PR15Q1 => 3.0PR15Q2
2015-03-13 10:34jonalegriaesarteTarget Version3.0PR15Q2 => 3.0PR15Q3
2015-04-17 11:37caristuNote Added: 0076602
2015-04-17 11:38caristuAssigned Tocaristu => Sandrahuguet
2015-04-17 11:39caristuNote Edited: 0076602bug_revision_view_page.php?bugnote_id=0076602#r8288
2015-04-17 11:49SandrahuguetAssigned ToSandrahuguet => Triage Finance
2015-04-17 12:09jonalegriaesarteResolution time1396821600 => 1428357600
2015-04-17 12:43aferrazPriorityimmediate => urgent
2015-04-27 08:22AtulOpenbravoAssigned ToTriage Finance => AtulOpenbravo
2015-04-27 08:22AtulOpenbravoStatusnew => scheduled
2015-04-27 11:19AtulOpenbravoNote Added: 0076774
2015-06-02 14:49hgbotCheckin
2015-06-02 14:49hgbotNote Added: 0077984
2015-06-02 14:49hgbotStatusscheduled => resolved
2015-06-02 14:49hgbotResolutionopen => fixed
2015-06-02 14:49hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/89ecff04c23e2514055a782d6fe9bc45e85fc063 [^]
2015-06-02 14:50hgbotCheckin
2015-06-02 14:50hgbotNote Added: 0077985
2015-06-02 14:51vmromanosReview Assigned To => vmromanos
2015-06-02 14:51vmromanosNote Added: 0077986
2015-06-02 14:51vmromanosStatusresolved => closed
2015-06-03 18:55hudsonbotCheckin
2015-06-03 18:55hudsonbotNote Added: 0078037
2015-06-03 18:55hudsonbotCheckin
2015-06-03 18:55hudsonbotNote Added: 0078038

Notes
(0076602)
caristu   
2015-04-17 11:37   
(edited on: 2015-04-17 11:39)
Attached a possible patch that must be reviewed. The change in the C_ORDERLINE2_TRG is done to avoid a mutating trigger error in Oracle.
(0076774)
AtulOpenbravo   
2015-04-27 11:19   
Test Plan
- Create a sales order with one line.
- Create a new header. Using copy from order, select the previous order
- Try to delete the first order.
- Order is deleted successfully.

Note:- Test in oracle instance also.
(0077984)
hgbot   
2015-06-02 14:49   
Repository: erp/devel/pi
Changeset: 89ecff04c23e2514055a782d6fe9bc45e85fc063
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Wed May 27 11:59:32 2015 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/89ecff04c23e2514055a782d6fe9bc45e85fc063 [^]

Fixes Issue 27262:After using copy from order the old order can not be removed

A event handler is implemented to achieve the functionality.

---
A src/org/openbravo/event/OrderLineEventHandler.java
---
(0077985)
hgbot   
2015-06-02 14:50   
Repository: erp/devel/pi
Changeset: d73cfed50b6e31c7a02bce6b1e2b78a4910706c3
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Jun 02 14:39:07 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d73cfed50b6e31c7a02bce6b1e2b78a4910706c3 [^]

Related to issue 27262: Run direct update query to improve performance

Instead of getting all the sales order lines to update the reference line, we have replaced by a direct Update HQL, which improves performance and reduces the memory usage

---
M src/org/openbravo/event/OrderLineEventHandler.java
---
(0077986)
vmromanos   
2015-06-02 14:51   
Code review + testing OK

Tested in Oracle and PG
(0078037)
hudsonbot   
2015-06-03 18:55   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/084e25f8f2cd [^]
Maturity status: Test
(0078038)
hudsonbot   
2015-06-03 18:55   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/084e25f8f2cd [^]
Maturity status: Test