Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027250Openbravo ERPZ. Otherspublic2014-07-31 17:102023-02-22 05:54
Reportermaite 
Assigned Toreinaldoguerra 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q1Fixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket30154
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027250: "finalsettlement" field should be set to null when payment related to invoice is removed
Description"finalsettlement" field should be set to null when payment related to invoice is removed
Steps To Reproduce1. Register new sales invoice, add line and process it.
2. Verify that "finalsettlement" field is null at this moments (select FINALSETTLEMENT from c_invoice order by created desc limit 1;)
3. Pay that invoice
4. Execute same database query to verify that "finalsettlement" field has been correctly updated with today's date
5. Access created Payment and run "Reactivate and delete lines" so invice is pending of payment again
6. Execute query and verify that "finalsettlement" field had not been set to null again when it should
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00272933.0PR15Q1 closed reinaldoguerra Total Outstanding amount is not updated when reactivating an invoice 
has duplicate defect 00276173.0PR15Q1 closed fsoto82 Sales Invoice - Wrong "Paid in Full Date" when reactivating a Payment IN 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-07-31 17:10maiteNew Issue
2014-07-31 17:10maiteAssigned To => dmiguelez
2014-07-31 17:10maiteOBNetwork customer => Yes
2014-07-31 17:10maiteModules => Core
2014-07-31 17:10maiteSupport ticket => 30154
2014-07-31 17:10maiteResolution time => 1413410400
2014-07-31 17:10maiteTriggers an Emergency Pack => No
2014-07-31 17:10maiteIssue Monitored: networkb
2014-09-22 13:41vmromanosRelationship addedrelated to 0027293
2014-09-22 16:36jonalegriaesarteTarget Version3.0PR14Q4 => 3.0PR15Q1
2014-09-27 05:21reinaldoguerraAssigned Todmiguelez => reinaldoguerra
2014-09-27 05:21reinaldoguerraStatusnew => scheduled
2014-09-30 05:52reinaldoguerraNote Added: 0070527
2014-10-03 14:20hgbotCheckin
2014-10-03 14:20hgbotNote Added: 0070697
2014-10-03 14:20hgbotStatusscheduled => resolved
2014-10-03 14:20hgbotResolutionopen => fixed
2014-10-03 14:20hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/fb3182ac0e6d24b17517efe18348f80c4e16add5 [^]
2014-10-03 14:22vmromanosReview Assigned To => vmromanos
2014-10-03 14:22vmromanosNote Added: 0070699
2014-10-03 14:22vmromanosStatusresolved => closed
2014-10-14 18:33vmromanosRelationship addedhas duplicate 0027617
2014-12-30 23:22hudsonbotCheckin
2014-12-30 23:22hudsonbotNote Added: 0072889
2023-02-22 05:54thielmikaylaNote Added: 0146848
2023-07-11 13:50shuehnerNote Deleted: 0146848

Notes
(0070527)
reinaldoguerra   
2014-09-30 05:52   
Test plan used:
1- Login into Openbravo ERP
2- Register new sales invoice, add line and process it.
3- Verify that "finalsettlement" field is null at this moments (select FINALSETTLEMENT from c_invoice order by created desc limit 1;)
4- Pay that invoice
5- Execute same database query to verify that "finalsettlement" field has been correctly updated with today's date
6- Access created Payment and run "Reactivate and delete lines" so invoice is pending of payment again
7- Now execute query and verify that "finalsettlement" field is set to null.
(0070697)
hgbot   
2014-10-03 14:20   
Repository: erp/devel/pi
Changeset: fb3182ac0e6d24b17517efe18348f80c4e16add5
Author: Reinaldo Guerra <reinaldo.guerra <at> peoplewalking.com>
Date: Sat Sep 27 10:14:36 2014 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/fb3182ac0e6d24b17517efe18348f80c4e16add5 [^]

Fixed bug 27250: finalsettlement should be null when invoice payment is removed

Method updateInvoicePaymentMonitor on FIN_AddPayment class was modified to set finalsettlement to null when Reactivate and delete lines process is executed.
When a payment related to invoice is removed now invoice finalsettlement field is set to null.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_AddPayment.java
---
(0070699)
vmromanos   
2014-10-03 14:22   
Code review + testing OK
(0072889)
hudsonbot   
2014-12-30 23:22   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test