Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027222Openbravo ERPA. Platformpublic2014-07-29 08:182014-08-08 18:54
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeveritytrivialReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR14Q4 
Merge Request Status
Review Assigned Toshankarb
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027222: NPE in WebServices when trying to delete a non-existing record
DescriptionIf a record with an invalid ID is tried to be deleted using DAL webservices a NPE is thrown.
Steps To Reproduce-Execute WSUpdateTest jUnit test
-Check Tomcat log
ERROR org.openbravo.service.web.BaseWebServiceServlet - java.lang.NullPointerException
org.openbravo.base.exception.OBException: java.lang.NullPointerException
    at org.openbravo.service.web.WebServiceServlet.doDelete(WebServiceServlet.java:89)
Proposed SolutionChange exception to something more descriptive, not NPE.

Note that currently this case returns an HTTP 500, which can be considered part of the public API.

So the same HTTP code should be returned in this case (instead of 404 which could be more appropriate)
Additional Information
TagsNo tags attached.
Relationships
related to defect 0027178 closed platform Error in openbravo.log in ci try-dummy-pgsql job 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-07-29 08:18alostaleNew Issue
2014-07-29 08:18alostaleAssigned To => alostale
2014-07-29 08:18alostaleOBNetwork customer => No
2014-07-29 08:18alostaleModules => Core
2014-07-29 08:18alostaleTriggers an Emergency Pack => No
2014-07-29 08:19alostaleRelationship addedrelated to 0027178
2014-07-29 08:35alostaleReview Assigned To => shankarb
2014-07-29 08:35hgbotCheckin
2014-07-29 08:35hgbotNote Added: 0068944
2014-07-29 08:35hgbotStatusnew => resolved
2014-07-29 08:35hgbotResolutionopen => fixed
2014-07-29 08:35hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6f9569492c5981e537e29a174643e4a97f51fd53 [^]
2014-07-31 06:34shankarbNote Added: 0068996
2014-07-31 06:34shankarbStatusresolved => closed
2014-07-31 06:34shankarbFixed in Version => 3.0PR14Q4
2014-08-08 18:54hudsonbotCheckin
2014-08-08 18:54hudsonbotNote Added: 0069233

Notes
(0068944)
hgbot   
2014-07-29 08:35   
Repository: erp/devel/pi
Changeset: 6f9569492c5981e537e29a174643e4a97f51fd53
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Jul 29 08:34:51 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6f9569492c5981e537e29a174643e4a97f51fd53 [^]

fixed bug 27222: NPE in WebServices when trying to delete a non-existing record

  Throwing OBException in this case so HTTP 500 response is kept

---
M src/org/openbravo/service/rest/DalWebService.java
---
(0068996)
shankarb   
2014-07-31 06:34   
Code reviewed and verified in pi changeset be933e11432c.
(0069233)
hudsonbot   
2014-08-08 18:54   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/4450016dee64 [^]
Maturity status: Test