Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027207Retail ModulesGift cards and gift voucherspublic2014-07-25 23:582015-03-02 12:51
Reporterjecharri 
Assigned Tonaiaramartinez 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027207: Gift cards allow to create gift cards with the same id
DescriptionGift cards allow to create gift cards with the same id
Steps To Reproduce-Install gift cards and configure one product
-Go to Web POS and sale one gift card. Insert id "1234"
-Create a new ticket and verify that yo can create a gift card with same id

We should allow to create same id if the organization of the gift card is different, we should not allow to create a gift cards with same id in same organization.
Proposed SolutionFind attached file with the proposed solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0029098 new marvintm If you open a popup while you are in another popup the second one appears behind the first 
causes defect 0032246 closed Orekaria [GiftCards] Unbalanced calls to setAdminMode and restorePreviousMode 
Attached Filesdiff 27207_IDValidation.diff (10,910) 2014-11-10 10:00
https://issues.openbravo.com/file_download.php?file_id=7491&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-07-25 23:58jecharriNew Issue
2014-07-25 23:58jecharriAssigned To => marvintm
2014-07-25 23:58jecharriResolution time => 1408831200
2014-07-25 23:58jecharriTriggers an Emergency Pack => No
2014-07-26 00:03jecharriSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=6182#r6182
2014-07-26 00:11jecharriSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=6183#r6183
2014-11-03 10:01naiaramartinezIssue Monitored: naiaramartinez
2014-11-10 09:59naiaramartinezProposed Solution updated
2014-11-10 10:00naiaramartinezFile Added: 27207_IDValidation.diff
2015-02-17 09:52hgbotCheckin
2015-02-17 09:52hgbotNote Added: 0074541
2015-02-17 09:52hgbotStatusnew => resolved
2015-02-17 09:52hgbotResolutionopen => fixed
2015-02-17 09:52hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/e60443378ff1de0527b37829bd0684b532946fee [^]
2015-02-19 08:29guillermogilReview Assigned To => marvintm
2015-02-20 13:39migueldejuanaAssigned Tomarvintm => guillermogil
2015-02-20 13:41migueldejuanaNote Added: 0074727
2015-02-20 13:41migueldejuanaStatusresolved => new
2015-02-20 13:41migueldejuanaResolutionfixed => open
2015-02-27 09:07guillermogilIssue Monitored: migueldejuana
2015-02-27 09:07guillermogilReview Assigned Tomarvintm => migueldejuana
2015-02-27 09:07guillermogilAssigned Toguillermogil => naiaramartinez
2015-02-27 09:10hgbotCheckin
2015-02-27 09:10hgbotNote Added: 0075012
2015-02-27 09:10hgbotStatusnew => resolved
2015-02-27 09:10hgbotResolutionopen => fixed
2015-02-27 09:10hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/e60443378ff1de0527b37829bd0684b532946fee [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/c3cea0bef74321ce5eb8a1e541fd9af4c69b7133 [^]
2015-03-02 10:10migueldejuanaNote Added: 0075060
2015-03-02 10:10migueldejuanaStatusresolved => new
2015-03-02 10:10migueldejuanaResolutionfixed => open
2015-03-02 12:40migueldejuanaRelationship addedrelated to 0029098
2015-03-02 12:51migueldejuanaStatusnew => scheduled
2015-03-02 12:51migueldejuanafix_in_branch => pi
2015-03-02 12:51migueldejuanaStatusscheduled => resolved
2015-03-02 12:51migueldejuanaResolutionopen => fixed
2015-03-02 12:51migueldejuanaStatusresolved => closed
2016-02-16 13:32OrekariaRelationship addedcauses 0032246

Notes
(0074541)
hgbot   
2015-02-17 09:52   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: e60443378ff1de0527b37829bd0684b532946fee
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Tue Feb 17 09:52:38 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/e60443378ff1de0527b37829bd0684b532946fee [^]

Fixed issue 27207:Gift cards allow to create gift cards with the same id

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/giftcards/GCNVComponentProvider.java
M web/org.openbravo.retail.giftcards/js/components/lineproperties.js
A src/org/openbravo/retail/giftcards/CheckDuplicityOfID.java
A web/org.openbravo.retail.giftcards/js/preaddpaymenthook.js
---
(0074727)
migueldejuana   
2015-02-20 13:41   
If we try to add 2 gift cards with same ID in an order we get a bad behaviour.
-Add a gift card with ID=1
-Add another gift card with ID=1
-It do nothing, we should show a message "Invalid ID, already exist..."
(0075012)
hgbot   
2015-02-27 09:10   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: c3cea0bef74321ce5eb8a1e541fd9af4c69b7133
Author: Naiara Martinez <naiara.martinez <at> openbravo.com>
Date: Fri Feb 27 09:09:44 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/c3cea0bef74321ce5eb8a1e541fd9af4c69b7133 [^]

Fixed issue 27207: Add a validation to check if the same id exists in the current order.

---
M web/org.openbravo.retail.giftcards/js/components/lineproperties.js
---
(0075060)
migueldejuana   
2015-03-02 10:10   
The first time we try to add a duplicated id gift card, Apply button do nothing.

- Add a gift card with Id = 1
- Try adding another gift card with Id = 1
- Push Apply
ERROR: It do nothing, this line doesn't show the popup:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/c3cea0bef74321ce5eb8a1e541fd9af4c69b7133#l1.13 [^]
You need to push again apply button