Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027205Openbravo ERP07. Sales managementpublic2014-07-25 14:042014-09-08 16:10
ReporterioritzCia 
Assigned ToioritzCia 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tonaiaramartinez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027205: Discounts and Promotions should be able to filter by product characteristics
DescriptionDiscounts and Promotions should be able to filter by product characteristics as it is able to filter by product, org, business partner, ...
Steps To ReproduceNone.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0027482 closed ioritzCia Retail Modules Discounts and Promotions should be able to filter by product characteristics 
related to defect 0027552 closed mtaal Retail Modules Characteristics tab in Discounts and Promotions window does not work for White Valley sample data 
related to design defect 0051252 new Retail Openbravo ERP Different behavior for "Included Characteristics: All of the values defined" discount configuration in the ERP and in POS 
Attached Filesdiff RDSProdCharPosterminalProposed.diff (12,746) 2014-08-27 10:59
https://issues.openbravo.com/file_download.php?file_id=7167&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-07-25 14:04ioritzCiaNew Issue
2014-07-25 14:04ioritzCiaAssigned To => ioritzCia
2014-07-25 14:04ioritzCiaModules => Core
2014-07-25 14:04ioritzCiaTriggers an Emergency Pack => No
2014-08-27 10:05ioritzCiaRelationship addedrelated to 0027482
2014-08-27 10:52ioritzCiaReview Assigned To => mtaal
2014-08-27 10:52ioritzCiaStatusnew => feedback
2014-08-27 10:59mtaalIssue Monitored: mtaal
2014-08-27 10:59ioritzCiaFile Added: RDSProdCharPosterminalProposed.diff
2014-08-29 08:27hgbotCheckin
2014-08-29 08:27hgbotNote Added: 0069849
2014-08-29 15:53hudsonbotCheckin
2014-08-29 15:53hudsonbotNote Added: 0069861
2014-09-04 09:29mtaalNote Added: 0069952
2014-09-08 13:48adrianromeroIssue Monitored: adrianromero
2014-09-08 13:54adrianromeroRelationship addedrelated to 0027552
2014-09-08 15:54ioritzCiaStatusfeedback => scheduled
2014-09-08 15:54ioritzCiafix_in_branch => pi
2014-09-08 16:03hgbotCheckin
2014-09-08 16:03hgbotNote Added: 0070018
2014-09-08 16:04ioritzCiaStatusscheduled => resolved
2014-09-08 16:04ioritzCiaFixed in SCM revision => 1d7c83e41c43
2014-09-08 16:04ioritzCiaResolutionopen => fixed
2014-09-08 16:10naiaramartinezReview Assigned Tomtaal => naiaramartinez
2014-09-08 16:10naiaramartinezNote Added: 0070021
2014-09-08 16:10naiaramartinezStatusresolved => closed
2022-12-28 12:40aferrazRelationship addedrelated to 0051252

Notes
(0069849)
hgbot   
2014-08-29 08:27   
Repository: erp/devel/pi
Changeset: 1d7c83e41c43d67df73acee0bd50e906b8905e74
Author: Ioritz Cia <ioritz.cia <at> openbravo.com>
Date: Thu Aug 28 12:42:56 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1d7c83e41c43d67df73acee0bd50e906b8905e74 [^]

Related to issue 27205: Discounts and Promotions should be able to filter by product characteristics.

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/KernelApplicationInitializer.java
M src-db/database/model/functions/M_PROMOTION_CALCULATE.xml
M src-db/database/model/tables/M_OFFER.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/AD_REF_TREE.xml
M src-db/database/sourcedata/AD_REF_TREE_FIELD.xml
M src-db/database/sourcedata/AD_TAB.xml
M src-db/database/sourcedata/AD_TABLE.xml
M src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
M src/org/openbravo/erpCommon/businessUtility/PriceAdjustment.java
A src-db/database/model/functions/M_ISPARENT_CH_VALUE.xml
A src-db/database/model/tables/M_OFFER_CHARACTERISTIC.xml
---
(0069861)
hudsonbot   
2014-08-29 15:53   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/af520c9729b9 [^]
Maturity status: Test
(0069952)
mtaal   
2014-09-04 09:29   
Few first questions on the retail diff:
- are you using jsbeautifier to format it?
- did you use jslint to check it?

gr. Martin
(0070018)
hgbot   
2014-09-08 16:03   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 8481d772024bc0a052a0f89019df7b4e2a500380
Author: Ioritz Cia <ioritz.cia <at> openbravo.com>
Date: Mon Sep 08 15:54:47 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8481d772024bc0a052a0f89019df7b4e2a500380 [^]

Fixes issue 27482: Discounts and Promotions should be able to filter by product characteristics.
Related to issue 27205: Discounts and Promotions should be able to filter by product characteristics.

---
M src/org/openbravo/retail/posterminal/ApplicationCacheComponent.java
M src/org/openbravo/retail/posterminal/master/ProductChValue.java
M web/org.openbravo.retail.posterminal/js/model/discounts.js
M web/org.openbravo.retail.posterminal/js/model/executor.js
M web/org.openbravo.retail.posterminal/js/model/promotions.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
A src/org/openbravo/retail/posterminal/master/DiscountFilterCharacteristic.java
A src/org/openbravo/retail/posterminal/master/ProductProductChValue.java
A src/org/openbravo/retail/posterminal/master/ProductProductChValueProperties.java
---
(0070021)
naiaramartinez   
2014-09-08 16:10   
Code review and testing OK