Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027167Retail ModulesWeb POSpublic2014-07-23 16:212014-09-05 10:53
ReporterOrekaria 
Assigned ToOrekaria 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR14Q4Fixed in VersionRR14Q4 
Merge Request Status
Review Assigned Tomtaal
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027167: When the javascript files contain an error, the WebPOS fails to load showing an uncaught error
DescriptionWhen the javascript files contain an error, the WebPOS fails to load showing an uncaught error
Steps To ReproduceBreak the syntax of e.g: in ob-dal.js introduce xxx at the start of the file
In the browser, open the developer tools, console
Uncheck pause on exceptions
Proposed SolutionCatch the error and show a mean message
Additional Information
TagsNo tags attached.
Relationships
related to defect 0027371 closed Orekaria Stabilization: The WebPOS manifest does not have the correct data 
blocks feature request 0027329 new Retail Stabilization: Overhaul the loading process (since the url is entered until the webpos has loaded) 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-07-23 16:21OrekariaNew Issue
2014-07-23 16:21OrekariaAssigned To => marvintm
2014-07-23 16:21OrekariaTriggers an Emergency Pack => No
2014-07-23 16:21OrekariaAssigned Tomarvintm => Orekaria
2014-07-23 16:21OrekariaTarget Version => RR14Q4
2014-07-23 16:24hgbotCheckin
2014-07-23 16:24hgbotNote Added: 0068846
2014-07-23 16:24hgbotStatusnew => resolved
2014-07-23 16:24hgbotResolutionopen => fixed
2014-07-23 16:24hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/97d720a6621e4de97e9f04f03aad96d220037ea4 [^]
2014-07-25 20:36szapataReview Assigned To => szapata
2014-07-25 20:36szapataStatusresolved => closed
2014-08-19 14:32hgbotCheckin
2014-08-19 14:32hgbotNote Added: 0069509
2014-08-19 14:32hgbotStatusclosed => resolved
2014-08-19 14:32hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/97d720a6621e4de97e9f04f03aad96d220037ea4 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/236b4bea0a7b8c28150266c8248c43a5a2d513fd [^]
2014-08-20 10:12mtaalNote Added: 0069535
2014-08-20 10:12mtaalStatusresolved => new
2014-08-20 10:12mtaalResolutionfixed => open
2014-08-20 10:18OrekariaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=6377#r6377
2014-08-20 10:21hgbotCheckin
2014-08-20 10:21hgbotNote Added: 0069536
2014-08-20 10:21hgbotStatusnew => resolved
2014-08-20 10:21hgbotResolutionopen => fixed
2014-08-20 10:21hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/236b4bea0a7b8c28150266c8248c43a5a2d513fd [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1cfd9ea56b5a8c54cbb9e1a58294d071ff2426ca [^]
2014-08-24 05:17hgbotCheckin
2014-08-24 05:17hgbotNote Added: 0069662
2014-08-24 05:17hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1cfd9ea56b5a8c54cbb9e1a58294d071ff2426ca [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5eb316c05d3124d5b8f12c9a915bfff575690a4c [^]
2014-08-24 18:05hgbotCheckin
2014-08-24 18:05hgbotNote Added: 0069677
2014-08-24 18:05hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5eb316c05d3124d5b8f12c9a915bfff575690a4c [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/33a2a309ed6da2b1b54d26dc0b82c77ffd8383f7 [^]
2014-08-26 11:58hgbotCheckin
2014-08-26 11:58hgbotNote Added: 0069751
2014-08-26 11:58hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/33a2a309ed6da2b1b54d26dc0b82c77ffd8383f7 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/803e2fc7d5dd166c4ffad64e256d69f0528d9c48 [^]
2014-08-26 11:59OrekariaRelationship addedrelated to 0027371
2014-08-28 09:43mtaalReview Assigned Toszapata => mtaal
2014-08-28 09:43mtaalNote Added: 0069822
2014-08-28 09:43mtaalStatusresolved => closed
2014-08-28 09:43mtaalFixed in Version => RR14Q4
2014-09-02 20:53hgbotCheckin
2014-09-02 20:53hgbotNote Added: 0069924
2014-09-02 20:53hgbotStatusclosed => resolved
2014-09-02 20:53hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/803e2fc7d5dd166c4ffad64e256d69f0528d9c48 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/170e31d48cbd97f23387d726279fd59e69e60439 [^]
2014-09-02 21:08OrekariaRelationship addedblocks 0027329
2014-09-05 10:53mtaalNote Added: 0069979
2014-09-05 10:53mtaalStatusresolved => closed

Notes
(0068846)
hgbot   
2014-07-23 16:24   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 97d720a6621e4de97e9f04f03aad96d220037ea4
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Wed Jul 23 16:24:37 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/97d720a6621e4de97e9f04f03aad96d220037ea4 [^]

Fixes issue 27167: The index.jsp has been improved...
- it does not raises an uncaught exception
- it does show an error in the console log

---
M web/org.openbravo.retail.posterminal/index.jsp
---
(0069509)
hgbot   
2014-08-19 14:32   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 236b4bea0a7b8c28150266c8248c43a5a2d513fd
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Tue Aug 19 14:32:04 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/236b4bea0a7b8c28150266c8248c43a5a2d513fd [^]

Fixes issue 27167: Improved message when the WebPOS cannot be loaded

---
M web/org.openbravo.retail.posterminal/index.jsp
---
(0069535)
mtaal   
2014-08-20 10:12   
[10:08:52] Martin Taal: I see this line:
[10:08:53] Martin Taal: if ((typeof OB !== "undefined") && (typeof OB.POS !== "undefined")) {
[10:09:02] Martin Taal: but why don't you do this:
[10:09:09] Martin Taal: if (OB && OB.POS) {
[10:09:15] Martin Taal: I think it is simpler
[10:09:30] Martin Taal: and !== will not do type conversion
[10:09:36] Martin Taal: so if OB is undefined
[10:09:44] Martin Taal: then OB !== "undefined" is true
[10:09:50] Martin Taal: and you use double quotes
[10:09:56] Martin Taal: while in js we should use single quotes
[10:10:03] Martin Taal: '
(0069536)
hgbot   
2014-08-20 10:21   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 1cfd9ea56b5a8c54cbb9e1a58294d071ff2426ca
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Wed Aug 20 10:21:25 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1cfd9ea56b5a8c54cbb9e1a58294d071ff2426ca [^]

Fixes issue 27167: better checks

---
M web/org.openbravo.retail.posterminal/index.jsp
---
(0069662)
hgbot   
2014-08-24 05:17   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 5eb316c05d3124d5b8f12c9a915bfff575690a4c
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sun Aug 24 05:17:35 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5eb316c05d3124d5b8f12c9a915bfff575690a4c [^]

Fixes issue 27167: Backed out rev.3819, changeset: 1cfd9ea56b5a. The short notation does not work

---
M web/org.openbravo.retail.posterminal/index.jsp
---
(0069677)
hgbot   
2014-08-24 18:05   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 33a2a309ed6da2b1b54d26dc0b82c77ffd8383f7
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sun Aug 24 18:04:54 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/33a2a309ed6da2b1b54d26dc0b82c77ffd8383f7 [^]

Fixes issue 27167: double quotas to single in index.jsp

---
M web/org.openbravo.retail.posterminal/index.jsp
---
(0069751)
hgbot   
2014-08-26 11:58   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 803e2fc7d5dd166c4ffad64e256d69f0528d9c48
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Tue Aug 26 11:57:17 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/803e2fc7d5dd166c4ffad64e256d69f0528d9c48 [^]

Fixes issue 27167, related to issue 27371: Added an error handler so loading errors are catched (manifest exception one of those)

---
M web/org.openbravo.retail.posterminal/index.jsp
---
(0069822)
mtaal   
2014-08-28 09:43   
Reviewed
(0069924)
hgbot   
2014-09-02 20:53   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 170e31d48cbd97f23387d726279fd59e69e60439
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Tue Sep 02 20:53:29 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/170e31d48cbd97f23387d726279fd59e69e60439 [^]

Fixes issue 27167: An error message is also shown to the user when even the javascript cannot be loaded

---
M web/org.openbravo.retail.posterminal/index.jsp
---
(0069979)
mtaal   
2014-09-05 10:53   
Reviewed