Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027163Retail ModulesWeb POSpublic2014-07-23 09:582014-09-01 16:33
Reporternaiaramartinez 
Assigned Tonaiaramartinez 
PrioritynormalSeveritytrivialReproducibilityhave not tried
StatusclosedResolutionopen 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomtaal
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027163: When cloning an object, the properties that exists in B object but not in A are not deleted.
DescriptionWhen removing an order in WebPOS it is not deleting new properties that have been added to the order. When removing, new order is cloned but the 'new' properties are not removed. This is because, when cloning an object, the properties that exists in B object but not in A are not deleted.

Steps To ReproduceCreate a button that adds new property to the order ( for example, coupons: "a").
Create an order in WebPos.
Click in the button to add the new property.
Remove the order. notice that the property 'coupons' is still there.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
has duplicate defect 0027697 closed marvintm Order model is not correctly removing previous orders attributes 
causes design defect 0028694 closed Orekaria The creationDate is not part of the receipt attributes 
Attached Filesdiff issue27163.diff (938) 2014-08-26 12:31
https://issues.openbravo.com/file_download.php?file_id=7161&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-07-23 09:58naiaramartinezNew Issue
2014-07-23 09:58naiaramartinezAssigned To => marvintm
2014-07-23 09:58naiaramartinezTriggers an Emergency Pack => No
2014-07-23 09:58naiaramartinezAssigned Tomarvintm => naiaramartinez
2014-08-26 12:31naiaramartinezFile Added: issue27163.diff
2014-08-26 12:32naiaramartinezReview Assigned To => mtaal
2014-08-26 12:38hgbotCheckin
2014-08-26 12:38hgbotNote Added: 0069754
2014-08-26 12:38hgbotStatusnew => resolved
2014-08-26 12:38hgbotResolutionopen => fixed
2014-08-26 12:38hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/a8573391d98b7f85c02d423f17f5621caa370eca [^]
2014-09-01 08:39mtaalNote Added: 0069875
2014-09-01 08:39mtaalStatusresolved => new
2014-09-01 08:39mtaalResolutionfixed => open
2014-09-01 16:05hgbotCheckin
2014-09-01 16:05hgbotNote Added: 0069891
2014-09-01 16:11naiaramartinezStatusnew => scheduled
2014-09-01 16:11naiaramartinezStatusscheduled => resolved
2014-09-01 16:33mtaalNote Added: 0069899
2014-09-01 16:33mtaalStatusresolved => closed
2014-09-29 08:25guillermogilRelationship addedhas duplicate 0027697
2015-01-20 14:55OrekariaRelationship addedcauses 0028694

Notes
(0069754)
hgbot   
2014-08-26 12:38   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: a8573391d98b7f85c02d423f17f5621caa370eca
Author: Naiara Martinez <naiara.martinez <at> openbravo.com>
Date: Tue Aug 26 12:38:25 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/a8573391d98b7f85c02d423f17f5621caa370eca [^]

Fixed issue 27163: When cloning an object, the properties that exists in B object but not in A are not deleted

---
M web/org.openbravo.mobile.core/source/utils/ob-utilities.js
---
(0069875)
mtaal   
2014-09-01 08:39   
I am reviewing but I need to re-open the issue. I guess the code could/should move inside the first _.each and then as an 'else' as part of the if statement in there.
The current code will fail if the object is not a type object.

Let me know what you think on this.

gr. Martin
(0069891)
hgbot   
2014-09-01 16:05   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 014296eb0a7abbe5770b849ec19db4e3f6b9ee25
Author: Naiara Martinez <naiara.martinez <at> openbravo.com>
Date: Mon Sep 01 13:54:25 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/014296eb0a7abbe5770b849ec19db4e3f6b9ee25 [^]

Related to issue 27163: move code inside an IF where the clonedObject is initialized

---
M web/org.openbravo.mobile.core/source/utils/ob-utilities.js
---
(0069899)
mtaal   
2014-09-01 16:33   
Reviewed