Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0027157Openbravo ERPA. Platformpublic2014-07-22 15:502014-08-08 18:54
alostale 
AugustoMauch 
urgentmajorhave not tried
closedfixed 
5
 
3.0PR14Q43.0PR14Q4 
shankarb
Core
No
0027157: summary functions in saved view/grid config cause several requests
When a saved view or a grid configuration includes summary functions, several datasource requests to are executed.
In a Professional instance:

-Case 1 (saved view)
  1.1 Open Sales Order window
  1.2 Set Grand Total as Summary (eg. sum) function:
      * Right click on grid's Grand Total column title
      * Select Set Summary Function > Sum
  1.3 Save this view and set it as default
  1.4 Close Sales Order window
  1.5 Open it again and check XHR requests -> 5 requests to Order for summary function are executed (1 for real ds, 4 for summary)
-Case 2 (grid configuration)
  2.1 Open Sales Invoice window
  2.2 Set Grand Total as summary (see step 1.2)
  2.3 Move any grid column position to save grid to be saved
  2.4 Close Sales Invoice window
  2.5 Open it again and check XHR requests -> 5 requests to Invoice for summary function are executed (1 for real ds, 4 for summary)

Note case 1 and 2 can be combined for a single window, in this case the result is the number of requests is 7
Summary functions, by SC design, should result in a single extra request (if there are several summary columns all of them should be grouped in a single one). This is opening the window should trigger 2 requests: 1 for data loading + 1 for summary info.
Performance
related to defect 0024684 closed alostale Double DataSource request when there is grid configuration 
Issue History
2014-07-22 15:50alostaleNew Issue
2014-07-22 15:50alostaleAssigned To => AugustoMauch
2014-07-22 15:50alostaleModules => Core
2014-07-22 15:50alostaleTriggers an Emergency Pack => No
2014-07-22 15:51alostaleTag Attached: Performance
2014-07-22 16:32shuehnerIssue Monitored: shuehner
2014-07-22 16:33mtaalIssue Monitored: mtaal
2014-07-22 17:03alostaleRelationship addedrelated to 0024684
2014-07-23 09:05alostaleSummarysummary functions in saved view cause several requests => summary functions in saved view/grid config cause several requests
2014-07-23 09:05alostaleDescription Updatedbug_revision_view_page.php?rev_id=6122#r6122
2014-07-23 09:05alostaleSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=6124#r6124
2014-07-23 09:05alostaleProposed Solution updated
2014-07-23 09:44alostaleNote Added: 0068826
2014-07-23 09:46hgbotCheckin
2014-07-23 09:46hgbotNote Added: 0068827
2014-07-23 09:46hgbotStatusnew => resolved
2014-07-23 09:46hgbotResolutionopen => fixed
2014-07-23 09:46hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6e7fbc189b5d0147bcf7ffd74737293a2842bab9 [^]
2014-07-23 16:15alostaleReview Assigned To => shankarb
2014-07-24 10:27shankarbNote Added: 0068856
2014-07-24 10:27shankarbStatusresolved => closed
2014-07-24 10:27shankarbFixed in Version => 3.0PR14Q4
2014-08-08 18:54hudsonbotCheckin
2014-08-08 18:54hudsonbotNote Added: 0069215

Notes
(0068826)
alostale   
2014-07-23 09:44   
Executed test cases:
-the 2 ones explained in the steps to reproduce, individually and combined
-the same for subtabs, both at 1st position and in other ones
(0068827)
hgbot   
2014-07-23 09:46   
Repository: erp/devel/pi
Changeset: 6e7fbc189b5d0147bcf7ffd74737293a2842bab9
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Jul 23 09:46:04 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6e7fbc189b5d0147bcf7ffd74737293a2842bab9 [^]

fixed bug 27157: multi-requests in summary functions in saved view/grid config

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0068856)
shankarb   
2014-07-24 10:27   
Code reviewed and verified in pi changeset 1ecf6de02840
(0069215)
hudsonbot   
2014-08-08 18:54   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/4450016dee64 [^]
Maturity status: Test