Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0027112Openbravo ERPA. Platformpublic2014-07-17 13:532014-08-08 18:53
shuehner 
mtaal 
immediateminorhave not tried
closedfixed 
5
 
3.0PR14Q4 
shankarb
Core
No
0027112: DatasetExportTest.testIncludeAllPlusChildren fails with oom on bigger c_order (+children)
Running that test against a db having more orders (+childrens) fails with oom (depening on heap size).

Just running that test against whitevalley data as recently added to retail-ci is sufficient to trigger the problem.

Checking test code shows that it unconditionally exports all of c_order + all children to xml which can grow indefinitely depending on data-size.

As the test seems to only check structure of the xml it should be possible to change the test to only export smaller datasets.

Possible options
1.) keep c_order table but add whereclause. Problem is that whereclause needs to work with both f&b + also whitevalley data
2.) Change test to use other table garanteed to have much smaller/fixed size
ant run.all.tests against retail db with heap size -Xmx512M for ant_opts and 1G for catalina_opts
No tags attached.
Issue History
2014-07-17 13:53shuehnerNew Issue
2014-07-17 13:53shuehnerAssigned To => mtaal
2014-07-17 13:53shuehnerModules => Core
2014-07-17 13:53shuehnerTriggers an Emergency Pack => No
2014-07-21 01:54hgbotCheckin
2014-07-21 01:54hgbotNote Added: 0068740
2014-07-21 01:54hgbotStatusnew => resolved
2014-07-21 01:54hgbotResolutionopen => fixed
2014-07-21 01:54hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7a248f55faf504a29fab3c19aa19110321673249 [^]
2014-07-22 00:25hgbotCheckin
2014-07-22 00:25hgbotNote Added: 0068773
2014-07-29 08:47alostaleReview Assigned To => shankarb
2014-07-31 06:28shankarbNote Added: 0068993
2014-07-31 06:28shankarbStatusresolved => closed
2014-07-31 06:28shankarbFixed in Version => 3.0PR14Q4
2014-08-08 18:53hudsonbotCheckin
2014-08-08 18:53hudsonbotNote Added: 0069188
2014-08-08 18:53hudsonbotCheckin
2014-08-08 18:53hudsonbotNote Added: 0069198

Notes
(0068740)
hgbot   
2014-07-21 01:54   
Repository: erp/devel/pi
Changeset: 7a248f55faf504a29fab3c19aa19110321673249
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Jul 21 01:53:37 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/7a248f55faf504a29fab3c19aa19110321673249 [^]

Fixes issue 27112: DatasetExportTest.testIncludeAllPlusChildren fails with oom on bigger c_order (+children)

---
M src-test/org/openbravo/test/xml/DatasetExportTest.java
---
(0068773)
hgbot   
2014-07-22 00:25   
Repository: erp/devel/pi
Changeset: c710d0280ce230bf85fd7d6b90de21250e56d506
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Jul 22 00:24:51 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c710d0280ce230bf85fd7d6b90de21250e56d506 [^]

Related to issue 27112: added code comment

---
M src-test/org/openbravo/test/xml/DatasetExportTest.java
---
(0068993)
shankarb   
2014-07-31 06:28   
Code reviewed and verified in pi changeset be933e11432c.
(0069188)
hudsonbot   
2014-08-08 18:53   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/4450016dee64 [^]
Maturity status: Test
(0069198)
hudsonbot   
2014-08-08 18:53   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/4450016dee64 [^]
Maturity status: Test