Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027053Openbravo ERPA. Platformpublic2014-07-11 11:482014-10-01 16:07
Reportermaite 
Assigned ToAugustoMauch 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR14Q4Fixed in Version3.0PR14Q4 
Merge Request Status
Review Assigned Toshankarb
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2014-03-05
Regression introduced in release3.0PR14Q2
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/381047f42270513a9fbfae0c09866e77f835061b [^]
Triggers an Emergency PackYes
Summary0027053: Error when adding record in grid mode and working with comma as decimal separator
DescriptionError when adding record in grid mode and working with comma as decimal separator
Steps To Reproduce0. Edit Format.xml file to set "comma" as decimal separator for prices reference
1. Compile and restart tomcat
2. Access Sales Invoice header and create record
3. Access Lines tab and "Insert row" in grid mode. Choose any product and change price to set 458,45. Immediately click on "Line Net amount" field (which is a read only field) and realize that saved "Net Unit Price" is 45.845,00 (instead of 458,45)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
caused by defect 00255173.0PR14Q3 closed shankarb Wrong calculations on numeric field depending on the formula 
has duplicate defect 00276683.0PR14Q4 closed AugustoMauch Amount change when focus is lost on price fields with comma as decimal separator 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-07-11 11:48maiteNew Issue
2014-07-11 11:48maiteAssigned To => dmiguelez
2014-07-11 11:48maiteModules => Core
2014-07-11 11:48maiteTriggers an Emergency Pack => No
2014-07-11 11:50maiteIssue Monitored: networkb
2014-07-11 11:52maiteAssigned Todmiguelez => jonalegriaesarte
2014-07-21 16:35jonalegriaesarteResolution time => 1407708000
2014-07-24 13:45jonalegriaesarteAssigned Tojonalegriaesarte => AtulOpenbravo
2014-09-22 16:15vmromanosNote Added: 0070244
2014-09-22 16:15vmromanosAssigned ToAtulOpenbravo => AugustoMauch
2014-09-22 16:15vmromanosCategory07. Sales management => A. Platform
2014-09-23 09:54inigosanchezAssigned ToAugustoMauch => inigosanchez
2014-09-24 10:45caristuRelationship addedhas duplicate 0027668
2014-09-24 10:47caristuIssue Monitored: caristu
2014-09-26 10:21miruritaNote Added: 0070430
2014-09-26 10:40jonalegriaesarteResolution time1407708000 => 1411768800
2014-09-26 10:40jonalegriaesartePriorityurgent => immediate
2014-09-26 12:06inigosanchezAssigned Toinigosanchez => AugustoMauch
2014-09-26 12:07inigosanchezIssue Monitored: inigosanchez
2014-09-26 15:31AugustoMauchRegression date => 2014-03-05
2014-09-26 15:31AugustoMauchRegression introduced in release => 3.0PR14Q2
2014-09-26 15:31AugustoMauchRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/381047f42270513a9fbfae0c09866e77f835061b [^]
2014-09-26 15:31AugustoMauchTriggers an Emergency PackNo => Yes
2014-09-26 15:50AugustoMauchRelationship addedcaused by 0025517
2014-09-26 16:06AugustoMauchIssue Monitored: shankarb
2014-09-26 16:06AugustoMauchReview Assigned To => shankarb
2014-09-26 16:07hgbotCheckin
2014-09-26 16:07hgbotNote Added: 0070439
2014-09-26 16:07hgbotStatusnew => resolved
2014-09-26 16:07hgbotResolutionopen => fixed
2014-09-26 16:07hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f5caad158261168b4347c1f92bbafa301e3304e7 [^]
2014-09-29 22:00hudsonbotCheckin
2014-09-29 22:00hudsonbotNote Added: 0070515
2014-09-30 07:54shankarbNote Added: 0070532
2014-09-30 07:54shankarbStatusresolved => closed
2014-09-30 07:54shankarbFixed in Version => 3.0PR14Q4
2014-10-01 16:07plujanRegression level => Production - Confirmed Stable

Notes
(0070244)
vmromanos   
2014-09-22 16:15   
Assigned to Platform team
(0070430)
mirurita   
2014-09-26 10:21   
The same behaviour happens in "amount" reference columns such as "amount" in payment in window.
(0070439)
hgbot   
2014-09-26 16:07   
Repository: erp/devel/pi
Changeset: f5caad158261168b4347c1f92bbafa301e3304e7
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Sep 26 15:55:41 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f5caad158261168b4347c1f92bbafa301e3304e7 [^]

Fixes issue 27053: Numbers are properly formatted with , as decimal separator

Decimal numbers were not being properly formatted if a comma was used as decimal separator. The problem was caused by using the OBPlainToOBMasked instead of JSToOBMasked to convert a javascript number to a formatted string. OBPlainToOBMasked does not expect a javascript number as an argument, but a non-formatted string representation of a number. The issue has been fixed by replacing OBPlainToOBMasked with JSToOBMasked.

The issue that caused this regression [1] works the same as it worked when it was fixed. It works properly using the '.' as decimal separator, but not when using ','

[1] https://issues.openbravo.com/view.php?id=25517 [^]

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-number.js
---
(0070515)
hudsonbot   
2014-09-29 22:00   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b0bbca1e7e46 [^]
Maturity status: Test
(0070532)
shankarb   
2014-09-30 07:54   
Code reviewed and verified in pi changeset 6c864add1905.