Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027002Retail ModulesApproval process - onlinepublic2014-07-02 17:462015-01-08 12:46
Reporterebecerra 
Assigned Toebecerra 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR15Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027002: Extend Approval dialog to allow show custom message on approval dialog.
DescriptionExtend Approval dialog to allow show custom message on approval dialog.

Create a new function to pass a new parameter with custom messages.
Steps To ReproduceN/A
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0027783 closed migueldejuana Is not possible to logout under some circumnstances 
related to defect 0031114 closed adrianromero New approval message is not validated properly 
Attached Filesdiff 27002_patchOverQ3.diff (11,689) 2014-10-15 11:32
https://issues.openbravo.com/file_download.php?file_id=7367&type=bug
diff org.openbravo.mobile.core_issue_27002_Q1.diff (2,452) 2014-11-26 13:48
https://issues.openbravo.com/file_download.php?file_id=7543&type=bug
diff org.openbravo.retail.posterminal_issue_27002_Q1.diff (8,765) 2014-11-26 13:49
https://issues.openbravo.com/file_download.php?file_id=7544&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-07-02 17:46ebecerraNew Issue
2014-07-02 17:46ebecerraAssigned To => marvintm
2014-07-02 17:46ebecerraTriggers an Emergency Pack => No
2014-07-02 17:47rafademiguelAssigned Tomarvintm => ebecerra
2014-07-02 17:48rafademiguelTarget Version => RR14Q4
2014-09-03 12:14rafademiguelFile Added: issue_27002_org.openbravo.retail.posterminal.diff
2014-09-03 13:56mtaalNote Added: 0069942
2014-09-08 17:34rafademiguelFile Deleted: issue_27002_org.openbravo.retail.posterminal.diff
2014-09-08 18:24rafademiguelFile Added: issue_27002_org.openbravo.retail.posterminal_V2.diff
2014-09-09 16:15rafademiguelFile Deleted: issue_27002_org.openbravo.retail.posterminal_V2.diff
2014-09-09 16:16rafademiguelNote Added: 0070057
2014-09-09 16:16rafademiguelIssue Monitored: rafademiguel
2014-09-22 16:21mtaalTarget VersionRR14Q4 =>
2014-10-15 11:32rafademiguelFile Added: 27002_patchOverQ3.diff
2014-10-15 11:36rafademiguelNote Added: 0070950
2014-11-25 07:57mtaalRelationship addedrelated to 0027783
2014-11-26 13:48mtaalFile Added: org.openbravo.mobile.core_issue_27002_Q1.diff
2014-11-26 13:49mtaalFile Added: org.openbravo.retail.posterminal_issue_27002_Q1.diff
2014-11-27 11:09hgbotCheckin
2014-11-27 11:09hgbotNote Added: 0072054
2014-11-27 11:09hgbotStatusnew => resolved
2014-11-27 11:09hgbotResolutionopen => fixed
2014-11-27 11:09hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/b367392dc5bed7e651b440e3d65ecd5e46d49b94 [^]
2014-11-27 11:09hgbotCheckin
2014-11-27 11:09hgbotNote Added: 0072055
2014-11-27 11:09hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/b367392dc5bed7e651b440e3d65ecd5e46d49b94 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f484522836834b438f46110c8f10871d24adaa30 [^]
2014-11-28 11:57marvintmReview Assigned To => marvintm
2014-11-28 11:57marvintmStatusresolved => closed
2014-11-28 11:57marvintmFixed in Version => RR15Q1
2015-01-08 12:46mtaalSummaryWeb POS Approval dialog extension => Extend Approval dialog to allow show custom message on approval dialog.
2015-06-10 22:27dbazRelationship addedrelated to 0030154
2015-06-10 22:29dbazRelationship deletedrelated to 0030154
2015-10-08 18:30adrianromeroRelationship addedrelated to 0031114

Notes
(0069942)
mtaal   
2014-09-03 13:56   
Can you give an example on how I can set the approval message?
is it from code?

gr. Martin
(0070057)
rafademiguel   
2014-09-09 16:16   
Martin,

We found a bug on this code so I've deleted the previous diff and we will come back with a new one.

Also we will provide an example, no problem.

Rafa
(0070950)
rafademiguel   
2014-10-15 11:36   
Hello Martin,

I've uploaded a new (and last) version of the patch.

You can check an example here:

https://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.discountmatrixmanagement/file/51e7c08c3399/web/org.openbravo.retail.discounts.discountmatrixmanagement/js/hookRoleDiscounts.js#l152 [^]
(0072054)
hgbot   
2014-11-27 11:09   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: b367392dc5bed7e651b440e3d65ecd5e46d49b94
Author: Rafa de Miguel <rafael.demiguel <at> openbravo.com>
Date: Thu Nov 27 11:08:48 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/b367392dc5bed7e651b440e3d65ecd5e46d49b94 [^]

Fixed issue 27002: Web POS Approval dialog extension

---
M web/org.openbravo.mobile.core/source/component/obpos-approval.js
---
(0072055)
hgbot   
2014-11-27 11:09   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f484522836834b438f46110c8f10871d24adaa30
Author: Rafa de Miguel <rafael.demiguel <at> openbravo.com>
Date: Thu Nov 27 11:05:47 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f484522836834b438f46110c8f10871d24adaa30 [^]

Fixed issue 27002: Web POS Approval dialog extension

---
M src-db/database/model/tables/OBPOS_ORDER_APPROVAL.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
M web/org.openbravo.retail.posterminal/js/model/terminal-model.js
---