Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0026984Openbravo ERPB. User interfacepublic2014-07-01 10:512014-09-30 16:45
Reportercaristu 
Assigned Todbaz 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0PR14Q3Fixed in Version3.0PR14Q3 
Merge Request Status
Review Assigned Toshankarb
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket29579
Regression levelProduction - QA Approved
Regression date2014-02-26
Regression introduced in release3.0PR14Q2
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/20eb3426d990 [^]
Triggers an Emergency PackNo
Summary0026984: Unable to close the Show Log window
DescriptionUnable to close the "Show Log" window
Steps To Reproduce1) Go to Module Management window
2) Install a new Module
3) Click on the "rebuild now" link. The "Rebuild the System" window is opened.
4) Click on the "Show Log" window
5) Notice that is not possible to minime, maximize or close this window.The following error is being raised in the console: "Uncaught SyntaxError: Unexpected identifier"
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-07-01 10:51caristuNew Issue
2014-07-01 10:51caristuAssigned To => dbaz
2014-07-01 10:51caristuOBNetwork customer => Yes
2014-07-01 10:51caristuModules => Core
2014-07-01 10:51caristuSupport ticket => 29579
2014-07-01 10:51caristuTriggers an Emergency Pack => No
2014-07-01 10:51caristuIssue Monitored: networkb
2014-07-01 11:28caristuPriorityhigh => immediate
2014-07-01 15:37caristuTarget VersionPR14Q3 => PR14Q4
2014-07-01 16:24dbazRegression level => Production - QA Approved
2014-07-01 16:24dbazRegression date => 2014-02-26
2014-07-01 16:24dbazRegression introduced in release => PR14Q2
2014-07-01 16:24dbazRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/20eb3426d990 [^]
2014-07-01 16:54dbazReview Assigned To => shankarb
2014-07-01 16:54dbazIssue Monitored: shankarb
2014-07-01 17:03dbazNote Added: 0068489
2014-07-01 17:07dbazNote Added: 0068490
2014-07-01 17:07caristuTarget VersionPR14Q4 => PR14Q3
2014-07-01 17:11hgbotCheckin
2014-07-01 17:11hgbotNote Added: 0068492
2014-07-01 17:11hgbotStatusnew => resolved
2014-07-01 17:11hgbotResolutionopen => fixed
2014-07-01 17:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f1c53461ec96651fdae45996e488f2cd357c85ad [^]
2014-07-02 06:53shankarbNote Added: 0068494
2014-07-02 06:53shankarbStatusresolved => closed
2014-07-02 06:53shankarbFixed in Version => PR14Q3
2014-07-02 16:47hudsonbotCheckin
2014-07-02 16:47hudsonbotNote Added: 0068515
2014-09-30 16:45plujanRegression introduced in releasePR14Q2 => 3.0PR14Q2

Notes
(0068489)
dbaz   
2014-07-01 17:03   
The problems is that now Smartclient in its internal logic build functions using the popup name. The only popup that has an space in core is this one (Show Log).

Smartclient tries to do something like

Show Log_a3rf8f349.flash()

and it crashes because of that space.

The solution has two parts:
* Change the 'Show Log' popup name to 'ShowLog'
* Ensure that if there is a module implementing a popup with a name with spaces, the spaces are converted to "_". This was done in the past only for IE, now it is done for all browsers.
(0068490)
dbaz   
2014-07-01 17:07   
Since these popups are old 2.50 deprecated technology and since the fix is robust enough and in legacy code, it doesn't make any sense to prepare an automated test case for this regression.

It is almost impossible that in the future this isolated popup cannot be closed while the other application popups can be closed.
(0068492)
hgbot   
2014-07-01 17:11   
Repository: erp/devel/pi
Changeset: f1c53461ec96651fdae45996e488f2cd357c85ad
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Tue Jul 01 17:11:20 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f1c53461ec96651fdae45996e488f2cd357c85ad [^]

Fixed issue 26984: 'Show Log' popup can be closed again

---
M src/org/openbravo/erpCommon/ad_process/ApplyModules.html
M src/org/openbravo/erpCommon/security/Login.html
M src/org/openbravo/erpCommon/security/Login_F1.html
M web/js/utils.js
---
(0068494)
shankarb   
2014-07-02 06:53   
Code reviewed and verified in pi changeset d84acc99f234.
(0068515)
hudsonbot   
2014-07-02 16:47   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/e8fdcd7d974b [^]
Maturity status: Test