Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0026932ModulesRemittancepublic2014-06-24 18:032015-01-21 18:21
Reporteregoitz 
Assigned Tofsoto82 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Toumartirena
Support ticket
OBNetwork customer
Regression introduced in release
Summary0026932: Performance problems on the settle remitance process
DescriptionPerformance problems on the settle remittance process.
Steps To ReproduceTry to settle more than 500 remitance lines.
*It takes long
Proposed SolutionON the ยก CancelReturnRemittance.cancelPayments
instead of use a List of payments use a lIst of the id's (strPayments)
Then on the loop create an instance of the payment for each execution.
It allows you to clear the session on the loop.


Additional Information
TagsPerformance
Relationships
related to defect 0026941 closed fsoto82 Improve performance on the settle remitance process 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-06-24 18:03egoitzNew Issue
2014-06-24 18:03egoitzAssigned To => eduardo_Argal
2014-06-24 18:03egoitzResolution time => 1405375200
2014-06-24 18:03egoitzTag Attached: Performance
2014-06-25 13:08egoitzIssue cloned0026941
2014-06-25 13:08egoitzRelationship addedrelated to 0026941
2014-11-03 15:01fsoto82Statusnew => scheduled
2014-11-03 15:01fsoto82Assigned Toeduardo_Argal => fsoto82
2014-11-03 15:01fsoto82fix_in_branch => pi
2014-12-24 15:42fsoto82Assigned Tofsoto82 => egoitz
2014-12-24 15:42fsoto82Note Added: 0072823
2014-12-24 15:42fsoto82Statusscheduled => feedback
2015-01-08 09:57egoitzNote Added: 0073343
2015-01-08 09:57egoitzAssigned Toegoitz => fsoto82
2015-01-08 09:57egoitzStatusfeedback => new
2015-01-08 09:57egoitzfix_in_branchpi =>
2015-01-08 09:59egoitzNote Deleted: 0073343
2015-01-21 18:03hgbotCheckin
2015-01-21 18:03hgbotNote Added: 0073697
2015-01-21 18:03hgbotStatusnew => resolved
2015-01-21 18:03hgbotResolutionopen => fixed
2015-01-21 18:03hgbotFixed in SCM revision => http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/531f53c2675d6ca9c1c9a6561ebe975dc1fbb079 [^]
2015-01-21 18:03hgbotCheckin
2015-01-21 18:03hgbotNote Added: 0073698
2015-01-21 18:21umartirenaReview Assigned To => umartirena
2015-01-21 18:21umartirenaNote Added: 0073700
2015-01-21 18:21umartirenaStatusresolved => closed

Notes
(0072823)
fsoto82   
2014-12-24 15:42   
waiting environment with large amount of data
(0073697)
hgbot   
2015-01-21 18:03   
Repository: erp/mods/org.openbravo.module.remittance
Changeset: 531f53c2675d6ca9c1c9a6561ebe975dc1fbb079
Author: Fernando Soto <fernando.soto <at> peoplewalking.com>
Date: Mon Nov 03 21:01:54 2014 -0500
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/531f53c2675d6ca9c1c9a6561ebe975dc1fbb079 [^]

Fixed bug 26932: Performance problems on the settle remitance process

Modifed class CancelReturnRemittance, cancelPayments and returnPayments methods to load the FIN_Payment on the loop execution instead of use a list of payments

---
M src/org/openbravo/module/remittance/ad_forms/CancelReturnRemittance.java
---
(0073698)
hgbot   
2015-01-21 18:03   
Repository: erp/mods/org.openbravo.module.remittance
Changeset: b2f678bfd1ad4d71fed39dc066bb860c5d7db5b7
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Wed Jan 21 18:02:28 2015 +0100
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/b2f678bfd1ad4d71fed39dc066bb860c5d7db5b7 [^]

Related to bug 26932: Some code review

---
M src/org/openbravo/module/remittance/ad_forms/CancelReturnRemittance.java
---
(0073700)
umartirena   
2015-01-21 18:21   
Code Review + Testing OK