Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0026931Openbravo ERP09. Financial managementpublic2014-06-24 17:042014-08-14 04:01
Reporteregoitz 
Assigned TodaniOpenbravo 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR14Q4Fixed in Version 
Merge Request Status
Review Assigned Torafaroda
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket28290
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0026931: Improve the performance of the FIN_Utility.isPaymentConfirmed method
DescriptionImprove the performance of the FIN_Utility.isPaymentConfirmed method.
Steps To ReproduceCheck the code of the method.
The line
String result = (String) CallStoredProcedure.getInstance().call("APRM_ISPAYMENTCONFIRMED", parameters, null);

An extra parameter could be added to not do flush when creating a new connection on the call method.
Proposed SolutionReplace

String result = (String) CallStoredProcedure.getInstance().call("APRM_ISPAYMENTCONFIRMED", parameters, null);


with

String result = (String) CallStoredProcedure.getInstance().call("APRM_ISPAYMENTCONFIRMED", parameters, null, false);
Additional Information
TagsPerformance
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-06-24 17:04egoitzNew Issue
2014-06-24 17:04egoitzAssigned To => AugustoMauch
2014-06-24 17:04egoitzModules => Core
2014-06-24 17:04egoitzOBNetwork customer => Yes
2014-06-24 17:04egoitzSupport ticket => 28290
2014-06-24 17:04egoitzResolution time => 1404943200
2014-06-24 17:04egoitzTriggers an Emergency Pack => No
2014-06-24 17:04egoitzTag Attached: Performance
2014-06-24 17:33egoitzAssigned ToAugustoMauch => jonalegriaesarte
2014-06-24 17:33egoitzCategoryA. Platform => 09. Financial management
2014-06-24 17:34egoitzResolution time1404943200 => 1406757600
2014-06-24 17:34egoitzTarget VersionPR14Q3 => PR14Q4
2014-06-24 17:35egoitzAssigned Tojonalegriaesarte => pramakrishnan
2014-08-11 12:34daniOpenbravoAssigned Topramakrishnan => daniOpenbravo
2014-08-11 12:34daniOpenbravoStatusnew => scheduled
2014-08-13 14:22daniOpenbravoReview Assigned To => rafaroda
2014-08-13 14:40hgbotCheckin
2014-08-13 14:40hgbotNote Added: 0069343
2014-08-13 14:40hgbotStatusscheduled => resolved
2014-08-13 14:40hgbotResolutionopen => fixed
2014-08-13 14:40hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5bcf312da832f643d9b859ae1e753bed830cee84 [^]
2014-08-13 16:06rafarodaNote Added: 0069351
2014-08-13 16:06rafarodaStatusresolved => closed
2014-08-14 04:01hudsonbotCheckin
2014-08-14 04:01hudsonbotNote Added: 0069361

Notes
(0069343)
hgbot   
2014-08-13 14:40   
Repository: erp/devel/pi
Changeset: 5bcf312da832f643d9b859ae1e753bed830cee84
Author: Daniel Ruiz <daniel.ruiz <at> openbravo.com>
Date: Mon Aug 11 12:56:55 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5bcf312da832f643d9b859ae1e753bed830cee84 [^]

Fixed bug 26931:Performance improvement for FIN_Utility.isPaymentConfirmed

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
---
(0069351)
rafaroda   
2014-08-13 16:06   
Code reviewed + checked that remittances can be properly settled: see https://drive.google.com/folderview?id=0B649lz4ZYJcHdE9RNEV1N0lnNGs&usp=sharing [^]
(0069361)
hudsonbot   
2014-08-14 04:01   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/39d7672e843c [^]
Maturity status: Test