Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0026920Retail ModulesWeb POSpublic2014-06-23 16:402014-06-27 14:06
Reportershuehner 
Assigned Tomarvintm 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR14Q3Fixed in VersionRR14Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression levelProduction - QA Approved
Regression date2014-03-06
Regression introduced in release
Regression introduced by commithttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/98aa4a0382357240f319d639d94a0e21f8eb7cef [^]
Triggers an Emergency PackNo
Summary0026920: Unbalanced AdminMode calls on login to webpos
DescriptionSome code used during webpos login process has some unbalanced adminmode calls as can be seen in server log by this warning.

2014-06-23 16:13:18,561 [ajp-localhost%2F127.0.0.1-8809-4] WARN org.openbravo.dal.core.OBContext - Unbalanced calls to setAdminMode and restorePreviousMode. Consider setting the constant OBContext.ADMIN_TRACE_SIZE to a value higher than 0 to debug this situation

Steps To ReproduceLogin to webpos
check server log.
Proposed Solutionusual try/finally block with restorePreviousMode in the finally block.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0025924 closed rafademiguel Precision error in Multicurrency - Exchange Rate 
Attached Filesdiff 26920.diff (5,717) 2014-06-23 16:43
https://issues.openbravo.com/file_download.php?file_id=7016&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-06-23 16:40shuehnerNew Issue
2014-06-23 16:40shuehnerAssigned To => marvintm
2014-06-23 16:40shuehnerOBNetwork customer => No
2014-06-23 16:40shuehnerTriggers an Emergency Pack => No
2014-06-23 16:42shuehnerRegression level => Production - QA Approved
2014-06-23 16:42shuehnerRegression date => 2014-03-06
2014-06-23 16:42shuehnerRegression introduced by commit => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/98aa4a0382357240f319d639d94a0e21f8eb7cef [^]
2014-06-23 16:42shuehnerNote Added: 0068256
2014-06-23 16:42shuehnerProposed Solution updated
2014-06-23 16:43shuehnerFile Added: 26920.diff
2014-06-23 16:44shuehnerNote Added: 0068257
2014-06-23 16:44shuehnerRelationship addedrelated to 0025924
2014-06-23 16:46shuehnerTarget Version => RR14Q3
2014-06-23 22:11hgbotCheckin
2014-06-23 22:11hgbotNote Added: 0068265
2014-06-23 22:11hgbotStatusnew => resolved
2014-06-23 22:11hgbotResolutionopen => fixed
2014-06-23 22:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f705c1784a9295535716a9d21aa8d8d60515cf4a [^]
2014-06-27 14:06marvintmReview Assigned To => marvintm
2014-06-27 14:06marvintmStatusresolved => closed
2014-06-27 14:06marvintmFixed in Version => RR14Q3

Notes
(0068256)
shuehner   
2014-06-23 16:42   
Note:
Technically regression but no visible problem to the user so functionally transparent to user.

However technically wrong and running code with elevated privileges and can make security problem worse if that code has any.
(0068257)
shuehner   
2014-06-23 16:44   
try/catch adds lots of whitespace. Check with 'hg diff -w' after applying to see real change.

Note: just compiled tested to verify the warning dissappears. Zero testing done so far.
(0068265)
hgbot   
2014-06-23 22:11   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f705c1784a9295535716a9d21aa8d8d60515cf4a
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Mon Jun 23 22:10:50 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f705c1784a9295535716a9d21aa8d8d60515cf4a [^]

Fixes issue 26920: added restorePreviousMode() in a try finally block

---
M src/org/openbravo/retail/posterminal/term/Payments.java
---