Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0026914Openbravo ERPA. Platformpublic2014-06-20 15:542014-06-26 15:51
Reporteralostale 
Assigned Toalostale 
PriorityimmediateSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR14Q3 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression levelPre packaging ( pi )
Regression date2014-05-22
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/ee094619e3f0 [^]
Triggers an Emergency PackNo
Summary0026914: Existent Process Definition can fail if they don't have a single grid param
DescriptionOld process definition marked as "Compatibility with Legacy Grids" which first parameter is not a grid fail to execute.

The problem is in the legacy conversion code: it assumes legacy processes are P&E with a single parameter which is a grid. It will fail if:
-There is no grid parameter
-The grid parameter is not the first one in the JSON sent
Steps To Reproduce-Install Copy Store Process module
-Execute the Copy Store process -> the process is not executed, error is logged in openbravo.log:
org.codehaus.jettison.json.JSONException: JSONObject["organization"] is not a JSONObject.
    at org.codehaus.jettison.json.JSONObject.getJSONObject(JSONObject.java:458)
    at org.openbravo.client.application.process.BaseProcessActionHandler.execute(BaseProcessActionHandler.java:129)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 00259953.0PR14Q3 closed AugustoMauch Parameter Windows Phase III 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-06-20 15:54alostaleNew Issue
2014-06-20 15:54alostaleAssigned To => alostale
2014-06-20 15:54alostaleModules => Core
2014-06-20 15:54alostaleOBNetwork customer => No
2014-06-20 15:54alostaleTriggers an Emergency Pack => No
2014-06-20 15:56alostaleRegression level => Pre packaging ( pi )
2014-06-20 15:56alostaleRegression date => 2014-05-22
2014-06-20 15:56alostaleRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/ee094619e3f0 [^]
2014-06-20 15:57alostaleRelationship addedrelated to 0025995
2014-06-20 15:57alostaleReview Assigned To => AugustoMauch
2014-06-20 16:00hgbotCheckin
2014-06-20 16:00hgbotNote Added: 0068230
2014-06-20 16:00hgbotStatusnew => resolved
2014-06-20 16:00hgbotResolutionopen => fixed
2014-06-20 16:00hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d615b5db09cd05e7dc8d1cf6c2d17eae1ee65ccb [^]
2014-06-25 01:35hudsonbotCheckin
2014-06-25 01:35hudsonbotNote Added: 0068290
2014-06-26 15:51AugustoMauchNote Added: 0068356
2014-06-26 15:51AugustoMauchStatusresolved => closed
2014-06-26 15:51AugustoMauchFixed in Version => PR14Q3

Notes
(0068230)
hgbot   
2014-06-20 16:00   
Repository: erp/devel/pi
Changeset: d615b5db09cd05e7dc8d1cf6c2d17eae1ee65ccb
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Jun 20 15:59:37 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d615b5db09cd05e7dc8d1cf6c2d17eae1ee65ccb [^]

fixed bug 26914: Process Definition fail if they don't have a single grid param

  -Do not assume 1st param is a grid
  -Do not assume there is a grid at all
  -Do not do the conversion if there are several grids
  -In case of failure don't do the conversion but continue the flow

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/process/BaseProcessActionHandler.java
---
(0068290)
hudsonbot   
2014-06-25 01:35   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/e78ccbaf0186 [^]
Maturity status: Test
(0068356)
AugustoMauch   
2014-06-26 15:51   
Code reviewed and verified in pi@174b96a6fa01