Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0026833Openbravo ERP07. Sales managementpublic2014-06-11 02:252014-12-30 23:24
Reporterjonalegriaesarte 
Assigned ToAtulOpenbravo 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Topramakrishnan
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0026833: Business partner in goods shipment is editable when generating picking list and the picking can be processed
DescriptionBusiness partner in goods shipment is editable when generating picking list and the picking can be processed
Steps To Reproduce- Create a sales order with one line
- Book it
- Generate picking list
- Goods shipment (draft status). Change the business partner
- Picking list, process it, the system does not show any error
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0037132 closed AtulOpenbravo Should not be possible tor register invoice document related with an order having different business partner 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-06-11 02:25jonalegriaesarteNew Issue
2014-06-11 02:25jonalegriaesarteAssigned To => naiaramartinez
2014-06-11 02:25jonalegriaesarteResolution time => 1405375200
2014-07-23 13:04gorka_gilProjectModules => Openbravo ERP
2014-07-23 13:07jonalegriaesarteModules => Core
2014-07-23 13:07jonalegriaesarteTriggers an Emergency Pack => No
2014-07-23 13:07jonalegriaesarteCategoryWarehouse Picking => 07. Sales management
2014-07-23 13:08jonalegriaesarteAssigned Tonaiaramartinez => AtulOpenbravo
2014-07-23 14:38rafarodaAssigned ToAtulOpenbravo => rafaroda
2014-07-23 14:38rafarodaStatusnew => scheduled
2014-07-23 14:38rafarodafix_in_branch => pi
2014-07-25 14:59jonalegriaesarteNote Added: 0068894
2014-08-26 15:58rafarodaNote Added: 0069765
2014-08-26 22:48hgbotCheckin
2014-08-26 22:48hgbotNote Added: 0069771
2014-08-26 22:48hgbotStatusscheduled => resolved
2014-08-26 22:48hgbotResolutionopen => fixed
2014-08-26 22:48hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7b37c370246d104c226b8c49c56e08ea5be4182c [^]
2014-08-27 06:09hudsonbotCheckin
2014-08-27 06:09hudsonbotNote Added: 0069781
2014-08-27 07:21AtulOpenbravoReview Assigned To => AtulOpenbravo
2014-08-27 07:21AtulOpenbravoNote Added: 0069782
2014-08-27 07:21AtulOpenbravoStatusresolved => closed
2014-08-27 07:21AtulOpenbravoFixed in Version => pi
2014-09-29 12:36jonalegriaesarteNote Added: 0070491
2014-09-29 12:36jonalegriaesarteStatusclosed => new
2014-09-29 12:36jonalegriaesarteResolutionfixed => open
2014-09-29 12:36jonalegriaesarteFixed in Versionpi =>
2014-10-22 13:03AtulOpenbravoAssigned Torafaroda => AtulOpenbravo
2014-10-22 13:03AtulOpenbravoStatusnew => scheduled
2014-10-22 13:05AtulOpenbravoNote Added: 0071118
2014-11-06 10:35AtulOpenbravoReview Assigned ToAtulOpenbravo => pramakrishnan
2014-11-06 10:35AtulOpenbravofix_in_branchpi =>
2014-11-06 13:52hgbotCheckin
2014-11-06 13:52hgbotNote Added: 0071464
2014-11-06 13:52hgbotStatusscheduled => resolved
2014-11-06 13:52hgbotResolutionopen => fixed
2014-11-06 13:52hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/7b37c370246d104c226b8c49c56e08ea5be4182c [^] => http://code.openbravo.com/erp/devel/pi/rev/374efb0bb280db0868bbc37b2e65055f53ad7d56 [^]
2014-11-11 09:57pramakrishnanNote Added: 0071546
2014-11-11 09:57pramakrishnanStatusresolved => closed
2014-12-30 23:24hudsonbotCheckin
2014-12-30 23:24hudsonbotNote Added: 0073022
2017-10-20 10:42maiteRelationship addedrelated to 0037132

Notes
(0068894)
jonalegriaesarte   
2014-07-25 14:59   
Same topic is happening in create lines from functionality. The user can create a header using a business partner, create lines using create lines from, and change the business partner to create new lines using create lines from. In this case, the lines belong to order with different business partner. This is happening in purchase flow (purchase orders and goods receipt). Please analyze this flow also.
(0069765)
rafaroda   
2014-08-26 15:58   
Solution implemented won't allow to change Business Partner field of Goods Shipments or Goods Receipts headers if there are lines (the same solution implemented in Sales and Purchase Orders headers).

Test 6 use cases, 3 for Goods Shipments and 3 for Goods Receipts:

1) Create Goods header > Add lines > Try to change Business Partner: "Cannot change business partner if there are lines" error message displays

2) Create Order header and book it > Create Goods header for same Business Partner as Order > Add lines using Create Lines From and selecting the previous Order > Try to change Business Partner: "Cannot change business partner if there are lines" error message displays

3) Create Order header and book it > Generate Picking List > Go to Goods header created and reactivate if completed > Try to change Business Partner: "Cannot change business partner if there are lines" error message displays
(0069771)
hgbot   
2014-08-26 22:48   
Repository: erp/devel/pi
Changeset: 7b37c370246d104c226b8c49c56e08ea5be4182c
Author: Rafa Roda Palacios <rafa.roda <at> ubiquads.com>
Date: Tue Aug 26 15:47:51 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/7b37c370246d104c226b8c49c56e08ea5be4182c [^]

Fixes issue 26833 Cannot change goods shipments / receipts if there are lines

---
M src-db/database/model/triggers/M_INOUT_CHK_RESTRICTIONS_TRG.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
---
(0069781)
hudsonbot   
2014-08-27 06:09   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b0e6e54d6a80 [^]
Maturity status: Test
(0069782)
AtulOpenbravo   
2014-08-27 07:21   
Verified
(0070491)
jonalegriaesarte   
2014-09-29 12:36   
The issue is already reproducible because the business partner is still editable in create lines from. To reproduce:
- Create two purchase orders with two different vendors
- Create goods receipt using one vender
- Create lines from. Select the line from the order
- Create lines from again. Change the business partner. Select the order from the other vendor
- Complete de receipt
(0071118)
AtulOpenbravo   
2014-10-22 13:05   
Test Plan
- Create two Purchase Orders with two different vendors.
- Create Goods Receipt using one vendor.
- Using Create lines from, select line from the order.
- Using create lines from again, try to change business partner.
- Check that business partner text box is disabled and there is no selection allowed to change the business partner.
- Complete the receipt.
Note:- Same is applicable for Sales Order and Goods Shipment flow.
(0071464)
hgbot   
2014-11-06 13:52   
Repository: erp/devel/pi
Changeset: 374efb0bb280db0868bbc37b2e65055f53ad7d56
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Wed Oct 22 16:24:32 2014 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/374efb0bb280db0868bbc37b2e65055f53ad7d56 [^]

Fixes Issue 26833:BPartner editable while creating lines from in Shipment

In goods receipt / shipment business partner selector is disabled using disable
Field button function and disabled property for input type text.

---
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Shipment.html
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_ShipmentPO.html
---
(0071546)
pramakrishnan   
2014-11-11 09:57   
Code Review + Testing - OK.
(0073022)
hudsonbot   
2014-12-30 23:24   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test