Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0026826 | Openbravo ERP | 01. General setup | public | 2014-06-10 16:55 | 2015-09-01 00:02 |
|
| Reporter | maite | |
| Assigned To | vmromanos | |
| Priority | high | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | 3.0PR15Q1 | Fixed in Version | | |
| Merge Request Status | |
| Review Assigned To | AtulOpenbravo |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0026826: Should not be possible to save Organization header with "Organization type"=Organization and check "Allow period control"= Yes |
| Description | Should not be possible to save Organization header with "Organization type"=Organization and check "Allow period control"= Yes |
| Steps To Reproduce | 1. Run "Initial Organization Setup" process and create organization with type= organization
2. Access Organization window and verify that in FORM mode you are not able to check "allow period control" option
3. Change to GRID mode and realize that you are able to check "allow period control" option, set a calendar and Save record
Same problem with Organization type= Generic |
| Proposed Solution | modulescript is required in order to correct inconsistent organization definition already existent |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | defect | 0027775 | 3.0PR15Q1 | closed | vmromanos | Improve performance in TruncInvoiceDate and Issue26826_Org_AllowPeriodControl module scripts |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2014-06-10 16:55 | maite | New Issue | |
| 2014-06-10 16:55 | maite | Assigned To | => dmiguelez |
| 2014-06-10 16:55 | maite | Modules | => Core |
| 2014-06-10 16:55 | maite | Triggers an Emergency Pack | => No |
| 2014-06-10 16:56 | maite | Regression date | => 2014-08-20 |
| 2014-06-10 16:56 | maite | Assigned To | dmiguelez => jonalegriaesarte |
| 2014-06-10 16:56 | maite | Target Version | => PR14Q3 |
| 2014-06-16 16:40 | jonalegriaesarte | Resolution time | => 1408485600 |
| 2014-06-16 16:40 | jonalegriaesarte | Regression date | 2014-08-20 => |
| 2014-06-16 16:40 | jonalegriaesarte | Assigned To | jonalegriaesarte => pramakrishnan |
| 2014-06-30 12:32 | eduardo_Argal | Target Version | PR14Q3 => PR14Q4 |
| 2014-08-12 12:31 | maite | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=6258#r6258 |
| 2014-08-12 12:31 | maite | Issue Monitored: networkb | |
| 2014-09-29 13:19 | vmromanos | Status | new => scheduled |
| 2014-09-29 13:19 | vmromanos | Assigned To | pramakrishnan => vmromanos |
| 2014-09-29 13:19 | vmromanos | fix_in_branch | => pi |
| 2014-09-29 16:12 | jonalegriaesarte | Target Version | 3.0PR14Q4 => 3.0PR15Q1 |
| 2014-09-30 15:32 | vmromanos | Note Added: 0070559 | |
| 2014-09-30 15:33 | vmromanos | Review Assigned To | => AtulOpenbravo |
| 2014-09-30 15:33 | vmromanos | fix_in_branch | pi => |
| 2014-09-30 15:35 | hgbot | Checkin | |
| 2014-09-30 15:35 | hgbot | Note Added: 0070560 | |
| 2014-09-30 15:35 | hgbot | Status | scheduled => resolved |
| 2014-09-30 15:35 | hgbot | Resolution | open => fixed |
| 2014-09-30 15:35 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/565a19456b2084514aa7123722724b74a15b8b61 [^] |
| 2014-09-30 19:15 | AtulOpenbravo | Note Added: 0070576 | |
| 2014-09-30 19:15 | AtulOpenbravo | Status | resolved => closed |
| 2014-10-06 17:02 | vmromanos | Relationship added | related to 0027775 |
| 2014-12-30 23:22 | hudsonbot | Checkin | |
| 2014-12-30 23:22 | hudsonbot | Note Added: 0072906 | |
| 2015-09-01 00:02 | hudsonbot | Checkin | |
| 2015-09-01 00:02 | hudsonbot | Note Added: 0079935 | |
| 2015-09-01 00:02 | hudsonbot | Checkin | |
| 2015-09-01 00:02 | hudsonbot | Note Added: 0079936 | |
|
Notes |
|
|
|
Test plan module script:
1. Before applying the fix, run the following query in the database:
update ad_org set ISPERIODCONTROLALLOWED = 'Y' where ad_org_id = '0'
This will set the Period Control Allowed flag to Y for the 0 organization, which is a wrong configuration
2. Apply the fix to the environment
3. Run ant smartbuild -Dlocal=no
4. Review the module script log and verify the following info message is shown just after the execution of the Issue26826_Org_AllowPeriodControl module script
Updated 1 organizations.
5. Run the following query and verify ISPERIODCONTROLALLOWED = 'N'
select ISPERIODCONTROLALLOWED from ad_org where ad_org_id = '0'
6. Run again ant smartbuild -Dlocal=no
7. Verify no organization has been updated
Test plan functionality:
As group admin:
1. Run "Initial Organization Setup" process and create organization with type= organization
2. Access Organization window
3. Change to GRID mode and realize that you are able to check "allow period control" option, set a calendar and Save record.
4. An error is shown and the record can't be saved |
|
|
|
(0070560)
|
|
hgbot
|
|
2014-09-30 15:35
|
|
Repository: erp/devel/pi
Changeset: 565a19456b2084514aa7123722724b74a15b8b61
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Sep 30 10:54:06 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/565a19456b2084514aa7123722724b74a15b8b61 [^]
Fixed bug 26826: Allow Period Control invalid for organization type
The Allow Period Control flag is only shown in form view when the organization type is either a legal entity with accounting or a business unit. However the user is able to overwrite the Allow Period Control flag using the grid view, where the display logic doesn't work. This situation can lead the user to set this flag for incorrect organization types, like "Organization" and "Generic".
To fix this issue we have included a validation into the AD_ORG_TRG and we have created a module script that set the Allow Period Control to N when the associated organization type is neither a legal entity with accounting nor a business unit.
---
M src-db/database/model/triggers/AD_ORG_TRG.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
A src-util/modulescript/build/classes/org/openbravo/modulescript/Issue26826OrgAllowPeriodControlData.class
A src-util/modulescript/build/classes/org/openbravo/modulescript/Issue26826_Org_AllowPeriodControl.class
A src-util/modulescript/src/org/openbravo/modulescript/Issue26826_Org_AllowPeriodControl.java
A src-util/modulescript/src/org/openbravo/modulescript/Issue26826_Org_AllowPeriodControl_data.xsql
---
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|