Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0026761Openbravo ERPA. Platformpublic2014-06-02 13:372014-06-10 22:23
Reporterguillermogil 
Assigned Toguillermogil 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0026761: Clean code on parameter windows
DescriptionClean code on parameter windows
Steps To ReproduceN/A
Proposed Solution function actionClick() {
      var hasErrors = false,
          grid, fields, selection, len, allRows, lineNumbers, i, j, record, undef;
      view.messageBar.hide();
      if (view.grid && view.grid.viewGrid) {
        grid = view.grid.viewGrid;
        fields = grid.getFields();
        selection = grid.getSelectedRecords() || [];
        len = selection.length;
        allRows = grid.data.allRows || grid.data.localData || grid.data;
        for (i = 0; i < len; i++) {
          record = grid.getEditedRecord(grid.getRecordIndex(selection[i]));
          for (j = 0; j < fields.length; j++) {
            if (fields[j].required) {
              if (record[fields[j].name] === null || record[fields[j].name] === '' || record[fields[j] === undef]) {
                hasErrors = true;
                if (lineNumbers === undef) {
                  lineNumbers = grid.getRecordIndex(selection[i]).toString();
                } else {
                  lineNumbers = lineNumbers + "," + grid.getRecordIndex(selection[i]).toString();
                }
              }
            }
          }
        }
      }
      if (!hasErrors) {
        if (view.validate()) {
          view.doProcess(this._buttonValue);
        } else {
          // If the messageBar is visible, it means that it has been set due to a custom validation inside view.validate()
          // so we don't want to overwrite it with the generic OBUIAPP_ErrorInFields message
          if (!view.messageBar.isVisible()) {
            view.messageBar.setMessage(isc.OBMessageBar.TYPE_ERROR, null, OB.I18N.getLabel('OBUIAPP_ErrorInFields'));
          }
        }
      } else {
        view.messageBar.setMessage(isc.OBMessageBar.TYPE_ERROR, null, OB.I18N.getLabel('OBUIAPP_FillMandatoryFields') + " " + lineNumbers);
      }
    }

if (view.grid && view.grid.viewGrid) { condition is always false
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-06-02 13:37guillermogilNew Issue
2014-06-02 13:37guillermogilAssigned To => guillermogil
2014-06-02 13:37guillermogilModules => Core
2014-06-02 13:37guillermogilOBNetwork customer => No
2014-06-02 13:37guillermogilTriggers an Emergency Pack => No
2014-06-02 15:29guillermogilIssue Monitored: AugustoMauch
2014-06-02 15:30guillermogilReview Assigned To => AugustoMauch
2014-06-02 15:38hgbotCheckin
2014-06-02 15:38hgbotNote Added: 0067673
2014-06-02 15:38hgbotStatusnew => resolved
2014-06-02 15:38hgbotResolutionopen => fixed
2014-06-02 15:38hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/bc3a8a312111b41aa2ea892d037662651bae1c9c [^]
2014-06-03 17:24AugustoMauchNote Added: 0067718
2014-06-03 17:24AugustoMauchStatusresolved => closed
2014-06-10 22:23hudsonbotCheckin
2014-06-10 22:23hudsonbotNote Added: 0067866

Notes
(0067673)
hgbot   
2014-06-02 15:38   
Repository: erp/devel/pi
Changeset: bc3a8a312111b41aa2ea892d037662651bae1c9c
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Mon Jun 02 15:37:09 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/bc3a8a312111b41aa2ea892d037662651bae1c9c [^]

Fixed issue 26761: Clean code on parameter windows

Removed for loop that look for errors since that functionality is implemented on validators structure

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js
---
(0067718)
AugustoMauch   
2014-06-03 17:24   
Code reviewed and verified in pi@9e9cdee21888
(0067866)
hudsonbot   
2014-06-10 22:23   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/763f16c2ad2e [^]
Maturity status: Test