Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0026748Openbravo ERPA. Platformpublic2014-05-30 13:542014-06-10 22:23
egoitz 
AugustoMauch 
immediatemajoralways
closedfixed 
5
 
3.0PR14Q3 
shankarb
Core
Production - Confirmed Stable
2011-11-09
https://code.openbravo.com/erp/devel/pi/rev/f78b449843e6 [^]
No
0026748: The Popup Text Match Style on the definition of the selector is not properly used
when defining the "Popup Text Match Style" field on the selector definition tab with "starts with" the search is done using the "contains" option.

If you write "abc" on the name of the product selector popup the search is done with
%abc% instead of abc%
-Change the definition of the ProductSimple selector by using the option "starts with" on the "Popup Text Match Style" filed-

-Logout and login
-Acess to the sales invoice window
-Define a header and go to the tabs.
[Define the postgresql log to save all the selects executed and reload postgresql]
-Open the product selector popup
-Write abc on the column name
*See on the postgresql log that the select is executed with the following condition:

 and (lower(product1_.Name) like '%abc%') a

Performance
causes defect 00280453.0PR14Q3.2 closed alostale Selectors are not filtering properly when the popup is open 
Issue History
2014-05-30 13:54egoitzNew Issue
2014-05-30 13:54egoitzAssigned To => AugustoMauch
2014-05-30 13:54egoitzModules => Core
2014-05-30 13:54egoitzResolution time => 1401660000
2014-05-30 13:54egoitzTriggers an Emergency Pack => No
2014-05-30 13:56egoitzTag Attached: Performance
2014-06-02 18:39AugustoMauchIssue Monitored: shankarb
2014-06-02 18:40AugustoMauchReview Assigned To => shankarb
2014-06-02 18:41AugustoMauchRegression level => Production - Confirmed Stable
2014-06-02 18:41AugustoMauchRegression date => 2011-11-09
2014-06-02 18:41AugustoMauchRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/f78b449843e6 [^]
2014-06-02 18:44AugustoMauchNote Added: 0067690
2014-06-02 18:54hgbotCheckin
2014-06-02 18:54hgbotNote Added: 0067691
2014-06-02 18:54hgbotStatusnew => resolved
2014-06-02 18:54hgbotResolutionopen => fixed
2014-06-02 18:54hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5c5013dbfa41371101dfc00dc74a209fd7bd662c [^]
2014-06-04 09:36shankarbNote Added: 0067736
2014-06-04 09:36shankarbStatusresolved => closed
2014-06-04 09:36shankarbFixed in Version => PR14Q3
2014-06-10 22:23hudsonbotCheckin
2014-06-10 22:23hudsonbotNote Added: 0067869
2014-11-03 10:31alostaleRelationship addedcauses 0028045

Notes
(0067690)
AugustoMauch   
2014-06-02 18:44   
Test plan:

Pick a selector (i.e. the ProductSimple selector, used in the Sales Invoice Lines tab). Test the following combinations:
- Without grid configuration
  * pop up text match style = Contains --> Contains
  * pop up text match style = Starts With --> Starts With
- With grid configuration, Text Field Filter Behavior = iStartsWith
  * pop up text match style = Contains --> iStartsWith
  * pop up text match style = Starts With --> iStartsWith
- With grid configuration, Text Field Filter Behavior = iContains
  * pop up text match style = Contains --> iContains
  * pop up text match style = Starts With --> iContains
(0067691)
hgbot   
2014-06-02 18:54   
Repository: erp/devel/pi
Changeset: 5c5013dbfa41371101dfc00dc74a209fd7bd662c
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Jun 02 18:51:26 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5c5013dbfa41371101dfc00dc74a209fd7bd662c [^]

Fixes issue 26748: Selector popup text match style is taken into account

Now, if there is no grid configuration defined, the value set in the selector popup text match style will be used to select the operator that should be used in the criteria.

---
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
---
(0067736)
shankarb   
2014-06-04 09:36   
Code reviewed and verified in pi changeset 5c5013dbfa41.
(0067869)
hudsonbot   
2014-06-10 22:23   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/763f16c2ad2e [^]
Maturity status: Test