Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0026734Openbravo ERPA. Platformpublic2014-05-29 14:232014-06-30 16:45
Reporterplujan 
Assigned Toshankarb 
PriorityurgentSeveritycriticalReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0PR14Q3Fixed in Version3.0PR14Q3 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browserMozilla Firefox
ModulesCore
Support ticket
Regression levelAutomated tests
Regression date2014-05-27
Regression introduced in release
Regression introduced by commithttp://code.openbravo.com/erp/devel/pi/rev/e60dfabc36f951772337c8c10569b25901f79280 [^]
Triggers an Emergency PackNo
Summary0026734: Business Partner selector stops working in Financial Account window
DescriptionWhen opening the business partner selector, it gets stuck and an error is shown in the log. No message is shown to the user though.
Steps To Reproduce1. Enter as F&B Admin with Openbravo user
2. Open Financial Account window
3. Select any record and click the Add Transaction button
4. In the pop up, change the Document value from Received In to Paid out
5. Click the Add Payment In/Out button
6. In the new pop up, click the BP icon to open the selector
7. Select any record and click ok
8. Click again the BP icon to open the selector
9. Close the window using the top-right X button
10. The BP selector is greyed out and following error is shown in the log

2014-05-29 14:14:32,414 [ajp-localhost%2F127.0.0.1-8809-1] ERROR org.openbravo.service.json.DefaultJsonDataService - Data was tried to be fetched from server without pagination. Request was aborted to prevent server performance issues. This is most likely a bug, please contact your System Administrator.
org.openbravo.base.exception.OBException: Data was tried to be fetched from server without pagination. Request was aborted to prevent server performance issues. This is most likely a bug, please contact your System Administrator.
    at org.openbravo.service.json.DefaultJsonDataService.createSetQueryService(DefaultJsonDataService.java:378)
    at org.openbravo.service.json.DefaultJsonDataService.createSetQueryService(DefaultJsonDataService.java:276)
    at org.openbravo.service.json.DefaultJsonDataService.fetch(DefaultJsonDataService.java:114)
    at org.openbravo.service.datasource.DefaultDataSourceService.fetch(DefaultDataSourceService.java:72)
    at org.openbravo.service.datasource.DataSourceServlet.doFetch(DataSourceServlet.java:256)
    at org.openbravo.service.datasource.DataSourceServlet.doPost(DataSourceServlet.java:678)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:637)
    at org.openbravo.base.HttpBaseServlet.serviceInitialized(HttpBaseServlet.java:225)
    at org.openbravo.base.secureApp.HttpSecureAppServlet.service(HttpSecureAppServlet.java:446)
    at org.openbravo.client.kernel.BaseKernelServlet.callServiceInSuper(BaseKernelServlet.java:87)
    at org.openbravo.client.kernel.BaseKernelServlet.service(BaseKernelServlet.java:63)
    at org.openbravo.service.datasource.DataSourceServlet.service(DataSourceServlet.java:138)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.utils.SessionExpirationFilter.doFilter(SessionExpirationFilter.java:66)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.utils.CharsetFilter.doFilter(CharsetFilter.java:35)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.client.kernel.KernelFilter$1.doAction(KernelFilter.java:62)
    at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46)
    at org.openbravo.client.kernel.KernelFilter.doFilter(KernelFilter.java:71)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.dal.core.DalRequestFilter$1.doAction(DalRequestFilter.java:81)
    at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46)
    at org.openbravo.dal.core.DalRequestFilter.doFilter(DalRequestFilter.java:103)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
    at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
    at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
    at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
    at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
    at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:293)
    at org.apache.coyote.ajp.AjpAprProcessor.process(AjpAprProcessor.java:450)
    at org.apache.coyote.ajp.AjpAprProtocol$AjpConnectionHandler.process(AjpAprProtocol.java:399)
    at org.apache.tomcat.util.net.AprEndpoint$Worker.run(AprEndpoint.java:1675)
    at java.lang.Thread.run(Thread.java:701)
Proposed Solution
Additional Information
TagsPerformance
Relationships
related to defect 00266833.0PR14Q3 closed alostale prevent unpaged datasource requests 
related to defect 00266843.0PR14Q3 closed shankarb Alert datasource has no pagination 
related to defect 0028106 closed AugustoMauch Request without pagination in Add Transaction window causes performance problems 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-05-29 14:23plujanNew Issue
2014-05-29 14:23plujanAssigned To => alostale
2014-05-29 14:23plujanWeb browser => Mozilla Firefox
2014-05-29 14:23plujanModules => Core
2014-05-29 14:23plujanTriggers an Emergency Pack => No
2014-05-29 14:25plujanWeb browserMozilla Firefox => Mozilla Firefox
2014-05-29 14:25plujanRegression level => Automated tests
2014-05-29 14:32alostaleRelationship addedhas duplicate 0026683
2014-05-29 14:33alostaleWeb browserMozilla Firefox => Mozilla Firefox
2014-05-29 14:33alostaleRegression date => 2014-05-27
2014-05-29 14:33alostaleRegression introduced by commit => http://code.openbravo.com/erp/devel/pi/rev/e60dfabc36f951772337c8c10569b25901f79280 [^]
2014-05-29 14:41hgbotCheckin
2014-05-29 14:41hgbotNote Added: 0067574
2014-05-29 14:42alostaleRelationship replacedrelated to 0026683
2014-05-29 14:43alostaleWeb browserMozilla Firefox => Mozilla Firefox
2014-05-29 14:43alostaleTarget Version => PR14Q3
2014-05-29 14:44alostaleNote Added: 0067576
2014-05-29 18:42shuehnerIssue Monitored: shuehner
2014-05-29 23:05hudsonbotCheckin
2014-05-29 23:05hudsonbotNote Added: 0067590
2014-06-03 14:49alostaleRelationship addedrelated to 0026684
2014-06-03 14:49alostaleTag Attached: Performance
2014-06-23 12:33shankarbAssigned Toalostale => shankarb
2014-06-26 07:10shankarbReview Assigned To => AugustoMauch
2014-06-26 07:10shankarbWeb browserMozilla Firefox => Mozilla Firefox
2014-06-26 07:10shankarbIssue Monitored: AugustoMauch
2014-06-26 07:13hgbotCheckin
2014-06-26 07:13hgbotNote Added: 0068325
2014-06-26 07:13hgbotStatusnew => resolved
2014-06-26 07:13hgbotResolutionopen => fixed
2014-06-26 07:13hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5f508cf9d5ceac11aa589b47564b78b936c5a8c3 [^]
2014-06-26 17:07AugustoMauchNote Added: 0068366
2014-06-26 17:07AugustoMauchStatusresolved => closed
2014-06-26 17:07AugustoMauchFixed in Version => PR14Q3
2014-06-27 04:06hudsonbotCheckin
2014-06-27 04:06hudsonbotNote Added: 0068382
2014-06-30 09:17hgbotCheckin
2014-06-30 09:17hgbotNote Added: 0068431
2014-06-30 16:45hudsonbotCheckin
2014-06-30 16:45hudsonbotNote Added: 0068455
2014-11-06 09:33caristuRelationship addedrelated to 0028106

Notes
(0067574)
hgbot   
2014-05-29 14:41   
Repository: erp/devel/pi
Changeset: 2ede1e6ee2605a885c2dc71b591c4dcbb08a73a7
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu May 29 14:40:23 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2ede1e6ee2605a885c2dc71b591c4dcbb08a73a7 [^]

related to bug 26734, related to bug 26683

  Do not fail for unpaged slector datasource requests till selectors are properly
  fixed. This is done in order to complete CI

---
M modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java
---
(0067576)
alostale   
2014-05-29 14:44   
The regression is in this cases the request to be aborted. Latest changeset continues with the request even it's unpaged.

The root cause is unpaged requests to selector which should be fixed.
(0067590)
hudsonbot   
2014-05-29 23:05   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/bd7f8b6f935a [^]
Maturity status: Test
(0068325)
hgbot   
2014-06-26 07:13   
Repository: erp/devel/pi
Changeset: 5f508cf9d5ceac11aa589b47564b78b936c5a8c3
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Wed Jun 25 16:27:13 2014 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/5f508cf9d5ceac11aa589b47564b78b936c5a8c3 [^]

Fixes Issue 26734: Business Partner selector stops working in Financial Account window

The data to be fetched in the selector item is not paginated in some cases in 2.50 UI selectors.
In this case, the pagination parameters are set from the client side.
In the cases other than selectors in 2.50 mode, error is thrown from server side.

---
M modules/org.openbravo.service.datasource/web/org.openbravo.service.datasource/js/ob-datasource-utilities.js
M modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java
---
(0068366)
AugustoMauch   
2014-06-26 17:07   
Code reviewed and verified in pi@174b96a6fa01
(0068382)
hudsonbot   
2014-06-27 04:06   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c5640d5a10d4 [^]
Maturity status: Test
(0068431)
hgbot   
2014-06-30 09:17   
Repository: erp/devel/pi
Changeset: d6f7f070b57da7beb2e7f029c1e9b5d82b2e5beb
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Mon Jun 30 12:46:03 2014 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/d6f7f070b57da7beb2e7f029c1e9b5d82b2e5beb [^]

Related to Issue 26734 : Removed unneeded commit as the issue is fixed

---
M modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java
---
(0068455)
hudsonbot   
2014-06-30 16:45   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/3203da27f8cf [^]
Maturity status: Test