Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0026647Openbravo ERPA. Platformpublic2014-05-21 15:312014-05-26 08:15
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR14Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0026647: The merge of the pw3 project will break the API
DescriptionThe API check of CI detects three changes:

 [checkAPI] 53969 ERROR - +++++++++++++++++++++++++++++++++++++++++++++++++++
 [checkAPI] 53972 ERROR - Errors in API model validation
 [checkAPI] 53975 ERROR - +++++++++++++++++++++++++++++++++++++++++++++++++++
 [checkAPI] 53979 ERROR - Check Constraint addition: table: OBUIAPP_PARAMETER - Constraint: OBUIAPP_PARAMETER_NUMCOL_CHK defined as: (NUMCOLUMN >= 1) AND (NUMCOLUMN <= 4)
 [checkAPI] 53982 ERROR -
 [checkAPI]
 [checkAPI] 53987 WARN - +++++++++++++++++++++++++++++++++++++++++++++++++++
 [checkAPI] 53990 WARN - Warnings in API model validation
 [checkAPI] 53994 WARN - +++++++++++++++++++++++++++++++++++++++++++++++++++
 [checkAPI] 53998 WARN - Check Constraint changed: table:AD_TABLE - Constraint: AD_TABLE_CLASSNAME_CHK from condition: [(UPPER((DATAORIGINTYPE)) = 'DATASOURCE') OR (CLASSNAME IS NOT NULL)] to [((UPPER((DATAORIGINTYPE)) = 'DATASOURCE') OR (UPPER((DATAORIGINTYPE)) = 'HQL')) OR (CLASSNAME IS NOT NULL)]
 [checkAPI] 54002 WARN - Check Constraint changed: table:AD_TABLE - Constraint: AD_TABLE_DATASOURCE_CHK from condition: [(UPPER((DATAORIGINTYPE)) = 'TABLE') OR (OBSERDS_DATASOURCE_ID IS NOT NULL)] to [((UPPER((DATAORIGINTYPE)) = 'TABLE') OR (OBSERDS_DATASOURCE_ID IS NOT NULL)) OR (HQLQUERY IS NOT NULL)]
Steps To ReproduceSee: https://ci.openbravo.com/job/try-api/232/consoleFull [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-05-21 15:31AugustoMauchNew Issue
2014-05-21 15:31AugustoMauchAssigned To => AugustoMauch
2014-05-21 15:31AugustoMauchModules => Core
2014-05-21 15:31AugustoMauchOBNetwork customer => No
2014-05-21 15:31AugustoMauchTriggers an Emergency Pack => No
2014-05-21 15:33AugustoMauchNote Added: 0067338
2014-05-22 20:17hgbotCheckin
2014-05-22 20:17hgbotNote Added: 0067387
2014-05-22 20:17hgbotStatusnew => resolved
2014-05-22 20:17hgbotResolutionopen => fixed
2014-05-22 20:17hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/26613dab2ea67871f925d711985624b7e2cf5b70 [^]
2014-05-26 08:15alostaleReview Assigned To => alostale
2014-05-26 08:15alostaleStatusresolved => closed
2014-05-26 08:15alostaleFixed in Version => PR14Q3

Notes
(0067338)
AugustoMauch   
2014-05-21 15:33   
All the three API changes detected are false positives:
- The first one is a constraint on a new column
- The second and the third one are constraints that have been modified making them less restrictive than its original implementation.
(0067387)
hgbot   
2014-05-22 20:17   
Repository: erp/devel/api-checks
Changeset: 26613dab2ea67871f925d711985624b7e2cf5b70
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu May 22 19:39:31 2014 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/26613dab2ea67871f925d711985624b7e2cf5b70 [^]

Fixes issue 26647: The merge of the pw3 project will break the API

---
M model/modules/org.openbravo.client.application/src-db/database/model/tables/OBUIAPP_PARAMETER.xml
M model/src-db/database/model/tables/AD_TABLE.xml
---