Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0026645Openbravo ERPA. Platformpublic2014-05-21 14:132014-10-01 16:43
Reporterumartirena 
Assigned Toalostale 
PriorityimmediateSeveritycriticalReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0MP29.4 
Target VersionFixed in Versionpi 
Merge Request Status
Review Assigned Toshankarb
OBNetwork customerNo
Web browserInternet Explorer
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2013-08-30
Regression introduced in release3.0MP27
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/6b80b8d83087d03767b9fa658b2662923e63ed3b [^]
Triggers an Emergency PackNo
Summary0026645: Tables and Tabledirs are not working in Internet Explorer 7 and 9
DescriptionFields of reference type Tables and Tabledirs are not working in Internet Explorer 7 and 9, at least.
Internet Explorer versions tested:
 - IE7: Not working
 - IE8: Working
 - IE9: Not working
 - Later ones: Not tested

The issue is happening at least since MP 29.4
Steps To Reproduce - Install Internet Explorer 7.
 - Go to Sales Order window.
 - Add new Header.
 - Add new Line.
 - Display Warehouse Rules combo. Realize that is not possible to select any option.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00245743.0MP27 closed shankarb Filter is not working fine in some special cases 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-05-21 14:13umartirenaNew Issue
2014-05-21 14:13umartirenaAssigned To => AugustoMauch
2014-05-21 14:13umartirenaWeb browser => Internet Explorer
2014-05-21 14:13umartirenaModules => Core
2014-05-21 14:13umartirenaOBNetwork customer => No
2014-05-21 14:13umartirenaTriggers an Emergency Pack => No
2014-05-21 17:59adrianromeroNote Added: 0067341
2014-05-21 18:00adrianromeroNote Added: 0067342
2014-05-21 18:14shuehnerIssue Monitored: shuehner
2014-05-21 18:17shuehnerNote Added: 0067344
2014-05-22 16:10dbazWeb browserInternet Explorer => Internet Explorer
2014-05-22 16:10dbazRegression level => Production - Confirmed Stable
2014-05-22 16:10dbazRegression date => 2013-08-30
2014-05-22 16:10dbazRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/6b80b8d83087d03767b9fa658b2662923e63ed3b [^]
2014-05-22 16:10dbazNote Added: 0067370
2014-05-22 16:10dbazAssigned ToAugustoMauch => shankarb
2014-05-22 16:46alostaleAssigned Toshankarb => alostale
2014-05-22 16:47alostaleRelationship addedhas duplicate 0024574
2014-05-22 16:47alostaleRelationship replacedrelated to 0024574
2014-05-22 16:47alostaleReview Assigned To => dbaz
2014-05-22 16:47alostaleWeb browserInternet Explorer => Internet Explorer
2014-05-22 17:10hgbotCheckin
2014-05-22 17:10hgbotNote Added: 0067373
2014-05-22 17:10hgbotCheckin
2014-05-22 17:10hgbotNote Added: 0067375
2014-05-22 17:10hgbotStatusnew => resolved
2014-05-22 17:10hgbotResolutionopen => fixed
2014-05-22 17:10hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c93fd134778b9a502159d24c011ae8ea436325b0 [^]
2014-05-22 17:11alostaleNote Added: 0067376
2014-05-22 18:17shankarbReview Assigned Todbaz => shankarb
2014-05-22 18:17shankarbNote Added: 0067386
2014-05-22 18:17shankarbStatusresolved => closed
2014-05-22 18:17shankarbFixed in Version => pi
2014-05-23 07:24hudsonbotCheckin
2014-05-23 07:24hudsonbotNote Added: 0067394
2014-05-23 07:24hudsonbotCheckin
2014-05-23 07:24hudsonbotNote Added: 0067396
2014-10-01 16:43plujanWeb browserInternet Explorer => Internet Explorer
2014-10-01 16:43plujanRegression introduced in release => 3.0MP27

Notes
(0067341)
adrianromero   
2014-05-21 17:59   
To reproduce the error IE9, itmust be configured to "IE9 Compatibility Mode"

The javascript error raised is:

SCRIPT5007: Unable to get value of the property 'indexOf': object is null or undefined
ISC_Combined.js, line 9145 character 302

The js line is:

_1.pickValue(_4?null:_5)},isc.A.itemClick=function isc_PickListMenu_itemClick(_1){isc.logWarn("itemClick");if(this.allowMultiSelect){this.multiSelectChanged()}else{var _2=this.formItem,_3=_2.getValueFieldName();var _4=_1[_3];if(isc.PickList.emptyStoredValue&&_4==isc.PickList.emptyStoredValue)_4=null;_2.pickValue(_4)}},isc.A.hide=function isc_PickListMenu_hide(_1,_2,_3,_4){var _5=this.isVisible()&&this.isDrawn();this.invokeSuper(isc.PickListMenu,"hide",_1,_2,_3,_4);if(!this.formItem)return;if(_5&&this.showModal)this.formItem.focusInItem();this.formItem.$19g=null;if(_5)this.formItem.$19h();delete this.formItem.$19i;this.clearLastHilite()},isc.A.show=function isc_PickListMenu_show(){var _1=this.isVisible()&&this.isDrawn();this.generateClickOnEnter=true;this.generateClickOnSpace=this.allowMultiSelect;this.bringToFront();this.Super("show",arguments);if(!_1){this.formItem.$19j()}},isc.A.showClickMask=function isc_PickListMenu_showClickMask(){if(!this.clickMaskUp(this.getID())){var _1=this.Super("showClickMask",arguments);if(this.formItem){var _2=this.formItem.form,_3=isc.EH.clickMaskRegistry.find("ID",_1);if(_3.$li)_3.$li=null}}},isc.A.getCellCSSText=function isc_PickListMenu_getCellCSSText(_1,_2,_3){if(this.selection!=null&&_1==this.selection.getSelectedRecord()){var _4=[];if(this.hiliteColor!=null)
(0067342)
adrianromero   
2014-05-21 18:00   
It is supposed that in IE8 if configured to "IE8 Compatibility Mode" it will fail too.
(0067344)
shuehner   
2014-05-21 18:17   
Hi, activating Compatibility View in IE8 (on an XP vm) i can reproduce some js error Using that steps above.
Some JS error is raised as it seems to be calling a function of 'undefined'.
(0067370)
dbaz   
2014-05-22 16:10   
The problem with the issue is that, at least in the case described in "Steps to reproduce", the "value" is a string, and this:

https://code.openbravo.com/erp/devel/pi/rev/6b80b8d83087d03767b9fa658b2662923e63ed3b#l2.34 [^]

fails in IE7.

In fact, at least for this case (where 'value' is a string), the code doesn't make any sense. I don't know if there could be cases where "value" be an array os strings.

Offtopic: Surrounding this code, there are several double quotes " that should be single quotes '
(0067373)
hgbot   
2014-05-22 17:10   
Repository: erp/devel/pi
Changeset: 1cbe9f023742a2bc78a8b1bac1106106924145b2
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu May 22 16:57:06 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1cbe9f023742a2bc78a8b1bac1106106924145b2 [^]

related to issue 26645, related to issue 24574: clean up

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-list.js
---
(0067375)
hgbot   
2014-05-22 17:10   
Repository: erp/devel/pi
Changeset: c93fd134778b9a502159d24c011ae8ea436325b0
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu May 22 17:09:58 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c93fd134778b9a502159d24c011ae8ea436325b0 [^]

fixed bug 26645: can't select element in drop down using IE7

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-list.js
---
(0067376)
alostale   
2014-05-22 17:11   
The problem was caused because in IE7 this Javascript return undefined: 'abc'[0]
whereas in other versions and browsers 'abc'[0] returns 'a'
(0067386)
shankarb   
2014-05-22 18:17   
Code reviewed and verified in pi changeset 45027ccc1bbd.
(0067394)
hudsonbot   
2014-05-23 07:24   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d0b934adf82b [^]
Maturity status: Test
(0067396)
hudsonbot   
2014-05-23 07:24   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d0b934adf82b [^]
Maturity status: Test