Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0026571Openbravo ERPZ. Otherspublic2014-05-16 12:292014-12-30 23:26
Reportermaite 
Assigned ToAtulOpenbravo 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR14Q3Fixed in Version 
Merge Request Status
Review Assigned Torafaroda
OBNetwork customer
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0026571: Error when paying a "cash vat" invoice with total amount lower than related order's amount
DescriptionFollowing error is obtained "percentage: Value (128.54) is larger than the max value: 100"
Steps To Reproduce1. Define your organization as "cash vat"
2. Register Sales Order for cash vat organization and invoice terms= immediate. Ensure that "cash vat" flag is checked in sales order header
3. Add any line setting price=5 and process order
3. Register Sales Invoice using "Create Lines From" process. Edit invoice's line to set price=4 and process invoice
4. Try to pay invoice and realize that following error is raised "percentage: Value (128.54) is larger than the max value: 100"
Proposed Solutionseems that percentage validation is not being performed for total amount but line by line
Additional Information
TagsNo tags attached.
Relationships
related to defect 00274843.0PR14Q4 closed AtulOpenbravo Wrong cash vat lines when payment is automatically created and invoice's amount is higher that order's amount 
related to defect 0033508 closed markmm82 Cannot post a Cash VAT payment that pays more than one invoice, Process failed during execution error is shown 
causes defect 00274603.0PR14Q4 closed AtulOpenbravo Error when posting Payment/Transaction/Reconciliation referencing several cash vat invoices 
causes defect 0028956 closed vmromanos Negative Cash VAT lines created while partially paying an AP/AR Credit Memo 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-05-16 12:29maiteNew Issue
2014-05-16 12:29maiteAssigned To => jonalegriaesarte
2014-05-16 12:29maiteModules => Advanced Payables and Receivables Mngmt
2014-05-16 12:29maiteTriggers an Emergency Pack => No
2014-05-16 12:29maiteProposed Solution updated
2014-05-16 12:30maiteResolution time => 1403215200
2014-05-16 12:30maiteTarget Version => PR14Q3
2014-05-16 12:30maiteIssue Monitored: networkb
2014-05-19 14:33jonalegriaesarteAssigned Tojonalegriaesarte => pramakrishnan
2014-05-21 10:08maitePriorityurgent => immediate
2014-05-27 18:25maiteAssigned Topramakrishnan => AtulOpenbravo
2014-05-27 18:25maiteStatusnew => scheduled
2014-05-27 18:25maitefix_in_branch => pi
2014-05-27 18:28AtulOpenbravoReview Assigned To => rafaroda
2014-05-27 18:28AtulOpenbravofix_in_branchpi =>
2014-05-27 18:30hgbotCheckin
2014-05-27 18:30hgbotNote Added: 0067489
2014-05-27 18:30hgbotStatusscheduled => resolved
2014-05-27 18:30hgbotResolutionopen => fixed
2014-05-27 18:30hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/cbb97a88d93a77eb501c229068804e7bc1cc4990 [^]
2014-05-27 18:30hgbotCheckin
2014-05-27 18:30hgbotNote Added: 0067490
2014-05-27 18:30hgbotCheckin
2014-05-27 18:30hgbotNote Added: 0067491
2014-05-27 19:08rafarodaNote Added: 0067493
2014-05-27 19:08rafarodaStatusresolved => closed
2014-05-28 19:08hudsonbotCheckin
2014-05-28 19:08hudsonbotNote Added: 0067542
2014-05-28 19:08hudsonbotCheckin
2014-05-28 19:08hudsonbotNote Added: 0067543
2014-05-28 19:08hudsonbotCheckin
2014-05-28 19:08hudsonbotNote Added: 0067544
2014-08-26 09:13maiteRelationship addedcauses 0027460
2014-08-27 12:02rafarodaRelationship addedrelated to 0027484
2014-11-28 09:33hgbotCheckin
2014-11-28 09:33hgbotNote Added: 0072096
2014-12-30 23:26hudsonbotCheckin
2014-12-30 23:26hudsonbotNote Added: 0073153
2015-02-17 07:57dmitry_mezentsevRelationship addedcauses 0028956
2016-07-26 11:49aferrazRelationship addedrelated to 0033508

Notes
(0067489)
hgbot   
2014-05-27 18:30   
Repository: erp/devel/pi
Changeset: cbb97a88d93a77eb501c229068804e7bc1cc4990
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Fri May 23 16:41:21 2014 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/cbb97a88d93a77eb501c229068804e7bc1cc4990 [^]

Fixes Issue 26571:Error when paying a "cash vat" invoice with total amount
lower than related order's amount

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src/org/openbravo/erpCommon/utility/CashVATUtil.java
---
(0067490)
hgbot   
2014-05-27 18:30   
Repository: erp/devel/pi
Changeset: f5796fb5b658e22a9b1b50d0ad17369a9c609c0f
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Mon May 26 16:34:59 2014 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/f5796fb5b658e22a9b1b50d0ad17369a9c609c0f [^]

Related To Issue 26571:Posting of Cash Vat lines for multi line schedule line

---
M src/org/openbravo/erpCommon/ad_forms/DocFINFinAccTransaction.java
M src/org/openbravo/erpCommon/ad_forms/DocFINPayment.java
M src/org/openbravo/erpCommon/ad_forms/DocFINReconciliation.java
M src/org/openbravo/erpCommon/ad_forms/DocLineCashVATReady_PaymentTransactionReconciliation.java
---
(0067491)
hgbot   
2014-05-27 18:30   
Repository: erp/devel/pi
Changeset: 10b6743505d4ae2a15e957c0ca505f999752ae38
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue May 27 18:27:11 2014 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/10b6743505d4ae2a15e957c0ca505f999752ae38 [^]

Related To Issue 26571:Reactivation of Payment impact on Cash Vat lines.
Reactivate payment by any option either by Reactivate Or Reactivate
and Delete Lines it will not keep Cash Vat Lines unless the payment is
processed properly.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_ExecutePayment.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
---
(0067493)
rafaroda   
2014-05-27 19:08   
We tested the following cycles:
* For both Sales and Purchase cycles
* with one full and with multiple payments
* Posting Financial Account Transaction + Posting Payment + Posting Reconciliation
* Also tested Reverse Payment

A) INVOICE LINE PRICE = 4 < ORDER LINE = 5
* 2 Cash VAT lines created (one positive and one negative) when full payment

B) INVOICE LINE PRICE = 6 > ORDER LINE = 5

C) INVOICE LINE PRICE = 5 = ORDER LINE = 5

D) INVOICE WITHOUT AN ORDER
(0067542)
hudsonbot   
2014-05-28 19:08   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ede645e45d60 [^]
Maturity status: Test
(0067543)
hudsonbot   
2014-05-28 19:08   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ede645e45d60 [^]
Maturity status: Test
(0067544)
hudsonbot   
2014-05-28 19:08   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ede645e45d60 [^]
Maturity status: Test
(0072096)
hgbot   
2014-11-28 09:33   
Repository: erp/devel/pi
Changeset: 81e131e2af2c79e0bf3cfe2e2d5964ad54b4db2d
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Mon Nov 24 20:20:57 2014 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/81e131e2af2c79e0bf3cfe2e2d5964ad54b4db2d [^]

Fixes Issues 27820:Error when posting Payment/Transaction/Reconciliation
referencing a cash vat invoice linked to several orders

Issue is a regression due to related fix for issue 26571. Cast Vat lines
were posted as many times the no. of orders linked with cash vat invoices.
So now posting is based on the payment details so the relevant cash vat line
associated with it is posted though it is looped as many times as the no. of
orders linked.

---
M src/org/openbravo/erpCommon/ad_forms/DocFINFinAccTransaction.java
M src/org/openbravo/erpCommon/ad_forms/DocFINPayment.java
M src/org/openbravo/erpCommon/ad_forms/DocFINReconciliation.java
M src/org/openbravo/erpCommon/ad_forms/DocLineCashVATReady_PaymentTransactionReconciliation.java
---
(0073153)
hudsonbot   
2014-12-30 23:26   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test