Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0026562Openbravo ERP09. Financial managementpublic2014-05-15 18:422014-12-30 23:22
Reportermaite 
Assigned Tovmromanos 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q1Fixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket28567
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0026562: Improve error message when Unprocessing a Tax Payment with related Payment posted
DescriptionIMPORTANT: Only reproducible in PostgreSQL!

At the moment, error showed is "Document already Posted." but user does not know that document he should unpost is related payment
Steps To Reproduce1. Follow tax payment guide and process record using option "generate payment"=Y: http://wiki.openbravo.com/wiki/Tax_Payment [^]
2. Access Payment in/Payment out window and search for created payment. Ensure that it is posted
3. Navigate to GL Journal window from Tax Payment header and ensure that journal is unpost
4. Try to run "Unprocess" process and realize that error "Document already Posted." is obtained

Error needs to be improved to let user know what Payment should be unposted
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0027753 closed vmromanos Tax Payment Unprocess when Generate Payment = Y - ORACLE 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-05-15 18:42maiteNew Issue
2014-05-15 18:42maiteAssigned To => dmiguelez
2014-05-15 18:42maiteModules => Core
2014-05-15 18:42maiteOBNetwork customer => Yes
2014-05-15 18:42maiteSupport ticket => 28567
2014-05-15 18:42maiteTriggers an Emergency Pack => No
2014-05-15 18:43maiteAssigned Todmiguelez => jonalegriaesarte
2014-05-15 18:44maiteResolution time => 1406844000
2014-05-19 14:33jonalegriaesarteAssigned Tojonalegriaesarte => pramakrishnan
2014-06-16 12:48jonalegriaesarteTarget VersionPR14Q3 => PR14Q4
2014-09-29 16:12jonalegriaesarteTarget Version3.0PR14Q4 => 3.0PR15Q1
2014-10-03 11:45vmromanosAssigned Topramakrishnan => vmromanos
2014-10-03 11:58vmromanosReview Assigned To => vmromanos
2014-10-03 11:58vmromanosNote Added: 0070685
2014-10-03 11:58vmromanosStatusnew => closed
2014-10-03 11:58vmromanosResolutionopen => unable to reproduce
2014-10-03 12:17vmromanosRelationship addedrelated to 0027753
2014-10-03 13:53vmromanosNote Added: 0070694
2014-10-03 13:53vmromanosStatusclosed => new
2014-10-03 13:53vmromanosResolutionunable to reproduce => open
2014-10-03 13:55vmromanosDescription Updatedbug_revision_view_page.php?rev_id=6732#r6732
2014-10-06 11:02vmromanosStatusnew => scheduled
2014-10-06 11:02vmromanosfix_in_branch => pi
2014-10-06 12:13hgbotCheckin
2014-10-06 12:13hgbotNote Added: 0070737
2014-10-06 12:13hgbotStatusscheduled => resolved
2014-10-06 12:13hgbotResolutionopen => fixed
2014-10-06 12:13hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/be7a8c0af5dc08aa6f98fdcda45b0c690ebc79ad [^]
2014-10-13 16:44maiteNote Added: 0070909
2014-10-13 16:44maiteStatusresolved => closed
2014-12-30 23:22hudsonbotCheckin
2014-12-30 23:22hudsonbotNote Added: 0072902

Notes
(0070685)
vmromanos   
2014-10-03 11:58   
I'm able to unprocess the tax payment regardless the payment is still posted.
Not sure whether this situation is a bug or not, but, after a quick code review, it's evident that the process only checks whether the gl journal is posted or not before unprocessing.

IMHO the unprocess should also delete (or at least reactivate) the previously created payment. Probably we should enter a design defect to study this situation
(0070694)
vmromanos   
2014-10-03 13:53   
Reopen: After talking to Maite we have realized that the bug is only reproducible in Postgres.

However we have observed that the behavior in Oracle is totally different to PostgreSQL. It's reported at 0027753
(0070737)
hgbot   
2014-10-06 12:13   
Repository: erp/devel/pi
Changeset: be7a8c0af5dc08aa6f98fdcda45b0c690ebc79ad
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Oct 06 11:25:38 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/be7a8c0af5dc08aa6f98fdcda45b0c690ebc79ad [^]

Fixed bug 26562: Error message Unprocessing TaxPayment related to posted Payment

Improved the error message shown when unprocessing a Tax Payment related to a posted Payment.
Besides, the Payment field is shown when the Tax Payment is related to a payment to make it easier to identify the payment.
Finally the "Generate Payment" field is always shown because it had no sense to hide it when the record was processed.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/model/functions/APRM_TAX_PAYMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
---
(0070909)
maite   
2014-10-13 16:44   
verified
(0072902)
hudsonbot   
2014-12-30 23:22   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test