Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0026555Openbravo ERPA. Platformpublic2014-05-15 11:532014-10-01 16:39
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PriorityimmediateSeveritycriticalReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionpiFixed in Version3.0PR14Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression levelProduction - QA Approved
Regression date2014-01-29
Regression introduced in release3.0PR14Q2
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/fe1b26c8cee8 [^]
Triggers an Emergency PackNo
Summary0026555: Problem in initialization of CanvasItem when a new record is created in grid mode.
DescriptionProblem in initialization of CanvasItem when a new record is created in grid mode. When a record is created, the CanvasItem column is being initialized to null, even if it has a default value.
Steps To ReproduceAs F&B Admin:
- Open the Return to Vendor window
- Create a new record in grid view. Check that the Total Gross Amount field has been initialized to an empty string, it should have been initialized to '0.00'. This field is a CanvasItem.
- Try so save the record. You can't because the Total Gross Amount has not been initialized, and you can set its value manually because it is read only.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0043784 closed cberner OBMultiSelectorItem parameter values are not saved in the form 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-05-15 11:53AugustoMauchNew Issue
2014-05-15 11:53AugustoMauchAssigned To => AugustoMauch
2014-05-15 11:53AugustoMauchModules => Core
2014-05-15 11:53AugustoMauchOBNetwork customer => No
2014-05-15 11:53AugustoMauchTriggers an Emergency Pack => No
2014-05-15 11:54AugustoMauchNote Added: 0067140
2014-05-15 11:55AugustoMauchRegression level => Production - QA Approved
2014-05-15 11:55AugustoMauchRegression date => 2014-01-29
2014-05-15 11:55AugustoMauchRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/fe1b26c8cee8 [^]
2014-05-15 12:14AugustoMauchIssue Monitored: alostale
2014-05-15 12:15AugustoMauchReview Assigned To => alostale
2014-05-15 12:19hgbotCheckin
2014-05-15 12:19hgbotNote Added: 0067143
2014-05-15 12:19hgbotStatusnew => resolved
2014-05-15 12:19hgbotResolutionopen => fixed
2014-05-15 12:19hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d6181edcf7b39d855f43cca8678991ff954bf2be [^]
2014-05-16 07:19hudsonbotCheckin
2014-05-16 07:19hudsonbotNote Added: 0067188
2014-05-16 09:41alostaleNote Added: 0067203
2014-05-16 09:41alostaleStatusresolved => closed
2014-05-16 09:41alostaleFixed in Version => PR14Q3
2014-10-01 16:39plujanRegression introduced in release => 3.0PR14Q2
2020-04-21 12:28caristuRelationship addedrelated to 0043784

Notes
(0067140)
AugustoMauch   
2014-05-15 11:54   
There are two workarounds for this issue:
- Create the record in form view
- Hide the column in the grid view
(0067143)
hgbot   
2014-05-15 12:19   
Repository: erp/devel/pi
Changeset: d6181edcf7b39d855f43cca8678991ff954bf2be
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu May 15 12:11:43 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d6181edcf7b39d855f43cca8678991ff954bf2be [^]

Fixes issue 26555: Bad initialization of CanvasItem in grid view.

The problem was the following:
- The shouldSaveValue of the CanvasItems have always been false, but until this Smartclient upgrade this was not enforced.
- After the upgrade of Smartclient the shouldSaveValue is actually being enforced, the value returned from the FIC for this column is not being saved in the form values.

To fix this, the shouldSaveValue of the CanvasItem class has been set to true. The only consequence of this change is that the value of the CanvasItems should now be stored in the form values, see http://www.smartclient.com/docs/9.1/a/b/c/go.html#attr..CanvasItem.shouldSaveValue [^]

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-canvas.js
---
(0067188)
hudsonbot   
2014-05-16 07:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/649d0b7eba54 [^]
Maturity status: Test
(0067203)
alostale   
2014-05-16 09:41   
Code reviewed
Tested creating records in Return to Vendor:
-In grid view with Total Gross Amount field shown (this case was failing before)
-In grid view with Total Gross Amount field hidden
-In form view