Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0026548Openbravo ERPA. Platformpublic2014-05-14 16:342014-05-26 09:07
egoitz 
guillermogil 
urgentmajorhave not tried
closedfixed 
5
 
3.0PR14Q33.0PR14Q3 
alostale
Core
No
0026548: Slow flush after a fetch to a datasource.
When doing a fetch a flush is exeucted at the end of the transaction. There fetch does not change any thing so before doing the flush a clear should be done to ensure that the performance of flush is not affected by objects loaded in memory.


When calling the FIC with NEW or SETSESSION commands also the clear should be done
-Check the code
Performance
related to defect 0036601 closed alostale unneeded flush with no entities on every fetch 
Issue History
2014-05-14 16:34egoitzNew Issue
2014-05-14 16:34egoitzAssigned To => alostale
2014-05-14 16:34egoitzModules => Core
2014-05-14 16:34egoitzTriggers an Emergency Pack => No
2014-05-14 16:34egoitzTag Attached: Performance
2014-05-19 14:36jonalegriaesarteResolution time => 1402696800
2014-05-19 14:36jonalegriaesarteFixed in Version => PR14Q3
2014-05-20 15:31alostaleFixed in VersionPR14Q3 =>
2014-05-20 15:31alostaleTarget Version => PR14Q3
2014-05-21 08:18alostaleAssigned Toalostale => guillermogil
2014-05-21 11:33guillermogilIssue Monitored: alostale
2014-05-21 11:34guillermogilReview Assigned To => alostale
2014-05-21 12:44hgbotCheckin
2014-05-21 12:44hgbotNote Added: 0067336
2014-05-21 12:44hgbotStatusnew => resolved
2014-05-21 12:44hgbotResolutionopen => fixed
2014-05-21 12:44hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f596f4f931868404f43a984dc85c41ed720a59f8 [^]
2014-05-21 13:02hgbotCheckin
2014-05-21 13:02hgbotNote Added: 0067337
2014-05-22 17:42hudsonbotCheckin
2014-05-22 17:42hudsonbotNote Added: 0067377
2014-05-22 17:42hudsonbotCheckin
2014-05-22 17:42hudsonbotNote Added: 0067378
2014-05-26 09:05guillermogilNote Added: 0067431
2014-05-26 09:07alostaleNote Added: 0067433
2014-05-26 09:07alostaleStatusresolved => closed
2014-05-26 09:07alostaleFixed in Version => PR14Q3
2017-08-04 10:05alostaleRelationship addedrelated to 0036601

Notes
(0067336)
hgbot   
2014-05-21 12:44   
Repository: erp/devel/pi
Changeset: f596f4f931868404f43a984dc85c41ed720a59f8
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Wed May 21 12:44:21 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f596f4f931868404f43a984dc85c41ed720a59f8 [^]

Fixed issue 26548: Slow flush after a fetch to a datasource

Session cleared on FETCH and FIC in order to prevent slow flushes

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
M modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java
---
(0067337)
hgbot   
2014-05-21 13:02   
Repository: erp/devel/pi
Changeset: e3a5d2382b2d02b39e73d55016178dd1e1cc393a
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Wed May 21 13:01:40 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e3a5d2382b2d02b39e73d55016178dd1e1cc393a [^]

Related to issue 26548: Slow flush after a fetch to a datasource

Modified cleared session on FIC

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
---
(0067377)
hudsonbot   
2014-05-22 17:42   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1f80725ff7f4 [^]
Maturity status: Test
(0067378)
hudsonbot   
2014-05-22 17:42   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1f80725ff7f4 [^]
Maturity status: Test
(0067431)
guillermogil   
2014-05-26 09:05   
Performance tests:

FETCH
Around a 10% of improvement - Open a window

FIC
After the execution of FICAllHeaderTabs.jmx average time has gone from 210ms to 200ms.
(0067433)
alostale   
2014-05-26 09:07   
code reviewed

tested ensuring it doesn't interfere with usage audit which should do insertions in fetch case