Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0026505Openbravo ERPA. Platformpublic2014-05-09 14:032014-10-01 16:36
Reporterguillermogil 
Assigned Toguillermogil 
PriorityimmediateSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR14Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression levelProduction - QA Approved
Regression date2014-01-07
Regression introduced in release3.0PR14Q2
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/46ec5ec2839da79ae27a5225c105c85ecde1cf6a [^]
Triggers an Emergency PackNo
Summary0026505: Reference AD_Language does not show any results on its drop-down while filtering
DescriptionReference AD_Language does not show any results on its drop-down while filtering
Steps To Reproduce* Go to Country and Region window
* Enter any value on Language filter

Its drop-down does not show any data
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00251823.0PR14Q2 closed alostale Query in org drop down in the list field is having bad performance 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-05-09 14:03guillermogilNew Issue
2014-05-09 14:03guillermogilAssigned To => guillermogil
2014-05-09 14:03guillermogilWeb browser => Google Chrome
2014-05-09 14:03guillermogilModules => Core
2014-05-09 14:03guillermogilTriggers an Emergency Pack => No
2014-05-09 14:17guillermogilWeb browserGoogle Chrome => Google Chrome
2014-05-09 14:17guillermogilRegression level => Production - QA Approved
2014-05-09 14:17guillermogilSummaryLanguage filter dropdown on Country window does not show any results => Reference AD_Language does not show any results on it's drop-down while filtering
2014-05-09 14:17guillermogilDescription Updatedbug_revision_view_page.php?rev_id=5795#r5795
2014-05-09 14:38guillermogilWeb browserGoogle Chrome => Google Chrome
2014-05-09 14:38guillermogilSummaryReference AD_Language does not show any results on it's drop-down while filtering => Reference AD_Language does not show any results on its drop-down while filtering
2014-05-09 14:38guillermogilDescription Updatedbug_revision_view_page.php?rev_id=5800#r5800
2014-05-09 14:38guillermogilSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=5802#r5802
2014-05-12 08:21alostaleWeb browserGoogle Chrome => Google Chrome
2014-05-12 08:21alostaleSeveritycritical => major
2014-05-12 12:12guillermogilNote Added: 0067087
2014-05-12 12:38guillermogilWeb browserGoogle Chrome => Google Chrome
2014-05-12 12:38guillermogilRegression date => 2014-01-07
2014-05-12 12:38guillermogilRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/46ec5ec2839da79ae27a5225c105c85ecde1cf6a [^]
2014-05-12 12:38guillermogilRelationship addedrelated to 0025182
2014-05-12 13:36guillermogilIssue Monitored: alostale
2014-05-12 13:36guillermogilReview Assigned To => alostale
2014-05-12 13:36guillermogilWeb browserGoogle Chrome => Google Chrome
2014-05-12 13:37hgbotCheckin
2014-05-12 13:37hgbotNote Added: 0067089
2014-05-12 13:37hgbotStatusnew => resolved
2014-05-12 13:37hgbotResolutionopen => fixed
2014-05-12 13:37hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b96c7d42fc3eae61d6267d76873b42c288df4c2c [^]
2014-05-12 14:03guillermogilStatusresolved => new
2014-05-12 14:03guillermogilResolutionfixed => open
2014-05-12 14:03guillermogilWeb browserGoogle Chrome => Google Chrome
2014-05-12 14:03guillermogilSeveritymajor => minor
2014-05-12 14:03guillermogilStatusnew => scheduled
2014-05-12 14:03guillermogilStatusscheduled => resolved
2014-05-12 14:03guillermogilResolutionopen => fixed
2014-05-12 18:30hgbotCheckin
2014-05-12 18:30hgbotNote Added: 0067101
2014-05-15 17:34hudsonbotCheckin
2014-05-15 17:34hudsonbotNote Added: 0067160
2014-05-15 17:34hudsonbotCheckin
2014-05-15 17:34hudsonbotNote Added: 0067162
2014-05-16 10:02alostaleNote Added: 0067204
2014-05-16 10:02alostaleStatusresolved => closed
2014-05-16 10:02alostaleFixed in Version => PR14Q3
2014-10-01 16:36plujanWeb browserGoogle Chrome => Google Chrome
2014-10-01 16:36plujanRegression introduced in release => 3.0PR14Q2

Notes
(0067087)
guillermogil   
2014-05-12 12:12   
Problem is in nullable properties that are part of the identifier of a FK.

In this case the query is

select 1 from Country as e where e.language = me and e.organization.id in ('E443A31992CB4635AFCAEABE7183CE85', '546A28CFAA824199866BDB1D078CA386', '0', 'DC206C91AA6A4897B44DA897936E0EC3', '7BABA5FF80494CAFA54DEBD22EC46F01', 'BAE22373FEBE4CCCA24517E23F0C8A48', '19404EAD144C49A0AF37D54377CF452D', 'B843C30461EA4501935CB1D125C9C25A', '2E60544D37534C0B89E765FE29BC0B43') and e.client.id in ('23C59575B9CF467C9620760EB255B389', '0')

Left join should be used instead:

select 1 from Country as e left join e.language as es where es = me and e.organization.id in ('E443A31992CB4635AFCAEABE7183CE85', '546A28CFAA824199866BDB1D078CA386', '0', 'DC206C91AA6A4897B44DA897936E0EC3', '7BABA5FF80494CAFA54DEBD22EC46F01', 'BAE22373FEBE4CCCA24517E23F0C8A48', '19404EAD144C49A0AF37D54377CF452D', 'B843C30461EA4501935CB1D125C9C25A', '2E60544D37534C0B89E765FE29BC0B43') and e.client.id in ('23C59575B9CF467C9620760EB255B389', '0')
(0067089)
hgbot   
2014-05-12 13:37   
Repository: erp/devel/pi
Changeset: b96c7d42fc3eae61d6267d76873b42c288df4c2c
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Mon May 12 13:37:00 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b96c7d42fc3eae61d6267d76873b42c288df4c2c [^]

Fixed issue 26505:Reference AD_Language does not show any results

Use left join instead an inner join if the property allows null values.

---
M modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java
---
(0067101)
hgbot   
2014-05-12 18:30   
Repository: erp/devel/pi
Changeset: 592598efcef07d0a647848828a4d85afb4b32dec
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Mon May 12 18:29:49 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/592598efcef07d0a647848828a4d85afb4b32dec [^]

Related to issue 26505:AD_Language does not show any results

If the path contains a field separator use the previous query

---
M modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java
---
(0067160)
hudsonbot   
2014-05-15 17:34   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8d6658b982c0 [^]
Maturity status: Test
(0067162)
hudsonbot   
2014-05-15 17:34   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8d6658b982c0 [^]
Maturity status: Test
(0067204)
alostale   
2014-05-16 10:02   
Code reviewed

Verifications:

-Languages appear in the drop down list for filtering and query is correctly created (left join)
-Other drop down lists for filtering are not affected (query is the same) in case the properties part of the identifier are mandatory
-Queries for the standard datasource continue being the same as before the fix