Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0026488Openbravo ERP07. Sales managementpublic2014-05-08 09:472014-10-01 16:35
Reportergorkaion 
Assigned ToSandrahuguet 
PriorityimmediateSeveritycriticalReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionGentoo
Product Version 
Target Version3.0PR14Q2Fixed in Version 
Merge Request Status
Review Assigned Togorkaion
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression levelProduction - QA Approved
Regression date2014-02-27
Regression introduced in release3.0PR14Q2
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/67b8e22d232e [^]
Triggers an Emergency PackNo
Summary0026488: Return From Customer pick/edit lines not working in Oracle
DescriptionUsing Oracle the Pick/Edit lines Pick and Execute button of Return from Customer window is not working.

Log with the error:

51339182 [http-8080-4] ERROR org.hibernate.util.JDBCExceptionReporter - ORA-00972: identifier is too long

51339199 [http-8080-4] ERROR org.openbravo.service.datasource.DataSourceServlet - could not execute query
org.hibernate.exception.SQLGrammarException: could not execute query
    at org.hibernate.exception.SQLStateConverter.convert(SQLStateConverter.java:92)
    at org.hibernate.exception.JDBCExceptionHelper.convert(JDBCExceptionHelper.java:66)
    at org.hibernate.loader.Loader.doList(Loader.java:2536)
    at org.hibernate.loader.Loader.listIgnoreQueryCache(Loader.java:2276)
    at org.hibernate.loader.Loader.list(Loader.java:2271)
    at org.hibernate.loader.custom.CustomLoader.list(CustomLoader.java:316)
    at org.hibernate.impl.SessionImpl.listCustomQuery(SessionImpl.java:1842)
    at org.hibernate.impl.AbstractSessionImpl.list(AbstractSessionImpl.java:165)
    at org.hibernate.impl.SQLQueryImpl.list(SQLQueryImpl.java:157)
    at org.openbravo.common.datasource.ReturnFromCustomerPickEditLineDatasource.getData(ReturnFromCustomerPickEditLineDatasource.java:106)
    at org.openbravo.common.datasource.ReturnFromCustomerPickEditLineDatasource.fetchJSONObject(ReturnFromCustomerPickEditLineDatasource.java:81)
    at org.openbravo.common.datasource.ReturnFromCustomerPickEditLineDatasource.fetch(ReturnFromCustomerPickEditLineDatasource.java:41)
Steps To ReproduceCreate a Return from Customer header
Check that there are Delivered Sales orders for the Customer
Open the Pick/Edit lines, no results shown.
Clean the filter, still no results.
Proposed SolutionFix the Query to be Oracle compatible.
* m_attributesetinstance_identifier by m_attributesetinstance_iden
* Change "OFFSET" "LIMIT" postgresql notation by ROWNUM filtering in case Oracle is used.

Additional Information
TagsNo tags attached.
Relationships
related to feature request 0025861 closed Sandrahuguet Create a new return from customer pick and edit with manual datasource 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-05-08 09:47gorkaionNew Issue
2014-05-08 09:47gorkaionAssigned To => Sandrahuguet
2014-05-08 09:47gorkaionModules => Core
2014-05-08 09:47gorkaionOBNetwork customer => No
2014-05-08 09:47gorkaionTriggers an Emergency Pack => No
2014-05-08 09:52gorkaionReview Assigned To => gorkaion
2014-05-08 09:52gorkaionRegression level => Production - QA Approved
2014-05-08 09:52gorkaionRegression date => 2014-02-27
2014-05-08 09:52gorkaionRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/67b8e22d232e [^]
2014-05-08 10:05gorkaionRelationship addedrelated to 0025861
2014-05-08 12:46hgbotCheckin
2014-05-08 12:46hgbotNote Added: 0067022
2014-05-08 12:46hgbotStatusnew => resolved
2014-05-08 12:46hgbotResolutionopen => fixed
2014-05-08 12:46hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6a127be95605feb6ab8b98fba582ad43ce73aaf6 [^]
2014-05-08 16:47gorkaionNote Added: 0067029
2014-05-08 16:47gorkaionStatusresolved => closed
2014-05-09 16:21hudsonbotCheckin
2014-05-09 16:21hudsonbotNote Added: 0067074
2014-10-01 16:35plujanRegression introduced in release => 3.0PR14Q2

Notes
(0067022)
hgbot   
2014-05-08 12:46   
Repository: erp/devel/pi
Changeset: 6a127be95605feb6ab8b98fba582ad43ce73aaf6
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Thu May 08 12:46:08 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6a127be95605feb6ab8b98fba582ad43ce73aaf6 [^]

Fixed bug 26488 Return From Customer pick/edit lines not working in Oracle

---
M src/org/openbravo/common/datasource/ReturnFromCustomerPickEditLineDatasource.java
M src/org/openbravo/common/datasource/ReturnFromCustomerPickEditLineRow.java
---
(0067029)
gorkaion   
2014-05-08 16:47   
Code reviewed and tested
(0067074)
hudsonbot   
2014-05-09 16:21   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/e8c0af2263a0 [^]
Maturity status: Test