Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0026469Retail ModulesWeb POSpublic2014-05-06 11:082014-10-13 13:20
Reporterjecharri 
Assigned Tomigueldejuana 
PriorityimmediateSeveritycriticalReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR14Q2.1Fixed in VersionRR14Q2.1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression levelProduction - QA Approved
Regression date
Regression introduced in releaseRR14Q2
Regression introduced by commit
Triggers an Emergency PackNo
Summary0026469: Cash up is not working fine if you have a payment method with checkbox automated movement unchecked
DescriptionCash up is not working fine if you have a payment method with checkbox automated movement unchecked
Steps To Reproduce-With out sample data create a terminal to org Vall Blanca store
-add credit card payment type
-go to payment method and uncheck "Automated movement to other account"

after that:
-go to web pos
-make a sale
-go to cash up and execute

You will see that Web POS is keeping all the money in the financial account when it should move all the money to back office financial account
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0025569RMP31 closed malsasua Impossible to do a cash up 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-05-06 11:08jecharriNew Issue
2014-05-06 11:08jecharriAssigned To => malsasua
2014-05-06 11:08jecharriTriggers an Emergency Pack => No
2014-05-06 11:10jecharriRegression level => Packaging and release
2014-05-06 11:10jecharriSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=5783#r5783
2014-05-07 14:45shuehnerTarget VersionRR14Q2 => RR14Q2.1
2014-05-08 19:25dmitry_mezentsevRelationship addedrelated to 0025569
2014-05-08 21:30mtaalNote Added: 0067032
2014-05-09 11:30malsasuaAssigned Tomalsasua => Orekaria
2014-05-15 16:08migueldejuanaStatusnew => scheduled
2014-05-15 16:08migueldejuanaAssigned ToOrekaria => migueldejuana
2014-05-15 16:08migueldejuanafix_in_branch => pi
2014-05-15 16:08migueldejuanaNote Added: 0067156
2014-05-15 16:08migueldejuanaStatusscheduled => resolved
2014-05-15 16:08migueldejuanaFixed in Version => RR14Q2.1
2014-05-15 16:08migueldejuanaResolutionopen => fixed
2014-05-16 11:56marvintmReview Assigned To => marvintm
2014-05-16 11:56marvintmStatusresolved => closed
2014-10-01 16:32plujanRegression levelPackaging and release => Production - QA Approved
2014-10-01 16:32plujanRegression introduced in release => RR14Q2
2014-10-01 16:32plujanfix_in_branchpi =>
2014-10-13 13:20hgbotCheckin
2014-10-13 13:20hgbotNote Added: 0070904

Notes
(0067032)
mtaal   
2014-05-08 21:30   
Remark by MAL:

I have checking the issue. It was generated by a synchronization problem.
In one function was added a called to OB.Dal.find function, then this function was changed to asynchronous

The OB.Dal.find was added In the line https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/4e0e6c31d0a1/web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js#l53 [^]

and then, the line
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/4e0e6c31d0a1/web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js#l102 [^]

is executed before than the variable this.get('paymentList') is populated (in the line
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/4e0e6c31d0a1/web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js#l87 [^])

and the setIgnoreStep3 function uses this variable, and it was empty.

The fix is to call to setIgnoreStep3 function after that the variable is populated.
(0067156)
migueldejuana   
2014-05-15 16:08   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 007e96442b7388fbb0bc9c32c05ee1dac489dbd8
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu May 15 16:01:28 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/007e96442b7388fbb0bc9c32c05ee1dac489dbd8 [^] [^]

Fixed issue 0026470: The exchange of the sum of units is different from the sum of the individually exchanged units

---
M web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js
---
(0070904)
hgbot   
2014-10-13 13:20   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d2f5112566804a30c92fd0961a587b868f65758e
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Oct 13 13:19:48 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d2f5112566804a30c92fd0961a587b868f65758e [^]

Related to issue 26469 and related to issue 26470: It seems we include removed and unnecesary code in one merge.

We remove calls to setIgnoreStep3 and convertExpected because we already do this in the callback. Those calls need to be in the callback because after cashup refactor(saving cashup info in localStorage) we do an asynchronius call.

---
M web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js
---