Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0026389Retail ModulesWeb POSpublic2014-04-25 14:562014-05-30 10:57
Reporterjecharri 
Assigned Toszapata 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR14Q3Fixed in VersionRR14Q3 
Merge Request Status
Review Assigned ToOrekaria
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0026389: Best Deal case has performance problems with Combos
DescriptionBest Deal case has performance problems with Combos
Steps To Reproduce-If you have configured some Combos and discounts
-Do some sales

You will see that the algorithm can take few seconds to calculate the result
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff retail.discounts.combo.diff (2,298) 2014-05-06 10:24
https://issues.openbravo.com/file_download.php?file_id=6901&type=bug
diff retail.discounts.bestdeal.diff (2,219) 2014-05-06 10:25
https://issues.openbravo.com/file_download.php?file_id=6902&type=bug
diff PERFdiscounts.combo.diff (4,732) 2014-05-16 09:38
https://issues.openbravo.com/file_download.php?file_id=6928&type=bug
diff retail.discounts.bestdeal_2.diff (7,126) 2014-05-16 09:39
https://issues.openbravo.com/file_download.php?file_id=6929&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-04-25 14:56jecharriNew Issue
2014-04-25 14:56jecharriAssigned To => malsasua
2014-04-25 14:56jecharriResolution time => 1398895200
2014-04-25 14:56jecharriTriggers an Emergency Pack => No
2014-04-26 22:29egoitzIssue Monitored: networkb
2014-04-26 22:29egoitzIssue Monitored: egoitz
2014-05-06 10:24marvintmFile Added: retail.discounts.combo.diff
2014-05-06 10:25marvintmFile Added: retail.discounts.bestdeal.diff
2014-05-06 14:36hgbotCheckin
2014-05-06 14:36hgbotNote Added: 0066841
2014-05-06 14:36hgbotStatusnew => resolved
2014-05-06 14:36hgbotResolutionopen => fixed
2014-05-06 14:36hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ac5fb91c541c218b5ace819418834d5e6d311452 [^]
2014-05-06 14:45hgbotCheckin
2014-05-06 14:45hgbotNote Added: 0066842
2014-05-06 14:45hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ac5fb91c541c218b5ace819418834d5e6d311452 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bestdeal/rev/a385edb70dbd94834a9a060621452f935b4afc29 [^]
2014-05-06 17:24szapataNote Added: 0066853
2014-05-06 17:24szapataStatusresolved => new
2014-05-06 17:24szapataResolutionfixed => open
2014-05-06 17:27szapataNote Edited: 0066853bug_revision_view_page.php?bugnote_id=0066853#r5785
2014-05-06 17:38hgbotCheckin
2014-05-06 17:38hgbotNote Added: 0066856
2014-05-06 17:38hgbotStatusnew => resolved
2014-05-06 17:38hgbotResolutionopen => fixed
2014-05-06 17:38hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bestdeal/rev/a385edb70dbd94834a9a060621452f935b4afc29 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.cds/rev/b174f9b3459d7a01585fab83c3399ab1e568c5f4 [^]
2014-05-09 16:01hgbotCheckin
2014-05-09 16:01hgbotNote Added: 0067046
2014-05-09 16:01hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.cds/rev/b174f9b3459d7a01585fab83c3399ab1e568c5f4 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.unstablenetworks/rev/ac5fb91c541c218b5ace819418834d5e6d311452 [^]
2014-05-16 09:37jecharriStatusresolved => new
2014-05-16 09:37jecharriResolutionfixed => open
2014-05-16 09:38jecharriFile Added: PERFdiscounts.combo.diff
2014-05-16 09:39jecharriFile Added: retail.discounts.bestdeal_2.diff
2014-05-28 09:30marvintmStatusnew => scheduled
2014-05-28 09:30marvintmAssigned Tomalsasua => szapata
2014-05-28 09:30marvintmfix_in_branch => pi
2014-05-28 09:30marvintmStatusscheduled => resolved
2014-05-28 09:30marvintmFixed in Version => RR14Q3
2014-05-28 09:30marvintmResolutionopen => fixed
2014-05-28 09:32marvintmNote Added: 0067507
2014-05-30 10:57OrekariaReview Assigned To => Orekaria
2014-05-30 10:57OrekariaNote Added: 0067606
2014-05-30 10:57OrekariaStatusresolved => closed

Notes
(0066841)
hgbot   
2014-05-06 14:36   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: ac5fb91c541c218b5ace819418834d5e6d311452
Author: Salvador Zapata <salvador.zapata <at> gmail.com>
Date: Tue May 06 09:35:25 2014 -0300
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ac5fb91c541c218b5ace819418834d5e6d311452 [^]

Fixed issue 26389: best deal case shouldn't be calculated on returns

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0066842)
hgbot   
2014-05-06 14:45   
Repository: erp/pmods/org.openbravo.retail.discounts.bestdeal
Changeset: a385edb70dbd94834a9a060621452f935b4afc29
Author: Salvador Zapata <salvador.zapata <at> gmail.com>
Date: Tue May 06 09:44:23 2014 -0300
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bestdeal/rev/a385edb70dbd94834a9a060621452f935b4afc29 [^]

Fixed issue 26389: best deal case shouldn't be calculated on returns

---
M web/org.openbravo.retail.discounts.bestdeal/source/discounts-best-deal-case.js
---
(0066853)
szapata   
2014-05-06 17:24   
(edited on: 2014-05-06 17:27)
Wrong commit message. The commits above fixes:
https://issues.openbravo.com/view.php?id=26391 [^]
(0066856)
hgbot   
2014-05-06 17:38   
Repository: erp/pmods/org.openbravo.retail.posterminal.cds
Changeset: b174f9b3459d7a01585fab83c3399ab1e568c5f4
Author: Salvador Zapata <salvador.zapata <at> gmail.com>
Date: Tue May 06 09:35:25 2014 -0300
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.cds/rev/b174f9b3459d7a01585fab83c3399ab1e568c5f4 [^]

Fixed issue 26389: best deal case shouldn't be calculated on returns

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0067046)
hgbot   
2014-05-09 16:01   
Repository: erp/pmods/org.openbravo.retail.posterminal.unstablenetworks
Changeset: ac5fb91c541c218b5ace819418834d5e6d311452
Author: Salvador Zapata <salvador.zapata <at> gmail.com>
Date: Tue May 06 09:35:25 2014 -0300
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.unstablenetworks/rev/ac5fb91c541c218b5ace819418834d5e6d311452 [^]

Fixed issue 26389: best deal case shouldn't be calculated on returns

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0067507)
marvintm   
2014-05-28 09:32   
This issue was finally fixed by the following changesets:

https://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bestdeal/rev/7188e784cf6c [^]

https://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.combo/rev/158f8361fb5b [^]
(0067606)
Orekaria   
2014-05-30 10:57   
Tested in head 71ac85d89457