Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0026308Openbravo ERP00. Application dictionarypublic2014-04-16 14:432014-05-07 18:12
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PriorityimmediateSeveritycriticalReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR14Q2Fixed in Version 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression levelCoding ( Testing )
Regression date2014-03-05
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/1ea574e6513c [^]
Triggers an Emergency PackNo
Summary0026308: Product Characteristics tree is not working in the Product Charactecteristics window
DescriptionWhen the tree grid view is displayed in the Value field of the Product Characteristic window, an error is shown in the console and the loading message is not hidden.
Steps To Reproduce- Open the Product Characteristic window
- Create a Product Characteristic
- Move to the Value tab
- Create a Value
- Open the tree grid view
- See that the value is not shown, that the loading message is not hidden and that there is an error in the console
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
has duplicate defect 0026340RR14Q2 closed AugustoMauch Retail Modules [RR14Q2] "Tree" icon in product characteristic does not work 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-04-16 14:43AugustoMauchNew Issue
2014-04-16 14:43AugustoMauchAssigned To => AugustoMauch
2014-04-16 14:43AugustoMauchModules => Core
2014-04-16 14:43AugustoMauchOBNetwork customer => No
2014-04-16 14:43AugustoMauchTriggers an Emergency Pack => No
2014-04-16 15:01AugustoMauchRegression level => Coding ( Testing )
2014-04-16 15:01AugustoMauchRegression date => 2014-03-05
2014-04-16 15:01AugustoMauchRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/1ea574e6513c [^]
2014-04-16 15:11AugustoMauchIssue Monitored: alostale
2014-04-16 15:12AugustoMauchReview Assigned To => alostale
2014-04-16 15:18hgbotCheckin
2014-04-16 15:18hgbotNote Added: 0066500
2014-04-16 15:18hgbotStatusnew => resolved
2014-04-16 15:18hgbotResolutionopen => fixed
2014-04-16 15:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d67ab4f96f4d1fa9d64bd81637796354139bbb70 [^]
2014-04-16 15:21AugustoMauchNote Added: 0066502
2014-04-16 15:24AugustoMauchNote Added: 0066503
2014-04-23 09:34alostaleNote Added: 0066547
2014-04-23 09:34alostaleStatusresolved => closed
2014-04-23 09:34alostaleFixed in Version => PR14Q2
2014-04-23 09:39AugustoMauchRelationship addedhas duplicate 0026340
2014-04-24 13:47AugustoMauchNote Added: 0066577
2014-04-24 13:47AugustoMauchStatusclosed => new
2014-04-24 13:47AugustoMauchResolutionfixed => open
2014-04-24 13:47AugustoMauchFixed in VersionPR14Q2 =>
2014-04-24 14:04hgbotCheckin
2014-04-24 14:04hgbotNote Added: 0066581
2014-04-24 14:04hgbotStatusnew => resolved
2014-04-24 14:04hgbotResolutionopen => fixed
2014-04-24 14:04hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/d67ab4f96f4d1fa9d64bd81637796354139bbb70 [^] => http://code.openbravo.com/erp/devel/pi/rev/49791985066fc9fa89c5270a213ea0f90138e265 [^]
2014-04-24 14:36alostaleStatusresolved => closed
2014-05-07 18:11hudsonbotCheckin
2014-05-07 18:11hudsonbotNote Added: 0066945
2014-05-07 18:12hudsonbotCheckin
2014-05-07 18:12hudsonbotNote Added: 0066969

Notes
(0066500)
hgbot   
2014-04-16 15:18   
Repository: erp/devel/pi
Changeset: d67ab4f96f4d1fa9d64bd81637796354139bbb70
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Apr 16 15:11:44 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d67ab4f96f4d1fa9d64bd81637796354139bbb70 [^]

Fixes issue 26308: Product Characteristics tree is not working properly

The problem was that the Product Characteristics TreeType ('CH') had been added to the wrong table. It should have been added to the table used in the Value subtab of the Product Characteristic window, but it had been added to the header tab.

---
M src-db/database/sourcedata/AD_TABLE.xml
---
(0066502)
AugustoMauch   
2014-04-16 15:21   
The UpdateADTrees modulescript uses the table treetype to set the ad_table_id column of the ad_trees. The M_CH_VALUE table did not have a treetype, so the ad_table_id field of its tree was not being updated with the table id.

The tree datasource fetches the trees from AD_Tree using the ad_table_id. This column was not set for the Product Characteristic Value tree, so the datasource was not able to find the tree.
(0066503)
AugustoMauch   
2014-04-16 15:24   
This change does not affect the tree shown in the filter of the columns that use the Product Characteristics reference.
(0066547)
alostale   
2014-04-23 09:34   
code reviewed + verified
(0066577)
AugustoMauch   
2014-04-24 13:47   
Reopened because it still can be reproduced.

The Product Characteristics tree is not included in the sourcedata, it is created when the first Product Characteristic is added.

The previous fix only worked if the tree was already created, but it did not work in instances that did not have yet any product characteristics defined.
(0066581)
hgbot   
2014-04-24 14:04   
Repository: erp/devel/pi
Changeset: 49791985066fc9fa89c5270a213ea0f90138e265
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Apr 24 14:03:37 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/49791985066fc9fa89c5270a213ea0f90138e265 [^]

Fixes issue 26308: Product Characteristics tree is not working properly

The previous fix worked only if the product characteristic tree was already created.

The product characteristic tree is created when the first product characteristic is defined. The tree was being created without ad_table_id, and this column was not being set properly until the modulescripts are executed.

This has been fixed by providing the proper ad_table_id in the tree creation.

---
M src-db/database/model/triggers/M_CHARACTERISTIC_TRG.xml
---
(0066945)
hudsonbot   
2014-05-07 18:11   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/02ca2648bcdc [^]
Maturity status: Test
(0066969)
hudsonbot   
2014-05-07 18:12   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/02ca2648bcdc [^]
Maturity status: Test