Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0026253Openbravo ERPB. User interfacepublic2014-04-11 13:232014-05-12 09:40
Reporterjonalegriaesarte 
Assigned Toguillermogil 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0PR14Q3Fixed in Version3.0PR14Q2 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0026253: Trash button in product window, image field is not removing the image from database
DescriptionTrash button in product window, image field is not removing the image from database. This affects to the size of the database, and the system is mainting data not needed in the database
Steps To Reproduce- Create a product
- Add an image
- Remove image using trash button
- Notice that the image is not removed from database
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00251583.0MP31 closed dbaz Uploaded image cannot be deleted 
has duplicate defect 0028170 closed AugustoMauch Images are not deleted when you delete from the UI 
related to defect 0034491 acknowledged Triage Platform Base Review access for DeleteImageActionHandler class 
related to design defect 0034773 acknowledged Triage Platform Base Images uploaded in an existing record and later removed without saving changes are not removed from database 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-04-11 13:23jonalegriaesarteNew Issue
2014-04-11 13:23jonalegriaesarteAssigned To => AugustoMauch
2014-04-11 13:23jonalegriaesarteModules => Core
2014-04-11 13:23jonalegriaesarteResolution time => 1403474400
2014-04-11 13:23jonalegriaesarteTriggers an Emergency Pack => No
2014-04-11 13:35AugustoMauchRelationship addedrelated to 0025158
2014-04-28 11:32guillermogilAssigned ToAugustoMauch => guillermogil
2014-04-29 11:09guillermogilIssue Monitored: shankarb
2014-04-29 11:09guillermogilReview Assigned To => shankarb
2014-04-30 13:08guillermogilIssue End Monitor: shankarb
2014-04-30 13:08guillermogilIssue Monitored: alostale
2014-04-30 13:08guillermogilReview Assigned Toshankarb => alostale
2014-04-30 13:14hgbotCheckin
2014-04-30 13:14hgbotNote Added: 0066705
2014-04-30 13:14hgbotStatusnew => resolved
2014-04-30 13:14hgbotResolutionopen => fixed
2014-04-30 13:14hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4ffde15873c911075a468f4003eb0b4be2a2ac64 [^]
2014-05-05 11:03hgbotCheckin
2014-05-05 11:03hgbotNote Added: 0066802
2014-05-05 11:14hgbotCheckin
2014-05-05 11:14hgbotNote Added: 0066803
2014-05-05 12:42hgbotCheckin
2014-05-05 12:42hgbotNote Added: 0066808
2014-05-07 18:12hudsonbotCheckin
2014-05-07 18:12hudsonbotNote Added: 0066983
2014-05-07 18:12hudsonbotCheckin
2014-05-07 18:12hudsonbotNote Added: 0066996
2014-05-07 18:12hudsonbotCheckin
2014-05-07 18:12hudsonbotNote Added: 0066997
2014-05-07 18:12hudsonbotCheckin
2014-05-07 18:12hudsonbotNote Added: 0066998
2014-05-12 09:40alostaleNote Added: 0067085
2014-05-12 09:40alostaleStatusresolved => closed
2014-05-12 09:40alostaleFixed in Version => PR14Q2
2014-11-14 14:46alostaleRelationship addedhas duplicate 0028170
2016-11-14 13:30caristuRelationship addedrelated to 0034491
2016-12-19 18:54caristuRelationship addedrelated to 0034773

Notes
(0066705)
hgbot   
2014-04-30 13:14   
Repository: erp/devel/pi
Changeset: 4ffde15873c911075a468f4003eb0b4be2a2ac64
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Wed Apr 30 13:14:01 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4ffde15873c911075a468f4003eb0b4be2a2ac64 [^]

Fixed issue 26253: Images are not removing from database

Added an action handler to remove the images that are deleted on a new created entity and added and event handler that listens the delete and update event of the entities that have images

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ImagesActionHandler.java
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-image.js
M src/org/openbravo/base/model/ModelProvider.java
M src/org/openbravo/erpCommon/utility/ImageUtils.java
A modules/org.openbravo.client.application/src/org/openbravo/client/application/DeleteImageActionHandler.java
A modules/org.openbravo.client.application/src/org/openbravo/client/application/event/RemoveImagesEventHandler.java
---
(0066802)
hgbot   
2014-05-05 11:03   
Repository: erp/devel/pi
Changeset: 2d653c3624c383c9388561012a105b3ce3ec2411
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Mon May 05 11:03:21 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2d653c3624c383c9388561012a105b3ce3ec2411 [^]

Related to issue 26253: Apply code review

Added property to hashmap

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/event/RemoveImagesEventHandler.java
M src/org/openbravo/base/model/ModelProvider.java
---
(0066803)
hgbot   
2014-05-05 11:14   
Repository: erp/devel/pi
Changeset: abd08a73204245632aef50a8f025462b33cbc60d
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Mon May 05 11:13:29 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/abd08a73204245632aef50a8f025462b33cbc60d [^]

Related to issue 26253: Removed debug code

---
M src/org/openbravo/base/model/ModelProvider.java
---
(0066808)
hgbot   
2014-05-05 12:42   
Repository: erp/devel/pi
Changeset: 2f2de88e903aeadcb01caabc5aa240a5d2c8c76f
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Mon May 05 12:42:05 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2f2de88e903aeadcb01caabc5aa240a5d2c8c76f [^]

Related to issue 26253: Applied code review

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/event/RemoveImagesEventHandler.java
M src/org/openbravo/base/model/ModelProvider.java
---
(0066983)
hudsonbot   
2014-05-07 18:12   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/02ca2648bcdc [^]
Maturity status: Test
(0066996)
hudsonbot   
2014-05-07 18:12   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/02ca2648bcdc [^]
Maturity status: Test
(0066997)
hudsonbot   
2014-05-07 18:12   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/02ca2648bcdc [^]
Maturity status: Test
(0066998)
hudsonbot   
2014-05-07 18:12   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/02ca2648bcdc [^]
Maturity status: Test
(0067085)
alostale   
2014-05-12 09:40   
code reviewed and tested

Known cases where deletion does not occur:
1. Image is uploaded and without saving record, "Cancel Changes" button is clicked
2. Having a record with image a new one in added and after that is is replaced with a new one