Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0026131Retail ModulesWeb POSpublic2014-04-01 10:582014-04-03 17:14
Reportergorkaion 
Assigned Togorkaion 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS20OS VersionGentoo
Product Version 
Target VersionRR14Q2Fixed in VersionRR14Q2 
Merge Request Status
Review Assigned Tomalsasua
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0026131: Merge lines of same promotion does not properly check lines without any promotion
DescriptionThe merge lines of same promotion function does not properly check lines without promotions.

It checks that the 'promotions' property does not exists but does not check if it exists as an empty array.
Steps To ReproduceInstall combo discounts and/or two families discounts.
configure a combo
create a ticket with lines forcing a split by setting more quantity than needed for a combo.
remove units so the combo cannot be applied
check that the lines are not merged back.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-04-01 10:58gorkaionNew Issue
2014-04-01 10:58gorkaionAssigned To => gorkaion
2014-04-01 10:58gorkaionTriggers an Emergency Pack => No
2014-04-01 10:58gorkaionReview Assigned To => malsasua
2014-04-01 11:01hgbotCheckin
2014-04-01 11:01hgbotNote Added: 0065651
2014-04-01 11:01hgbotStatusnew => resolved
2014-04-01 11:01hgbotResolutionopen => fixed
2014-04-01 11:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d42757752957c6f2f621caadbc62959f1d53f9ee [^]
2014-04-01 11:23malsasuaNote Added: 0065652
2014-04-01 11:23malsasuaStatusresolved => closed
2014-04-01 11:23malsasuaFixed in Version => RR14Q2
2014-04-03 16:46hgbotCheckin
2014-04-03 16:46hgbotNote Added: 0066152
2014-04-03 16:46hgbotStatusclosed => resolved
2014-04-03 16:46hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d42757752957c6f2f621caadbc62959f1d53f9ee [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.cds/rev/d42757752957c6f2f621caadbc62959f1d53f9ee [^]
2014-04-03 17:14malsasuaNote Added: 0066157
2014-04-03 17:14malsasuaStatusresolved => closed

Notes
(0065651)
hgbot   
2014-04-01 11:01   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d42757752957c6f2f621caadbc62959f1d53f9ee
Author: Gorka Ion Damián <gorkaion.damian <at> openbravo.com>
Date: Tue Apr 01 10:57:11 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d42757752957c6f2f621caadbc62959f1d53f9ee [^]

Fixed issue 26131.Also check lines with empty promotions arrays.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0065652)
malsasua   
2014-04-01 11:23   
verified
(0066152)
hgbot   
2014-04-03 16:46   
Repository: erp/pmods/org.openbravo.retail.posterminal.cds
Changeset: d42757752957c6f2f621caadbc62959f1d53f9ee
Author: Gorka Ion Damián <gorkaion.damian <at> openbravo.com>
Date: Tue Apr 01 10:57:11 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.cds/rev/d42757752957c6f2f621caadbc62959f1d53f9ee [^]

Fixed issue 26131.Also check lines with empty promotions arrays.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0066157)
malsasua   
2014-04-03 17:14   
closed again