Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0026122Retail ModulesWeb POSpublic2014-03-28 14:352014-04-03 17:14
Reportergorkaion 
Assigned Togorkaion 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR14Q2Fixed in VersionRR14Q2 
Merge Request Status
Review Assigned Tomalsasua
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0026122: Merge lines of same promotion does not consider products with diferent discounts
DescriptionIn case there is a promotion that can apply different discounts to a same product the merge lines of same promotion does not work.

For example a buy X units and get one free of a product. This would create a line with the X units and 0 discount and another line of the same product with 100% of discount. Both lines belong to the same promotion but shouldn't be merged.
Steps To ReproduceInstall "Two Families Discount" module.
Enable the best deal case.
configure a promotion with 2 families. both applying to the same product.
create a receipt that will apply the promotion.
Pay it so the best deal case is calculated.

Both lines of the receipt will be merged in one loosing the discount information.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-03-28 14:35gorkaionNew Issue
2014-03-28 14:35gorkaionAssigned To => gorkaion
2014-03-28 14:35gorkaionTriggers an Emergency Pack => No
2014-03-28 14:49hgbotCheckin
2014-03-28 14:49hgbotNote Added: 0065588
2014-03-28 14:49hgbotStatusnew => resolved
2014-03-28 14:49hgbotResolutionopen => fixed
2014-03-28 14:49hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d819bac0843e91ca980af3e091a22f8b6079beef [^]
2014-04-01 09:55malsasuaReview Assigned To => malsasua
2014-04-01 09:55malsasuaNote Added: 0065648
2014-04-01 09:55malsasuaStatusresolved => closed
2014-04-01 09:55malsasuaFixed in Version => RR14Q2
2014-04-03 16:45hgbotCheckin
2014-04-03 16:45hgbotNote Added: 0066147
2014-04-03 16:45hgbotStatusclosed => resolved
2014-04-03 16:45hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d819bac0843e91ca980af3e091a22f8b6079beef [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.cds/rev/d819bac0843e91ca980af3e091a22f8b6079beef [^]
2014-04-03 17:14malsasuaNote Added: 0066156
2014-04-03 17:14malsasuaStatusresolved => closed

Notes
(0065588)
hgbot   
2014-03-28 14:49   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d819bac0843e91ca980af3e091a22f8b6079beef
Author: Gorka Ion Damián <gorkaion.damian <at> openbravo.com>
Date: Fri Mar 28 14:46:04 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d819bac0843e91ca980af3e091a22f8b6079beef [^]

Fixed issue 26122.Fixed issue 26123.
* Added family to the promotion information so promotions using it can add it
  and the mergeLinesWithSamePromotions can differentiate lines of different
  families during the merge.
* Add a return statement on the splitLine function when a new line is created.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0065648)
malsasua   
2014-04-01 09:55   
verified
(0066147)
hgbot   
2014-04-03 16:45   
Repository: erp/pmods/org.openbravo.retail.posterminal.cds
Changeset: d819bac0843e91ca980af3e091a22f8b6079beef
Author: Gorka Ion Damián <gorkaion.damian <at> openbravo.com>
Date: Fri Mar 28 14:46:04 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.cds/rev/d819bac0843e91ca980af3e091a22f8b6079beef [^]

Fixed issue 26122.Fixed issue 26123.
* Added family to the promotion information so promotions using it can add it
  and the mergeLinesWithSamePromotions can differentiate lines of different
  families during the merge.
* Add a return statement on the splitLine function when a new line is created.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0066156)
malsasua   
2014-04-03 17:14   
closed again